Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 5700 - no click for KP title without additional elements #5709

Merged
merged 3 commits into from
Oct 20, 2024

Conversation

monsieurtanuki
Copy link
Contributor

What

  • Now we check if a KP title has additional elements to display.
  • If not, we don't make it clickable - no tap action, no forward arrow.

Fixes bug(s)

Impacted files

  • knowledge_panel_card.dart: overrides the "isClickable" parameter in case there are eventually no further elements to display
  • knowledge_panels_builder.dart: new helper methods

Impacted files:
* `knowledge_panel_card.dart`: overrides the "isClickable" parameter in case there are eventually no further elements to display
* `knowledge_panels_builder.dart`: new helper methods
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 6.78%. Comparing base (4d9c7fc) to head (a30f332).
Report is 377 commits behind head on develop.

Files with missing lines Patch % Lines
.../lib/knowledge_panel/knowledge_panels_builder.dart 0.00% 17 Missing ⚠️
...e_panel/knowledge_panels/knowledge_panel_card.dart 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5709      +/-   ##
==========================================
- Coverage     9.54%   6.78%   -2.77%     
==========================================
  Files          325     404      +79     
  Lines        16411   21601    +5190     
==========================================
- Hits          1567    1466     -101     
- Misses       14844   20135    +5291     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. It can be tested on .net

@monsieurtanuki monsieurtanuki merged commit 29f433c into openfoodfacts:develop Oct 20, 2024
6 checks passed
@monsieurtanuki
Copy link
Contributor Author

Thank you @teolemon for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Do not make knowledge panels tappable if they contain only a title and no elements
3 participants