Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments box should respect line return + avoid '#' #209

Closed
Tracked by #167
alexgarel opened this issue Jan 27, 2023 · 8 comments
Closed
Tracked by #167

Comments box should respect line return + avoid '#' #209

alexgarel opened this issue Jan 27, 2023 · 8 comments

Comments

@alexgarel
Copy link
Member

alexgarel commented Jan 27, 2023

  • make ‘#’ automatically handled (do not show them in the front, let add them when saving)
  • make the text box larger
  • make it respect “\n” as lines
@alexgarel alexgarel changed the title work on comments box Comments box should respect line return + avoid '#' Jan 27, 2023
@harivamsi9
Copy link

Hey can i do this?

@alexgarel
Copy link
Member Author

@harivamsi9 if no one is on a bug, just signal you are taking it … and go :-)

@mahak24342
Copy link

i wanna take up this issue , please assign me this issue

@alexgarel
Copy link
Member Author

To explain point 1 and 3:
we have a comment field which contains something like:

# this is a multi
# line
# comment

Currently this is displayed as
# this is a multi # line # comment

So we should display it as:

this is a multi
line
comment

This may mean doing a transformation before displaying and before saving:

  • before displaying: stripping the "#", replacing '\n' by '
    \n' (?)
  • before saving: replace
    \n or
    by \n, add '#' as first char on each line
    (but it may also be implemented otherwise).

IMO it should be handled client side.

@eeshaanSA
Copy link
Contributor

Do you mean the Comment box in this section?
So as far as I have understood, any new comments we add with the taxonomy editor (multi line comments), they are still parsed as a single line in the taxonomy.txt file?
image

@alexgarel
Copy link
Member Author

yep, this one box :-)

@aadarsh-ram
Copy link
Collaborator

Do you mean the Comment box in this section? So as far as I have understood, any new comments we add with the taxonomy editor (multi line comments), they are still parsed as a single line in the taxonomy.txt file?

Comments in the taxonomy editor are separated by newline characters. Any line not ended with a newline character, will be considered as one comment. (it's a similar system to python, if that makes sense)

In the screenshot, the description is a very long comment, which will be treated as a single comment. On the other hand, each translation has a newline associated with it, so they are multiple comments.

@alexgarel
Copy link
Member Author

This one is outdated.

We finally conclude that comment are at the property level.

We need to have a general reflexion on how to display comments in the interface, and eventually make them editable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants