Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different format for scores #43

Closed
pel-daniel opened this issue Jun 29, 2024 · 2 comments
Closed

Different format for scores #43

pel-daniel opened this issue Jun 29, 2024 · 2 comments

Comments

@pel-daniel
Copy link

👋🏽 Thanks for the project!
I noticed that the format of scores for the year 2020 is different than for 2024.
What's a good way to contribute a PR to fix it, as I see that these files are probably auto-generated from the https://github.com/openfootball/euro repo

@geraldb
Copy link
Member

geraldb commented Jun 29, 2024

welcome to football.db. good catch. yes, the format is changing. i updated the euro 2020 (2021) json datafiles to the new (score) format. yes, the json files are auto-generated. see here for the quick & dirty script - https://github.com/yorobot/sport.db.more/blob/master/sportdb-exporters/lib/sportdb/exporters/json_exporter_euro.rb

@geraldb geraldb transferred this issue from openfootball/euro.json Jun 29, 2024
@pel-daniel
Copy link
Author

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants