PropertyIsNilOperatorTests.propertyIsNil (HTTP POST) sends invalid request

[JulienCharon]

Our WFS offers instances of 2 feature types. When running the test suite, the POST version of Basic WFS test Property Is Nil fails because it sends an invalid request:

<wfs:GetFeature xmlns:wfs="http://www.opengis.net/wfs/2.0" count="10" service="WFS" startIndex="0" version="2.0.0">
                <wfs:Query xmlns:ns73="urn:x-inspire:specification:gmlas:GeographicalNames:3.0" typeNames="ns73:NamedPlace">
                               <Filter xmlns="http://www.opengis.net/fes/2.0">
                                               <PropertyIsNil>
                                                               <ValueReference xmlns:tns="urn:x-inspire:specification:gmlas:GeographicalNames:3.0">tns:type</ValueReference>
                                               </PropertyIsNil>
                               </Filter>
                               <Filter xmlns="http://www.opengis.net/fes/2.0">
                                               <PropertyIsNil>
                                                               <ValueReference xmlns:tns="urn:x-inspire:specification:gmlas:ProtectedSites:3.0">tns:siteProtectionClassification</ValueReference>
                                               </PropertyIsNil>
                               </Filter>
                </wfs:Query>
                <wfs:Query xmlns:ns5="urn:x-inspire:specification:gmlas:ProtectedSites:3.0" typeNames="ns5:ProtectedSite"/>
</wfs:GetFeature>

According to query schema, an AbstractAdhocQueryExpressionType can only contain a single AbstractSelectionClause (i.e. FIlter) or none at all. The one sent contains 2 of them.

Thus, the request must be:

<wfs:GetFeature xmlns:wfs="http://www.opengis.net/wfs/2.0" count="10" service="WFS" startIndex="0" version="2.0.0">
                <wfs:Query xmlns:ns73="urn:x-inspire:specification:gmlas:GeographicalNames:3.0" typeNames="ns73:NamedPlace">
                               <Filter xmlns="http://www.opengis.net/fes/2.0">
                                               <PropertyIsNil>
                                                               <ValueReference xmlns:tns="urn:x-inspire:specification:gmlas:GeographicalNames:3.0">tns:type</ValueReference>
                                               </PropertyIsNil>
                               </Filter>                             
                </wfs:Query>
                <wfs:Query xmlns:ns5="urn:x-inspire:specification:gmlas:ProtectedSites:3.0" typeNames="ns5:ProtectedSite">
                               <Filter xmlns="http://www.opengis.net/fes/2.0">
                                               <PropertyIsNil>
                                                               <ValueReference xmlns:tns="urn:x-inspire:specification:gmlas:ProtectedSites:3.0">tns:siteProtectionClassification</ValueReference>
                                               </PropertyIsNil>
                               </Filter>              
                </wfs:Query>
</wfs:GetFeature>

[rjmartell]

The propertyIsNil test (in PropertyIsNilOperatorTests) iterates through nillable properties found in the app schema. However, the request entity is not being reset between requests so all requests after the first one are “polluted” with previous queries.