Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test "update Simple Property Value" does not consider decimal data type (plus various others) #34

Closed
dstenger opened this issue Jun 6, 2016 · 2 comments
Assignees
Labels

Comments

@dstenger
Copy link
Contributor

dstenger commented Jun 6, 2016

If the test "update Simple Property Value" tries to update a property with data type decimal, an empty value is inserted as the data type is not supported by the ETS.

The relevant method is #newPropertyValue in [1]. The data types string, datetime and double are considered but other data types are missing.

Example for generated request:

<wfs:Transaction xmlns:wfs="http://www.opengis.net/wfs/2.0" xmlns:gml="http://www.opengis.net/gml/3.2" xmlns:tns="http://www.deegree.org/app"
  service="WFS" version="2.0.0">
  <wfs:Update typeName="tns:ft">
    <wfs:Property>
      <wfs:ValueReference>tns:property[1]</wfs:ValueReference>
      <wfs:Value />
    </wfs:Property>
    <fes:Filter xmlns:fes="http://www.opengis.net/fes/2.0">
      <fes:ResourceId rid="ft_-6187774" />
    </fes:Filter>
  </wfs:Update>
</wfs:Transaction>

[1] https://github.com/opengeospatial/ets-wfs20/blob/b6aded3cfa402628a41ae33bf5d66d01ddcbf127/src/main/java/org/opengis/cite/iso19142/transaction/Update.java

@rjmartell
Copy link
Contributor

Yes, more cases need to be added to to the newPropertyValue method.

@rjmartell
Copy link
Contributor

rjmartell commented Jul 12, 2016

Fixed handling of xsd:dateTime values. Added support for xsd:date, xsd:decimal, xsd:float, xsd:integer, xsd;anyURI, xsd:boolean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants