Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROJJSON schema version #180

Open
kylebarron opened this issue Jul 27, 2023 · 4 comments
Open

PROJJSON schema version #180

kylebarron opened this issue Jul 27, 2023 · 4 comments
Assignees
Milestone

Comments

@kylebarron
Copy link
Collaborator

Right now the Parquet json schema links to PROJJSON schema version 0.5:

"$ref": "https://proj.org/schemas/v0.5/projjson.schema.json"

But PROJJSON is now on version 0.6:
https://proj.org/en/9.2/schemas/v0.6/projjson.schema.json

How do we want to handle the referenced projjson schema version?

@tschaub
Copy link
Collaborator

tschaub commented Jul 27, 2023

I think it makes sense to relax the test_json_schema.py script so it doesn't make an assertion about the $schema member of the crs object. The important part is that the rest of the crs object is compatible with the projjson schema (and that schema doesn't have any requirements about the $schema property).

@kylebarron
Copy link
Collaborator Author

I agree for #179 specifically we don't need to resolve this, but as a broader question as GeoParquet gets closer to 1.0: how do we want to handle the fact that we're interlinked to another evolving specification? If we go to 1.0, and then PROJJSON makes a breaking change or goes to 1.0 itself, then would we need to release a 2.0 that uses the new version of PROJJSON?

Otherwise users on the latest version of PROJ would be writing Parquet files that don't pass the validator

@tschaub
Copy link
Collaborator

tschaub commented Jul 27, 2023

Yeah, I agree that the broader question is important to address. Users cannot easily control what version of PROJ is installed, so they cannot easily control what version of PROJJSON is written. So tools that generate GeoParquet will have a difficult time ensuring that they write out metadata that is compliant with any particular GeoParquet version that depends on a fixed version of PROJJSON.

@tschaub tschaub added this to the 1.0.0 milestone Jul 27, 2023
@m-mohr
Copy link
Collaborator

m-mohr commented Mar 15, 2024

It get's even more difficult and an update might be required: OSGeo/PROJ#4088

@m-mohr m-mohr self-assigned this Mar 25, 2024
@m-mohr m-mohr modified the milestones: 1.0.0, 1.0.1 Mar 25, 2024
@cholmes cholmes modified the milestones: 1.1, 1.2 Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants