Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some (micro) optimizations of feature form #5647

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Some (micro) optimizations of feature form #5647

merged 2 commits into from
Sep 17, 2024

Conversation

nirvn
Copy link
Member

@nirvn nirvn commented Sep 14, 2024

Shaving off 100-200ms on large-ish feature form configurations.

@3nids , this follows the discussion we had on google chat yesterday.

@qfield-fairy
Copy link
Collaborator

qfield-fairy commented Sep 14, 2024

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/core/attributeformmodelbase.cpp Show resolved Hide resolved
Copy link
Member

@3nids 3nids left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@nirvn nirvn merged commit 4ea26a6 into master Sep 17, 2024
23 checks passed
@nirvn nirvn deleted the avoid_cost branch September 17, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants