Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java 11 compatibility required #5162

Closed
11 tasks done
davidgraeff opened this issue Mar 19, 2019 · 14 comments
Closed
11 tasks done

Java 11 compatibility required #5162

davidgraeff opened this issue Mar 19, 2019 · 14 comments
Labels
help wanted infrastructure Build system and Karaf related issues and PRs

Comments

@davidgraeff
Copy link
Member

davidgraeff commented Mar 19, 2019

All new add-ons must be compatible to Java 11 without deprecation warnings from here on.

To be ported:

  • org.openhab.binding.avmfritz
  • org.openhab.binding.dlinksmarthome
  • org.openhab.binding.denonmarantz
  • org.openhab.binding.dwdunwetter
  • org.openhab.binding.helios
  • org.openhab.binding.homematic
  • org.openhab.binding.ihc
  • org.openhab.binding.tellstick
  • org.openhab.binding.toon
  • org.openhab.binding.yamahareceiver
  • org.openhab.transform.xpath
@davidgraeff davidgraeff added the infrastructure Build system and Karaf related issues and PRs label Mar 19, 2019
@davidgraeff davidgraeff pinned this issue Mar 19, 2019
@EliasGabrielsson
Copy link

@davidgraeff When will openHAB have a strict requirement on Java 11. Will that transition happen in next version? Need to know that so we can have migration code ready in openhabian.

@davidgraeff
Copy link
Member Author

Not this year. The core and majority of bindings will be Java 8 and 11 compatible, that's the goal.

But I remember a discussion with Kai that certain bundles may be allowed to require more than Java 8 (my question at that time was regarding the DTLS support which greatly improved in Java 9).

@EliasGabrielsson
Copy link

Nice, that gives us a great update window. When does openHAB aim be java 11 compatible™, i.e. when can we start the transition to Java 11?

@davidgraeff
Copy link
Member Author

That depends on how important openhab1-addon users are to you, because we will not migrate those bindings anymore. As soon as you switch over to 11 half of those bindings will fail probably :/

At the moment it looks like OH 2.5 Core and Addons (minus the OH1-combat layer) will be java 11 compatible.

@wborn
Copy link
Member

wborn commented Mar 21, 2019

Currently nrjavaserial (required by all bindings using serial comms) crashes the whole runtime on Windows with Java 11 (NeuronRobotics/nrjavaserial#131). So I'd like to see that fixed too before declaring openHAB to be Java 11 compatible. Most known issues are linked to openhab/openhab-distro#768.

Hopefully the visibility of this issue also makes contributors create PRs for better Java 11 compatibility. :-) Most Travis CI builds now also have a Java 11 build so it has become more visible what still needs to be fixed.

@J-N-K
Copy link
Member

J-N-K commented Mar 25, 2019

Can you confirm that the proposed fix indeed is everything that is needed in nrjavaserial? The linked issues seems to state that there are more problems.

@wborn
Copy link
Member

wborn commented Mar 25, 2019

I'm only occasionally using Windows myself. So I haven't thoroughly tested the nrjavaserial Java 11 Windows fix myself.

@J-N-K
Copy link
Member

J-N-K commented Mar 29, 2019

What exactly is the problem with homematic? It compiles and passes feature verification on Java 11 without modification.

@davidgraeff
Copy link
Member Author

Tick it off ^^

@cweitkamp
Copy link
Contributor

Maybe it is a false positive because of javax.xml.bind in its manifest.

https://github.com/openhab/openhab2-addons/blob/6f84f1562474f4512ff5ef97d71bd1ce24d7b820/addons/binding/org.openhab.binding.homematic/META-INF/MANIFEST.MF#L22

@wborn
Copy link
Member

wborn commented Mar 30, 2019

Now that #5338 is merged we enforce that all code compiles with Java 11.

The add-ons that were still open in the list use the javax.xml.xpath, javax.ws.rs packages which are still available in Java 11. See Dependencies On Java EE Modules for all packages that are impacted.

@davidgraeff
Copy link
Member Author

Has someone changed Travis already to enforce j11? Then we can close this issue

@davidgraeff davidgraeff unpinned this issue Mar 31, 2019
@dbadia
Copy link

dbadia commented Apr 11, 2019

I see consistent JVM crashes on windows due to the nrjavaserial issue with Java 11 (NeuronRobotics/nrjavaserial#131) as mentioned by @wborn. I am working on the zwave addon

Is this problem being tracked in a different issue as this one is closed?

@wborn
Copy link
Member

wborn commented Apr 11, 2019

There's also a openhab/openhab-distro#768 (comment) for this. That's the overarching issue to fix issues encountered while running openHAB with Java 11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted infrastructure Build system and Karaf related issues and PRs
Projects
None yet
Development

No branches or pull requests

6 participants