Initial contribution of Homie Binding #1741

gorootde · 2017-01-21T01:20:30Z

Inital Contribution: Binding for Homie Devices

ThomDietrich · 2017-01-25T15:58:20Z

Hey @Kwave, the README is missing the tables for channels and the "full example". These would be needed for manual configuration.

kubawolanin · 2017-01-30T17:53:18Z

addons/binding/org.openhab.binding.homie/.classpath

@@ -0,0 +1,9 @@
+<?xml version="1.0" encoding="UTF-8"?>


Please remove this file from the changeset.
I think we should have them in global .gitignore file, but for now
the best thing we can do is to create an ./git/info/exclude file with the following entries:

.classpath .project /target/

I disagree with you. The classpath is necessary especially for projects that are using additional libraries. If you remove it you will have to recreate it each time you add this project to an Eclipse workspace.

kubawolanin · 2017-01-30T17:54:20Z

addons/binding/org.openhab.binding.homie/.project

@@ -0,0 +1,39 @@
+<?xml version="1.0" encoding="UTF-8"?>


Please remove this file from the changeset.

This file is necessary too when this project is added to an Eclipse workspace. If you look into the existing projects, you will see that all contain a .project and .classpath.

kubawolanin · 2017-01-30T17:55:12Z

addons/binding/org.openhab.binding.homie/.settings/org.eclipse.core.resources.prefs

@@ -0,0 +1,2 @@
+eclipse.preferences.version=1


I wonder if whole .settings folder should be even committed here :)

MHerbst · 2017-01-30T18:47:22Z

addons/binding/org.openhab.binding.homie/.project

+		</buildCommand>
+	</buildSpec>
+	<natures>
+		<nature>org.eclipse.m2e.core.maven2Nature</nature>


Please remove this nature.

jmvaz · 2017-02-15T14:06:30Z

This binding requires one MQTT broker installed or it has one embedded broker?

bodiroga · 2017-02-15T14:48:05Z

The binding connects to an existing MQTT broker (in the binding configuration you need to provide the hostname and port where the broker is running), so you need to install one (Mosquitto, for example) previously.

RomeuCarvalhoPT · 2017-04-07T08:20:58Z

Hey guys, any news about this binding? When will this pull be closed?
It would be very nice to have this binding :)

martinvw · 2017-05-01T15:10:03Z

Opening and closing to trigger a new build

cribskip · 2017-05-09T04:26:46Z

I heard if you put "[WIP]" in the title it will be built automatically.

martinvw · 2017-05-09T06:32:57Z

I heard if you put "[WIP]" in the title it will be built automatically.

It should always do so, [WIP] is just for humans to know that we do not yet have to review :-)

martinvw · 2017-05-09T06:34:17Z

Some errors are reported by the static code analysis:

[ERROR] Failed to execute goal org.openhab.tools:static-code-analysis:0.0.4:report (default) on project org.openhab.binding.homie: Code Analysis Tool has found 13 error(s)!
[ERROR] Please fix the errors and rerun the build.
[ERROR] Errors list:
[ERROR] ERROR found by findbugs: org.openhab.binding.homie.handler.HomieDeviceHandler.java:395 Format should be constant. Use placeholder to reduce the needless cost of parameter construction. see http://www.slf4j.org/faq.html#logging_performance
[ERROR] ERROR found by findbugs: org.openhab.binding.homie.handler.HomieDeviceHandler.java:403 Format should be constant. Use placeholder to reduce the needless cost of parameter construction. see http://www.slf4j.org/faq.html#logging_performance
[ERROR] ERROR found by findbugs: org.openhab.binding.homie.internal.DeviceDiscoveryService.java:
[ERROR] Logger should be non-static field. Change this field (logger) to non-static field.
[ERROR]
[ERROR] ERROR found by findbugs: org.openhab.binding.homie.internal.HomieHandlerFactory.java:71 Format should be constant. Use placeholder to reduce the needless cost of parameter construction. see http://www.slf4j.org/faq.html#logging_performance
[ERROR] ERROR found by findbugs: org.openhab.binding.homie.internal.HomieHandlerFactory.java:
[ERROR] Logger should be non-static field. Change this field (logger) to non-static field.
[ERROR]
[ERROR] ERROR found by findbugs: org.openhab.binding.homie.internal.MqttConnection.java:85 Format should be constant. Use placeholder to reduce the needless cost of parameter construction. see http://www.slf4j.org/faq.html#logging_performance
[ERROR] ERROR found by checkstyle: .binding.homie/about.html:0 Missing about.html file.
[ERROR] ERROR found by findbugs: org.openhab.binding.homie.internal.MqttConnection.java:89 Format should be constant. Use placeholder to reduce the needless cost of parameter construction. see http://www.slf4j.org/faq.html#logging_performance
[ERROR] ERROR found by findbugs: org.openhab.binding.homie.internal.MqttConnection.java:97 Format should be constant. Use placeholder to reduce the needless cost of parameter construction. see http://www.slf4j.org/faq.html#logging_performance
[ERROR] ERROR found by findbugs: org.openhab.binding.homie.internal.MqttConnection.java:112 Format should be constant. Use placeholder to reduce the needless cost of parameter construction. see http://www.slf4j.org/faq.html#logging_performance
[ERROR] ERROR found by findbugs: org.openhab.binding.homie.internal.MqttConnection.java:116 Format should be constant. Use placeholder to reduce the needless cost of parameter construction. see http://www.slf4j.org/faq.html#logging_performance
[ERROR] ERROR found by findbugs: org.openhab.binding.homie.internal.MqttConnection.java:118 Format should be constant. Use placeholder to reduce the needless cost of parameter construction. see http://www.slf4j.org/faq.html#logging_performance
[ERROR] ERROR found by findbugs: org.openhab.binding.homie.internal.MqttConnection.java:
[ERROR] Logger should be non-static field. Change this field (logger) to non-static field.

I also started reviewing but that might take a while :-)

Signed-off-by: Michael Kolb <[email protected]>

martinvw

I have some very early comments, you are still in line for a full review, put these have been pending for so long that I can better send them out now :-)

martinvw · 2017-04-30T14:34:00Z

addons/binding/org.openhab.binding.homie/ESH-INF/binding/binding.xml

+		</parameter>
+
+		<parameter name="basetopic" type="text" required="true">
+            <label>MQTT base topic</label>


The formatting looks incorrect. XML files should be indented using tabs according to our code formatter. Can you please reformat.

martinvw · 2017-04-30T14:34:19Z

addons/binding/org.openhab.binding.homie/ESH-INF/i18n/homie_xx_XX.properties

@@ -0,0 +1,11 @@
+# binding


Remove this file since you did not change anything

martinvw · 2017-05-01T19:43:41Z

addons/binding/org.openhab.binding.homie/META-INF/MANIFEST.MF

+Bundle-Vendor: openHAB
+Bundle-Version: 2.0.0.qualifier
+Bundle-RequiredExecutionEnvironment: JavaSE-1.8
+Bundle-ClassPath: .,lib/org.eclipse.paho.client.mqttv3-1.1.0.jar,lib/commons-lang3-3.5.jar


Please use the build in commons lang

Please use the mqtt io.transport bundle from https://github.com/eclipse/smarthome/tree/master/bundles/io/org.eclipse.smarthome.io.transport.mqtt

As far as I know, there's only commons.lang build in, and not commons.lang3.

This would mean a complete reimplementation of the connection class and its architecture.

I opened an issue for that, but are you using anything specific in this case? Upgrading commons.lang to commons.lang3 eclipse-archived/smarthome#3522

I did not check the exact impact but the idea of the transport bundle is that not all bindings have to duplicate the transport handling and drag along there own jar's. if you require changes in the transport bundle you can of course discuss/suggest them and create a PR

martinvw · 2017-05-01T19:43:59Z

addons/binding/org.openhab.binding.homie/META-INF/MANIFEST.MF

+Bundle-Name: Homie Binding
+Bundle-SymbolicName: org.openhab.binding.homie;singleton:=true
+Bundle-Vendor: openHAB
+Bundle-Version: 2.0.0.qualifier


Version bump to 2.1.0-SNAPSHOT

martinvw · 2017-05-01T19:44:24Z

addons/binding/org.openhab.binding.homie/META-INF/MANIFEST.MF

+Bundle-RequiredExecutionEnvironment: JavaSE-1.8
+Bundle-ClassPath: .,lib/org.eclipse.paho.client.mqttv3-1.1.0.jar,lib/commons-lang3-3.5.jar
+Import-Package: 
+ com.google.common.collect;version="10.0.1",


Do not enforce versions

martinvw · 2017-05-01T19:44:32Z

addons/binding/org.openhab.binding.homie/META-INF/MANIFEST.MF

+ org.eclipse.smarthome.core.types,
+ org.openhab.binding.homie,
+ org.openhab.binding.homie.handler,
+ org.osgi.framework;version="1.8.0",


No versions

martinvw · 2017-05-01T19:44:43Z

addons/binding/org.openhab.binding.homie/OSGI-INF/ChannelTypeProvider.xml

+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+    Copyright (c) 2014-2016 by the respective copyright holders.


It seems that this file has a missing or invalid copyright header, can you fix all of them by running

mvn license:format

Please commit only the ones for your binding.

martinvw · 2017-05-01T19:44:54Z

addons/binding/org.openhab.binding.homie/README.md

+
+If you want openHAB to render your nodes properly, you have to provide the following topics.
+
+| Property | Required |  Message Format | Description | Example (Setable heater temperature) |


You would make me happy by formatting the tables in the MD file as well :-D

http://www.tablesgenerator.com/markdown_tables

Select 'File' > 'Past table data ...' and past the unformatted mark down table, you can then copy paste the formatted table 👍

martinvw · 2017-05-01T19:45:03Z

addons/binding/org.openhab.binding.homie/README.md

+### Topic `value` (inbound)
+The inbound messages (sent from a Homie device to the binding via the `value` topic) are automatically mapped to corresponding ESH command types, depending on the `itemtype` you have choosen. Auto mapping supports the following values:
+
+| inbound message | ESH command type |


You would make me happy by formatting the tables in the MD file as well :-D

http://www.tablesgenerator.com/markdown_tables

Select 'File' > 'Past table data ...' and past the unformatted mark down table, you can then copy paste the formatted table 👍

martinvw · 2017-05-01T19:45:36Z

addons/binding/org.openhab.binding.homie/pom.xml

+	<dependencies>
+		<dependency>
+			<groupId>org.eclipse.paho</groupId>
+			<artifactId>mqtt-client</artifactId>


This feels double besides including it?

Fixed, removed it.

Signed-off-by: Michael Kolb <[email protected]>

sja · 2017-05-27T19:43:36Z

I cannot get it working. My Homie-Node is discovered, but just with "advanced"-Channels like online, name, localip, ...

I use homie-python on a raspberry. My script and config is here: https://gist.github.com/sja/0ce0cc5fa4dc45483c29c79a08004269

sja · 2017-06-14T10:41:56Z

Ping! Any idea where I'm wrong?

bodiroga · 2017-06-14T11:05:18Z

Hi @sja!

The problem you are seeing is that the plugin developed by kwave is only compatible with the second version of the Homie specification (Homie 2.0: https://github.com/marvinroger/homie), whereas the python-homie library hasn't been updated yet and it's still using the 1.0 convention (https://github.com/jalmeroth/homie-python/projects).

Did you have a look at the log files to see what's not working correctly?

Good luck and many thanks to @Kwave for developing the plugin, looking forward to seeing it officially merged.

Best regards,

Aitor

sja · 2017-06-17T21:10:38Z

@bodiroga Thanks for your reply. I'm confused: The title of jalmeroth's repo is 'A Python-implementation of the homie v2 convention.' You say, that is wrong?

bodiroga · 2017-06-18T10:36:32Z

Hi again @sja!

You are right about the repo's title, so I'm also confused about the Homie implementation used in the project. I thought that @jalmeroth was using the first implementation after seeing this issue and this project:

What about the openhab log files? Anything there?

jalmeroth · 2017-06-18T14:44:43Z

Hello,

@bodiroga thanks for mentioning me. You're right it's a bit confusing as there's only one repo title and it was already updated. Actually, the master branch adheres the Homie v1 convention whereas the dev branch has the v2 already. The dev branch will become the master once homie-esp8266 is out of beta. As I don't expect to much changes, it is probably safe to use the dev branch already. If you find any bugs or have a feature request, please feel free to open an issue.

I hope this helps.

sja · 2017-06-19T21:10:36Z

Hi @bodiroga and @jalmeroth ,

thanks for your reply. I just saw it too late. I already submitted a PR for my v2 approach ... It was a good thing to get warm with python. :-/

I will have a look at the dev branch.

martinvw

I finally found the time to do the rest of the review, thanks again for all your work already.

martinvw · 2017-06-07T06:19:52Z

addons/binding/org.openhab.binding.homie/build.properties

+               OSGI-INF/,\
+               ESH-INF/,\
+               lib/org.eclipse.paho.client.mqttv3-1.1.0.jar,\
+               lib/commons-lang3-3.5.jar


Can you please rewrite your code to depend on (I known how old it is) version 2.6 which is provided by the framework.

martinvw · 2017-06-07T06:20:03Z

addons/binding/org.openhab.binding.homie/build.properties

+               .,\
+               OSGI-INF/,\
+               ESH-INF/,\
+               lib/org.eclipse.paho.client.mqttv3-1.1.0.jar,\


As mentioned before:

Please use the mqtt io.transport bundle from https://github.com/eclipse/smarthome/tree/master/bundles/io/org.eclipse.smarthome.io.transport.mqtt

You might also be interested in eclipse-archived/smarthome#3695

@martinvw

Hello, do you have an example of how to use this service? I'm having troubles creating a binding that relies on this service and i can't seem to find it used in any other OH2 binding, nor can I find docs on how to use it.
Please see https://www.eclipse.org/forums/index.php/t/1088038/ with my experience

@aisebastian This service is not used in OH2, because there are no Mqtt related bindings ported to OH2. Did you see my response to your question in the eclipse forum? Look at the PRs of the eclipse smarthome repository and you will find some API consumers :)

Hi, Yes, I managed to achieve my tasks, Thanks!

martinvw · 2017-06-28T18:02:23Z

addons/binding/org.openhab.binding.homie/README.md

+
+All nodes that do not use the `ESH:` prefix in their `$type` topic will be made available as plain string items. They will be not writable, no matter if the `:settable` attribute is present or not.
+
+## Manual configuration


Is this paragraph deliberately empty? Can you work on that?

martinvw · 2017-06-28T18:03:54Z

....openhab.binding.homie/src/main/java/org/openhab/binding/homie/HomieChannelTypeProvider.java

+import org.eclipse.smarthome.core.thing.type.ChannelTypeProvider;
+import org.eclipse.smarthome.core.thing.type.ChannelTypeUID;
+
+public interface HomieChannelTypeProvider extends ChannelTypeProvider {


Please add an author tag and initial contribution and (at least minimal) information about the purpose / goal of this class.

martinvw · 2017-06-28T18:04:21Z

...penhab.binding.homie/src/main/java/org/openhab/binding/homie/handler/HomieDeviceHandler.java

+ */
+public class HomieDeviceHandler extends BaseThingHandler implements IMqttMessageListener {
+
+    private abstract class NodeHandler implements IMqttMessageListener {


Please add authors / docblocks to all classes including inner classes.

martinvw · 2017-07-03T15:23:59Z

.../org/openhab/binding/homie/internal/conventionv200/NodePropertiesListAnnouncementParser.java

+public class NodePropertiesListAnnouncementParser {
+
+    protected final static String MATCHGROUP_PROPERTYNAME_NAME = "propname";
+    protected final static String MATCHGROUP_SETTABLE_NAME = "settable";


What does this mean, can it have a better name?

These are the names of regex pattern match groups. I'll add a comment.

martinvw · 2017-07-03T15:25:32Z

...nding.homie/src/main/java/org/openhab/binding/homie/internal/conventionv200/TopicParser.java

+    protected final static String MATCHGROUP_INTERNAL_SUBPROPERTY_NAME = "intsubproperty";
+    protected final static String MATCHGROUP_PROPERTY_NAME = "property";
+    protected final static String MATCHGROUP_NODEID_NAME = "nodeid";
+    protected final static String MATCHGROUP_DEVICEID_NAME = "deviceid";


imho it should be DEVICE_ID instead can you agree? same holds for NODE_ID

I am aware that this violates the common java constant naming pattern, but for a good reason:
Currently it is clear that the ID is related to the device. If we change it to MATCHGROUP_DEVICE_ID_NAME: Is it now a Device-Id or a Device with an ID-Name?

martinvw · 2017-07-03T15:26:26Z

...nding.homie/src/main/java/org/openhab/binding/homie/internal/conventionv200/TopicParser.java

+    public HomieTopic parse(String topic) throws ParseException {
+        Matcher m = pattern.matcher(topic);
+        if (!m.matches()) {
+            throw new ParseException("Topic '" + topic + "' is does not complie to homie specification 2.0.0", 0);


I think this message can be optimized:

"Topic ... does not comply to homie specification 2.0.0"

martinvw · 2017-07-03T15:27:15Z

addons/binding/org.openhab.binding.homie/src/test/resources/simulateHomieMQTT.js

@@ -0,0 +1,75 @@
+var basetopic="homie/";


Always hard to decide whether this should be part of the repo and in what form, I'm doubting.

This goes into a separate test bundle, Kai mentioned that when I had my tests included in the Yamaha binding PR.

martinvw · 2017-07-03T15:29:23Z

addons/binding/org.openhab.binding.homie/build.properties

+               .,\
+               OSGI-INF/,\
+               ESH-INF/,\
+               lib/org.eclipse.paho.client.mqttv3-1.1.0.jar,\


Can you add an about.html and make sure it is referred to from this file.

Coding guidelines B.2

davidgraeff · 2017-07-24T17:29:03Z

addons/binding/org.openhab.binding.homie/ESH-INF/binding/binding.xml

+			<description>MQTT Broker URL in the format "tcp://myBrokerHost:1883"</description>
+			<default>tcp://broker:1883</default>
+		</parameter>
+


Would be awesome to use the eclipse smarthome io.transport.mqtt bundle and the MqttService instead

davidgraeff · 2017-07-24T17:29:50Z

addons/binding/org.openhab.binding.homie/META-INF/MANIFEST.MF

+Bundle-Vendor: openHAB
+Bundle-Version: 2.1.0.qualifier
+Bundle-RequiredExecutionEnvironment: JavaSE-1.8
+Bundle-ClassPath: .,lib/org.eclipse.paho.client.mqttv3-1.1.0.jar,lib/commons-lang3-3.5.jar


Would be awesome to use the eclipse smarthome io.transport.mqtt bundle and the MqttService instead

davidgraeff · 2017-07-24T17:39:32Z

...g.openhab.binding.homie/src/main/java/org/openhab/binding/homie/internal/MqttConnection.java

+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class MqttConnection {


If you need more functionality in the smarthome io.transport.mqtt bundle and the MqttBrokerConnection, let me know.

davidgraeff · 2017-07-24T17:41:16Z

addons/binding/org.openhab.binding.homie/README.md

@@ -0,0 +1,50 @@
+# Homie Binding
+
+This is the binding for devices that complie with the [Homie MQTT Convention](https://github.com/marvinroger/homie). This binding allows you to integrate all devices, as long as they complie with the specification.


spelling: comply

davidgraeff · 2017-07-24T17:43:22Z

addons/binding/org.openhab.binding.homie/README.md

+
+## Additional convention
+
+If you want openHAB to render your nodes properly, you have to provide the following topics.


Not a good idea. I've seen that you talked to the homie author already, but there is hopefully a way to solve it with the new 2.0 convention instead of adding something on top that only works for OH

Agreed. Check homieiot/convention#12 (comment) for an ongoing discussion and add whatever might be missing

To implement such a binding, it is essential to define additional conventions. There is no way to solve this without specifying additional stuff, or changing the convention itself. The later one is more of a long term process, that's why the binding uses the current convention and defines additional things.

I thought Homie 2.0 is not released yet and still being discussed

That is correct. My feeling is, that Marvin is currently preoccupied with other stuff. However the changes discussed in the issue are more or less settled and @Kwave 's PR goes a long way in making them final. homieiot/convention#27

martinvw · 2017-08-01T18:48:14Z

According to GitHub there are some issues not yet addressed, can you make sure that you covered all of them or respond to the comment and tell me why I might be wrong 🙂

davidgraeff · 2017-08-01T19:02:43Z

I think it would be alright to merge this binding with the internal MqttBrokerConnection solution (because it works) and remove the bundled jars in a follow up PR and before OH2.2 is released. A contributing binding developer cannot be responsible to adapt a PR all the time when the framework changes (like this time with the Mqtt transport).

martinvw · 2017-08-27T05:57:49Z

I think it would be alright to merge this binding with the internal MqttBrokerConnection solution (because it works) and remove the bundled jars in a follow up PR and before OH2.2 is released. A contributing binding developer cannot be responsible to adapt a PR all the time when the framework changes (like this time with the Mqtt transport).

@kaikreuzer wdyt?

kaikreuzer · 2017-08-28T07:29:33Z

Afaics, the way the binding is to be configured will change when it starts using the ESH MQTT infrastructure. So imho it does not make much sense to introduce it now and have a breaking change just a few weeks after.
Note that the framework is still in an 0.x phase, which means that binding contributors must consider helping to enhance the framework for use cases that they need, rather than working around its limitations - and having MQTT support on transport layer is imho such a case. @davidgraeff did great efforts for MQTT in this respect and I think we are pretty close to having this merged and available soon. The Homie binding is a perfect candidate to validate and test this new infrastructure.

martinvw · 2017-09-22T12:41:37Z

I have no idea how busy @davidgraeff is but maybe you can collaborate on this with @Kwave it would be great to have this as a first binding based on the MQTT infrastructure.

davidgraeff · 2017-09-23T04:38:26Z

Sure, but there is one MQTT PR that needs to be merged first.

jmvaz · 2017-12-18T16:58:55Z

any news?

davidgraeff · 2017-12-18T17:11:54Z

@Kwave disappeared. Someone needs to take over this PR I guess

sebastiankutschbach · 2017-12-18T18:19:35Z

I have some homie nodes running in my home automation. As the mapping of all topics is very annoying, it would be great to have this binding running on openhab. I want to help but I'm not really sure what is the current state. Can someone please give a short summary, what is missing? What is the state of the referenced Mqtt pr?

ThomDietrich · 2018-01-10T18:31:36Z

@kaikreuzer in retrospect I believe it was a mistake to delay this binding in August. Potential breaking changes in a Binding are imho better than not having it to begin with. Besides, the Homie ought to change as the Homie is still evolving...
I just wanted to state this once because it bugs me for a while now.

davidgraeff · 2018-01-17T00:18:59Z

@ThomDietrich Can you or someone else help here? If the homie related classes are separated from this PR, I would create a new PR, starting fresh with a new version of an addon, where I integrate those classes. But I don't have time to do everything here unfortunately.

ThomDietrich · 2018-01-17T11:56:28Z

@davidgraeff imho if you want to help it would be best to continue with the new MQTT Binding (and the systems around it). After that I'd hope it's possible to introduce two-three MQTT conventions, either as individual bindings or right into the MQTT binding. I wonder if the latter would be cleaner and easier to maintain. That is totally up to the developer, hopefully you ;)

I am not a Binding developer myself and have only little experience in the area. Besides that I apreoccupied with my thesis the next couple of months and will not be able to help :-/

kaikreuzer · 2018-01-18T14:41:14Z

@davidgraeff I agree with @ThomDietrich: The best way to drive this forward is to get the ESH MQTT PRs merged. Afaik, there shouldn't be any blocking issues on them anymore, right?

martinvw · 2018-05-29T08:59:11Z

@davidgraeff I agree with @ThomDietrich: The best way to drive this forward is to get the ESH MQTT PRs merged. Afaik, there shouldn't be any blocking issues on them anymore, right?

Are all these merged by now? Is there anything we can or should do to unblock this PR?

bodiroga · 2018-05-29T09:06:39Z

Hi @martinvw!

@davidgraeff also has a PR to support Homie 3.0 in ESH (eclipse-archived/smarthome#5450), so IMO this PR can be closed 😉

Many thanks for your work!

martinvw · 2018-05-29T09:12:09Z

That sounds awesome, thanks for the heads-up and @gorootde thanks for your great effort.

…enhab#1741) Signed-off-by: Flole <[email protected]>

Michael Kolb added 2 commits January 21, 2017 02:17

Initial Contribution of Homie Binding

85c5b29

Added binding to binding pom.xml

1f2c694

gorootde changed the title ~~Bindings/homie~~ Initial contribution of Homie Binding Jan 21, 2017

kaikreuzer added the new binding If someone has started to work on a binding. For a new binding PR. label Jan 23, 2017

kubawolanin reviewed Jan 30, 2017

View reviewed changes

MHerbst reviewed Jan 30, 2017

View reviewed changes

ThomDietrich mentioned this pull request Feb 4, 2017

Openhab2 binding - Anyone already working on one? homieiot/convention#10

Closed

martinvw closed this May 1, 2017

martinvw reopened this May 1, 2017

Corrected PR review issues. Added a second simulation.

3f3f55c

Signed-off-by: Michael Kolb <[email protected]>

martinvw reviewed May 24, 2017

View reviewed changes

Michael Kolb added 2 commits May 24, 2017 22:57

Merge remote-tracking branch 'upstream/master' into bindings/homie

94e7c97

Corrected even more PR review issues.

0e7623f

Signed-off-by: Michael Kolb <[email protected]>

martinvw requested changes Jul 3, 2017

View reviewed changes

martinvw added the awaiting feedback label Jul 4, 2017

davidgraeff requested changes Jul 31, 2017

View reviewed changes

Michael Kolb added 2 commits July 31, 2017 15:47

Fixed pull request issues

b83ed6e

Fixed pull request issues

9783bce

martinvw removed the awaiting feedback label Jul 31, 2017

martinvw added the awaiting feedback label Sep 22, 2017

martinvw closed this May 29, 2018

markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Aug 12, 2023

Document new "System reached start level XX"-trigger in DSL-Rules (op…

e0daaa2

…enhab#1741) Signed-off-by: Flole <[email protected]>


		If you want openHAB to render your nodes properly, you have to provide the following topics.

		\| Property \| Required \| Message Format \| Description \| Example (Setable heater temperature) \|


		All nodes that do not use the `ESH:` prefix in their `$type` topic will be made available as plain string items. They will be not writable, no matter if the `:settable` attribute is present or not.

		## Manual configuration

		@@ -0,0 +1,50 @@
		# Homie Binding

		This is the binding for devices that complie with the [Homie MQTT Convention](https://github.com/marvinroger/homie). This binding allows you to integrate all devices, as long as they complie with the specification.


		## Additional convention

		If you want openHAB to render your nodes properly, you have to provide the following topics.

Initial contribution of Homie Binding #1741

Initial contribution of Homie Binding #1741

Conversation

gorootde commented Jan 21, 2017

ThomDietrich commented Jan 25, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MHerbst Jan 30, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jmvaz commented Feb 15, 2017

bodiroga commented Feb 15, 2017 • edited Loading

RomeuCarvalhoPT commented Apr 7, 2017

martinvw commented May 1, 2017

cribskip commented May 9, 2017

martinvw commented May 9, 2017

martinvw commented May 9, 2017

martinvw left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sja commented May 27, 2017

sja commented Jun 14, 2017

bodiroga commented Jun 14, 2017

sja commented Jun 17, 2017

bodiroga commented Jun 18, 2017

jalmeroth commented Jun 18, 2017

sja commented Jun 19, 2017

martinvw left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aisebastian Aug 19, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aisebastian Aug 21, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

martinvw Jul 3, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MHerbst Jan 30, 2017 •

edited

Loading

bodiroga commented Feb 15, 2017 •

edited

Loading

aisebastian Aug 19, 2017 •

edited

Loading

aisebastian Aug 21, 2017 •

edited

Loading

martinvw Jul 3, 2017 •

edited

Loading

martinvw commented Sep 22, 2017 •

edited

Loading

sebastiankutschbach commented Dec 18, 2017 •

edited

Loading

ThomDietrich commented Jan 10, 2018 •

edited

Loading

ThomDietrich commented Jan 17, 2018 •

edited

Loading