Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uvmt_cv32e40p_tb_ifs.sv needs to be refactorted #2386

Open
MikeOpenHWGroup opened this issue Mar 14, 2024 · 2 comments
Open

uvmt_cv32e40p_tb_ifs.sv needs to be refactorted #2386

MikeOpenHWGroup opened this issue Mar 14, 2024 · 2 comments
Labels
cv32e40p good first issue Good for newcomers improvement Issues to highlight long-term improvements in core-v-verif

Comments

@MikeOpenHWGroup
Copy link
Member

As mentioned in pull-request #2385, cv32e40p/tb/uvmt/uvmt_cv32e40p_tb_ifs.sv (on the cv32e40p/dev branch) has become very large, containing eight SV-interfaces and several of these interfaces support complex logic. I think it is time to consider refactoring this file into two or more files. Perhaps the interfaces used for coverage could be moved into a separate file.

@MikeOpenHWGroup MikeOpenHWGroup added good first issue Good for newcomers improvement Issues to highlight long-term improvements in core-v-verif cv32e40p labels Mar 14, 2024
@XavierAubert
Copy link

Sorry, I totally forgot this about this issue...
Is it too late considering how close project closure is, or should I take 10-20min to make the update you requested Mike?
Since it's only moving interface definitions in another files, in my opinion, there is a low risk of breaking anything and/or changing any coverage metric...

@MikeOpenHWGroup
Copy link
Member Author

Hi @XavierAubert, given that we are very close to generating a release of CV32E40P, I recommend that we do not do this until after the release. We can waive this issue for the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cv32e40p good first issue Good for newcomers improvement Issues to highlight long-term improvements in core-v-verif
Projects
None yet
Development

No branches or pull requests

2 participants