This repository has been archived by the owner on Jul 24, 2023. It is now read-only.
Issue #125 - Addressing missing server url in check_signature method #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe the error in the failed check is related to the installing rubinius-3 and not from the coding change. |
utkarsh2102
reviewed
Jan 14, 2021
There was a problem hiding this comment.
This looks good, thanks for the PR!
@tobiashm, could you take a final look and merge and release?
Comment on lines
+211
to
+212
| # This fix corrects issue #125 - Unable to complete OpenID login | ||
| # with ruby-openid 2.9.0/2.9.1 |
There was a problem hiding this comment.
Probably we can ✂️ this out from here?
There was a problem hiding this comment.
That is fine to remove those two comment lines during the merge.
|
This repo is being archived. Closing PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The verify_discovery_results method call was moved after the check_signature method call to address a security vulnerability (issue #121). Apparently, the check_signature method relied on the endpoint instance variable being defined by the verify_discovery_results method. As a result, the check_signature method always fails because the server_url is nil.
This fix initializes the endpoint variable within the check_signature method and populates it with the server url passed by the OPENID2 client.
Note: I followed the link for instructions on contributing, but I could not find any instructions on the target site. So I used what the other contributors did as a guide.