Fixing tests #86
Fixing tests #86
Conversation
From Ruby 2.2 the default `URI.parse` method uses a new RFC 3986 compatible parser, which will parse most of the “invalid” URLs in the trustroot test.
Now you can run all test files individually, because each now correctly requires everything it needs.
An explicit return inside a Proc can return from the current scope. This fixes an issue with the test exiting before all tests are run.
This test became obsolete after #61 was merged, since the code now uses Ruby's build in `String#start_with?` rather than a custom implementation.
|
@dennisreimann I would appreciate if you can look at these pull requests and merge them, given that the tests passes and this is a roadblock for upgrading ruby-openid to Ruby 2.2 @tobiashm could you perhaps provide a new pull-request with all PR changes from #84, #85 and #86 |
|
@dennisreimann thanks! Are you also releasing a new version? |
|
Yes, I'll also add the travis builds for the recent ruby versions and will release a new version as soon as possible. |
|
👍 On Thu, Mar 5, 2015 at 1:35 PM, Dennis Reimann [email protected]
Jesper Rønn-Jensen Blog http://justaddwater.dk/ |
|
Since everything is passing with the most recent ruby versions too, I just pushed out v2.7.0 - enjoy! |
|
My pleasure :) thanks for your time and effort maintaining :) On Thu, Mar 5, 2015 at 1:52 PM, Dennis Reimann [email protected]
Jesper Rønn-Jensen Blog http://justaddwater.dk/ |
|
@jesperronn @tobiashm right now I'm not using the gem anymore myself and I'm doing less ruby work in general. That's why this gem lacks attention and to me it seems the other maintainers do not follow what's going on here. I'd like to pass this on to someone who can maintain the gem better than I'm doing it right now - anyone of you being interested in taking care of it? |
|
@dennisreimann well, we're depending on the gem for several of our applications, so we have some interest in keeping it maintained. I would be ok with taking care of it. |
|
Thanks @tobiashm for these test suite fixups! |
Update ruby-ruby-openid package to version 2.9.2. ## 2.9.2 * Perform all checks before verifying endpoints. [#126](openid/ruby-openid#126) ## 2.9.1 * Updated CHANGELOG.md ## 2.9.0 * Remove deprecated `autorequire` from gemspec. [#123](openid/ruby-openid#123) * Rescue from `Yadis::XRI::XRIHTTPError` on discovery. [#106](openid/ruby-openid#106) * Avoid SSRF for claimed_id request. [#121](openid/ruby-openid#121) * Updated documentation. [#115](openid/ruby-openid#115), [#116](openid/ruby-openid#116), [#117](openid/ruby-openid#117), [#118](openid/ruby-openid#118) * Reduce warnings output in test runs. [#119](openid/ruby-openid#119) * Drop deprecated option from gemspec. [#120](openid/ruby-openid#120) * Remove circular require. [#113](openid/ruby-openid#113) * Updated Travis CI config with Ruby 2.6 [#114](openid/ruby-openid#114) * Simplify Bundler require; remove need for extra `:require`. [#112](openid/ruby-openid#112) ## 2.8.0 * Fix `admin/mkassoc` script. See openid/ruby-openid#103 * Allow specifying timeout for `OpenID::StandardFetcher` in environment variables. See openid/ruby-openid#109 * Fixed some documentation. See openid/ruby-openid#111 * Fixed example server. See openid/ruby-openid#91 * Fixed tests. See openid/ruby-openid#86 * Misc. changes to the CI setup. See - openid/ruby-openid#110 - openid/ruby-openid#108 - openid/ruby-openid#107
This fixes an issue with some tests exiting early because of an explicit
returnstatement in aProc.At the same time, some require statements were added to test files, to make it possible to run them individually.