Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: WordTokenizers.jl: Basic tools for tokenizing natural language in Julia #1939

Closed
whedon opened this issue Dec 8, 2019 · 30 comments

Comments

@whedon
Copy link

whedon commented Dec 8, 2019

Submitting author: @oxinabox (Lyndon White)
Repository: https://github.com/JuliaText/WordTokenizers.jl/
Version: v0.5.3
Editor: @will-rowe
Reviewers: @leios, @ninjin

Author instructions

Thanks for submitting your paper to JOSS @oxinabox. Currently, there isn't an JOSS editor assigned to your paper.

@oxinabox if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Dec 8, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

@whedon
Copy link
Author

whedon commented Dec 8, 2019

Attempting to check references...

@whedon
Copy link
Author

whedon commented Dec 8, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Dec 8, 2019


OK DOIs

- None

MISSING DOIs

- https://doi.org/10.1137/141000671 may be missing for title: Julia: A Fresh Approach to Numerical Computing
- https://doi.org/10.1609/aaai.v33i01.33016843 may be missing for title: Spell Once, Summon Anywhere: A Two-Level Open-Vocabulary Language Model

INVALID DOIs

- None

@whedon
Copy link
Author

whedon commented Dec 8, 2019

@danielskatz
Copy link

👋 @oxinabox - thanks for your submission!

As you can see above, @whedon thinks some of your bib entries might be missing DOIs (but @whedon is also sometimes wrong)

Please check

There also seem to be some other things in the generated pdf that could be fixed, such as double (())s around some citations, missing spaces before some citations, and some extra "s in one reference

After you make changes, enter a new comment here with @whedon generate pdf to check the result

@danielskatz
Copy link

👋 @will-rowe - would you be willing to edit this submission?

@will-rowe
Copy link

This looks cool - happy to.

@will-rowe
Copy link

@whedon assign @will-rowe as editor

@whedon
Copy link
Author

whedon commented Dec 9, 2019

OK, the editor is @will-rowe

@will-rowe
Copy link

Hi @vchuravy and @ahwillia - would you both be willing to review this submission?

@oxinabox
Copy link
Member

oxinabox commented Dec 9, 2019

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Dec 9, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Dec 9, 2019

@will-rowe
Copy link

Hi @ChrisRackauckas and @leios - would you please be able to review this submission for us?

@leios
Copy link

leios commented Dec 11, 2019

Hey @will-rowe I can do it next week, if that works for everyone

@will-rowe
Copy link

Perfect - thanks a lot @leios. Next week is great. Once we've got a second reviewer, I can move this submission into review.

@ChrisRackauckas
Copy link

Hi, I will not be able to.

@will-rowe
Copy link

No worries @ChrisRackauckas - thanks for letting me know quickly

@will-rowe
Copy link

Hi @ninjin - would you please be able to review this submission for us?

@will-rowe
Copy link

Hi @ionlights - would you please be able to review this submission?

@oxinabox
Copy link
Member

@ninjin would be an awesome reviewer (being a NLP researcher and a Julia dev).
But I know is incredibly busy right now.

@ghost
Copy link

ghost commented Dec 13, 2019

I can do it, as long as I get two weeks to do so. That way I can clear the pre-Christmas hell first.

@will-rowe
Copy link

That's perfect - thanks @ninjin.

We're ready to move this over to review then. As it's Christmas etc., there's no rush on the reviews until the New Year as I know we're all busy this time of year.

@will-rowe
Copy link

@whedon assign @leios as reviewer

@whedon whedon assigned leios and will-rowe and unassigned will-rowe Dec 13, 2019
@whedon
Copy link
Author

whedon commented Dec 13, 2019

OK, the reviewer is @leios

@will-rowe
Copy link

@whedon add @ninjin as reviewer

@whedon whedon assigned leios and unassigned leios and will-rowe Dec 13, 2019
@whedon
Copy link
Author

whedon commented Dec 13, 2019

OK, @ninjin is now a reviewer

@whedon whedon assigned ghost and will-rowe Dec 13, 2019
@will-rowe
Copy link

@whedon start review

@whedon
Copy link
Author

whedon commented Dec 13, 2019

OK, I've started the review over in #1956. Feel free to close this issue now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants