-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: Annotation Sniffer: A tool to Extract Code Annotations Metrics #1960
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @arcuri82, @danieledipompeo it looks like you're currently assigned to review this paper 🎉. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
|
|
hi,
|
Hello @arcuri82 , thank you very much for your comments and considerations. I will begin working on them.
|
Hello @arcuri82 . Once again, thank you for your comments and considerations. I have taken all off them in consideration and generated a new version of the tool (2.1.0). Please, feel free to make new comments and suggestions. Following is my response to your comments.
Regarding the
Regarding the authorship I have explained in another comment. Best Regards! |
@phillima: thanks. it looks like you have addressed all concerns I had. |
@danieledipompeo Do you have any review feedback for us? We have received feedback from @arcuri82, which has been addressed by @phillima. Please follow up if you have any other feedback. |
Sorry, I'm late, but I had some problems at work that prevented me from finishing the review. I can complete the review by this week. Is it too late? @gkthiruvathukal let me know if you can give me more time. |
Sorry again for my late review. General checks
Functionality
Yes, it has.
Documentation
It is quite clear the point of this paper/tool. It extracts metrics from java code. Perhaps, a more in-depth description of competitors should be provided.
The authors use maven to build the project. A needed dependency is missed. After adding it to the pom.xml, the project has been built.
No example is given.
I cannot find any code documentation.
The source code is equipped with unit tests.
Software paper
Yes, the paper provides itself enough information to understand the presented functionality.
The presented tool extracts class metrics by exploiting the Eclipse JDT plugin. In the XML example file output (I suppose this file it has been generated through the tool) information about class metrics are listed.
No information is given about this statement. A more in-depth comparison should be provided.
The paper is short, but it is to follow.
It is quite extensive. |
Hello @danieledipompeo , thank you very much for your comments. I will work on them. I would like to point out some things.
As soon as I work on the other comments I will generate a new release. |
My comments below.
Yes, if you use the JDK 11 you have to add the dependency, while if you use the JDK 8 you don't need because the JDK 8 is "self-contained".
Yes, if you add a running example or a simple one, it will be useful.
Ok, it's fine with me. It was just a suggestion. If you consider that your tool is the first one in this area you cannot find related work.
Kind Regards |
Hi @danieledipompeo, once again, thank you for your comments. I have generated a new version of the ASniffer tool (2.2.0) that aims to address your review. Please, feel free to make new comments and suggestions.
Kind Regards! |
👋 @gkthiruvathukal - can you let me know where things are on this submission? |
@danielskatz I believe the next step is for the reviewers to take another look. @phillima followed up with a new version that addresses previous feedback. @arcuri82, @danieledipompeo: Can you please take another look and see whether your comments/concerns have been addressed? |
Hi, |
Thanks @arcuri82. I'll await word from @danieledipompeo and move to the next steps. |
Hi guys, I missed github notification... Which is the new deadline? In this period I'm busy. |
Hi @arcuri82. I am glad I have addressed your concerns! Thank you |
@danieledipompeo We don't have a specific deadline. We're all about ending up with a high-quality submission, and that sometimes takes time. So we'll wait for your additional input, if you have any. Once you and @arcuri82 signal to me that all of your issues have been addressed by @phillima, I will be happy to proceed with the next steps. |
@danieledipompeo Just checking whether your issues have been addressed by @phillima. I think almost all of your and @arcuri82 issues have been addressed. I'd like to move toward acceptance. |
Hi guys, I've checked the new release and it seems ready to be accepted. Thanks for all, and sorry for my delay. Cheers Daniele |
Ok, I am ready to proceed toward acceptance. @phillima here is a final checklist for you. Please do the following:
|
Hello @gkthiruvathukal. I have performed the steps as requested. Could you please verify that I have done it correctly? Thank you very much!
Version tag: 2.2.1
Zenodo DOI: 10.5281/zenodo.3701910 |
Dear authors and reviewers We wanted to notify you that in light of the current COVID-19 pandemic, JOSS has decided to suspend submission of new manuscripts and to handle existing manuscripts (such as this one) on a "best efforts basis". We understand that you may need to attend to more pressing issues than completing a review or updating a repository in response to a review. If this is the case, a quick note indicating that you need to put a "pause" on your involvement with a review would be appreciated but is not required. Thanks in advance for your understanding. Arfon Smith, Editor in Chief, on behalf of the JOSS editorial team. |
Hi @gkthiruvathukal! Hopefully everything is under control! Just to let you know that in case you need me to perform any other actions regarding this submission, I am available. Thank you |
@phillima - I'm not sure about @gkthiruvathukal's availability so I'll take over from here. |
@whedon set 10.5281/zenodo.3701910 as archive |
OK. 10.5281/zenodo.3701910 is the archive. |
@whedon generate pdf |
@whedon accept |
|
|
👋 @openjournals/joss-eics, this paper is ready to be accepted and published. Check final proof 👉 openjournals/joss-papers#1382 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#1382, then you can now move forward with accepting the submission by compiling again with the flag
|
@phillima - could you please merge this PR that fixes your DOIs? metaisbeta/asniffer#1 |
@arfon Done! |
@whedon check references |
|
@whedon accept deposit=true |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? notify your editorial technical team... |
@arcuri82, @danieledipompeo - many thanks for your reviews here and to @gkthiruvathukal for editing this submission ✨ @phillima - your paper is now accepted into JOSS ⚡🚀💥 |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
@arcuri82 @danieledipompeo @gkthiruvathukal @arfon . Thank you all! |
Submitting author: @phillima (Phyllipe Lima)
Repository: https://github.com/phillima/asniffer/
Version: v2.0.0
Editor: @gkthiruvathukal
Reviewer: @arcuri82, @danieledipompeo
Archive: 10.5281/zenodo.3701910
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@arcuri82 & @danieledipompeo, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @gkthiruvathukal know.
✨ Please try and complete your review in the next two weeks ✨
Review checklist for @arcuri82
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @danieledipompeo
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
The text was updated successfully, but these errors were encountered: