Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: BasicTools: a numerical simulation toolbox #5134

Closed
editorialbot opened this issue Feb 7, 2023 · 33 comments
Closed

[PRE REVIEW]: BasicTools: a numerical simulation toolbox #5134

editorialbot opened this issue Feb 7, 2023 · 33 comments
Assignees
Labels
Batchfile C++ pre-review Python Track: 7 (CSISM) Computer science, Information Science, and Mathematics

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Feb 7, 2023

Submitting author: @fbordeu (Felipe Bordeu)
Repository: https://gitlab.com/drti/basic-tools
Branch with paper.md (empty if default branch):
Version: 1.9.0
Editor: @diehlpk
Reviewers: @hvonwah, @sthavishtha
Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/69864cb5a80d1722f37e29b9335dc441"><img src="https://joss.theoj.org/papers/69864cb5a80d1722f37e29b9335dc441/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/69864cb5a80d1722f37e29b9335dc441/status.svg)](https://joss.theoj.org/papers/69864cb5a80d1722f37e29b9335dc441)

Author instructions

Thanks for submitting your paper to JOSS @fbordeu. Currently, there isn't a JOSS editor assigned to your paper.

@fbordeu if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 7 (CSISM) Computer science, Information Science, and Mathematics labels Feb 7, 2023
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.61 s (427.8 files/s, 106490.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                         172           9869           7759          32854
SVG                              4              3              3           5547
YAML                             8             69             79           1690
C++                             11            191            153           1186
Cython                          13            333            109           1183
C/C++ Header                    19            249            144           1100
reStructuredText                17            285            461            361
Markdown                         4            147              0            353
XML                              4             11              0            159
TeX                              1             12              0            110
JSON                             1              0              0             37
DOS Batch                        2              2              0              6
Bourne Shell                     2              0              0              4
INI                              1              0              0              3
-------------------------------------------------------------------------------
SUM:                           259          11171           8708          44593
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 1709

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@danielskatz
Copy link

Note: This is a resubmission of #4273

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.21105/joss.01450 is OK

MISSING DOIs

- 10.1186/s40323-020-00153-6 may be a valid DOI for title: Model order reduction assisted by deep neural networks (ROM-net)
- 10.3390/mca26010017 may be a valid DOI for title: Data Augmentation and Feature Selection for Automatic Model Recommendation in Computational Physics
- 10.1051/meca/2022001 may be a valid DOI for title: Uncertainty quantification for industrial numerical simulation using dictionaries of reduced order models
- 10.1515/jnum-2012-0013 may be a valid DOI for title: New development in freefem++

INVALID DOIs

- None

@danielskatz
Copy link

@fbordeu - thanks for your submission to JOSS. I'll look for an editor next.

While I do so, you could work on the possibly missing DOIs that editorialbot suggests, but note that some may be incorrect. Please feel free to make changes to your .bib file, then use the command @editorialbot check references to check again, and the command @editorialbot generate pdf when the references are right to make a new PDF. editorialbot commands need to be the first entry in a new comment.

@danielskatz
Copy link

I've also suggested a few minor changes as PRs in your repo

@danielskatz
Copy link

👋 @diehlpk - would you be able to edit this submission?

@danielskatz
Copy link

@editorialbot invite @diehlpk as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@diehlpk
Copy link
Member

diehlpk commented Feb 7, 2023

@editorialbot add @diehlpk as reviewer

@editorialbot
Copy link
Collaborator Author

Can't add reviewers: There is no editor assigned yet

@diehlpk
Copy link
Member

diehlpk commented Feb 7, 2023

@editorialbot add @diehlpk as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @diehlpk is now the editor

@diehlpk
Copy link
Member

diehlpk commented Feb 7, 2023

Hi @fbordeu could you please recommend some reviewers?

@fbordeu
Copy link

fbordeu commented Feb 7, 2023

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1186/s40323-020-00153-6 is OK
- 10.3390/mca26010017 is OK
- 10.1051/meca/2022001 is OK
- 10.3390/fluids6100343 is OK
- 10.1007/978-3-030-92540-6_2 is OK
- 10.1515/jnum-2012-0013 is OK
- 10.11588/ans.2015.100.20553 is OK
- 10.21105/joss.01450 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@fbordeu
Copy link

fbordeu commented Feb 7, 2023

@editorialbot generate pdf

@fbordeu
Copy link

fbordeu commented Feb 8, 2023

@editorialbot commands

@editorialbot
Copy link
Collaborator Author

Hello @fbordeu, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Check the references of the paper for missing DOIs
@editorialbot check references

# Perform checks on the repository
@editorialbot check repository

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set joss-paper as branch

# Generates the pdf paper
@editorialbot generate pdf

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Get a link to the complete list of reviewers
@editorialbot list reviewers

@fbordeu
Copy link

fbordeu commented Feb 8, 2023

@diehlpk

I found 2 reviewers in the same area on my contribution :
@hvonwah
@sthavishtha

@diehlpk
Copy link
Member

diehlpk commented Feb 9, 2023

Hi @hvonwah do you have time to review that paper?

@diehlpk
Copy link
Member

diehlpk commented Feb 9, 2023

Hi @sthavishtha do you have time to review this paper?

@hvonwah
Copy link

hvonwah commented Feb 9, 2023

I'd be happy to, but I will not be available next week. After that I have time.

@sthavishtha
Copy link

yes, I can review this paper.

@diehlpk
Copy link
Member

diehlpk commented Feb 9, 2023

@editorialbot add @hvonwah as reviewer

@editorialbot
Copy link
Collaborator Author

@hvonwah added to the reviewers list!

@diehlpk
Copy link
Member

diehlpk commented Feb 9, 2023

@editorialbot add @sthavishtha as reviewer

@editorialbot
Copy link
Collaborator Author

@sthavishtha added to the reviewers list!

@diehlpk
Copy link
Member

diehlpk commented Feb 9, 2023

@hvonwah and @sthavishtha thanks for agreeing to review, I will start the review soon.

@diehlpk
Copy link
Member

diehlpk commented Feb 9, 2023

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #5142.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Batchfile C++ pre-review Python Track: 7 (CSISM) Computer science, Information Science, and Mathematics
Projects
None yet
Development

No branches or pull requests

6 participants