[REVIEW]: ZodiPy: A Python package for zodiacal light simulations #6648

editorialbot · 2024-04-20T08:05:14Z

Submitting author: @MetinSa (Metin San)
Repository: https://github.com/Cosmoglobe/zodipy
Branch with paper.md (empty if default branch):
Version: v.0.9.2
Editor: @dfm
Reviewers: @dfm
Archive: 10.5281/zenodo.10999612

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/647f3b1f0f8bb215c0a6a8be9f0870ca"><img src="https://joss.theoj.org/papers/647f3b1f0f8bb215c0a6a8be9f0870ca/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/647f3b1f0f8bb215c0a6a8be9f0870ca/status.svg)](https://joss.theoj.org/papers/647f3b1f0f8bb215c0a6a8be9f0870ca)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@dfm, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @dfm know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

@dfm, please create your checklist typing: @editorialbot generate my checklist

The text was updated successfully, but these errors were encountered:

editorialbot · 2024-04-20T08:05:17Z

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

dfm · 2024-04-20T08:05:37Z

Cross-linking with pyOpenSci submission here: pyOpenSci/software-submission#161

editorialbot · 2024-04-20T08:05:37Z

Software report:

github.com/AlDanial/cloc v 1.90  T=0.04 s (1440.6 files/s, 131776.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          36            631            362           3039
Markdown                        11            146              0            455
TeX                              2             14              0            236
YAML                             6             19              9            163
TOML                             1              8              1            112
JavaScript                       1              2              0             17
-------------------------------------------------------------------------------
SUM:                            57            820            372           4022
-------------------------------------------------------------------------------

Commit count by author:

   412	Metin San
     3	hermda02
     2	dependabot[bot]
     1	P. L. Lim

editorialbot · 2024-04-20T08:05:42Z

Paper file info:

📄 Wordcount for paper.md is 617

✅ The paper includes a Statement of need section

editorialbot · 2024-04-20T08:05:43Z

License info:

🟡 License found: GNU General Public License v3.0 (Check here for OSI approval)

editorialbot · 2024-04-20T08:05:54Z

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.48550/arXiv.2306.17219 is OK
- 10.48550/arXiv.2306.17226 is OK
- 10.1051/0004-6361/201322068 is OK
- 10.1109/TPAMI.2023.3299526 is OK
- 10.1093/pasj/psae016 is OK
- 10.1086/306380 is OK
- 10.1109/MCSE.2011.37 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.1051/0004-6361/201321562 is OK
- 10.1051/0004-6361/202244133 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.1186/s40623-023-01856-x is OK
- 10.21105/joss.01298 is OK
- 10.1086/427976 is OK

MISSING DOIs

- No DOI given, and none found for title: PyEphem: Astronomical Ephemeris for Python

INVALID DOIs

- None

editorialbot · 2024-04-20T08:06:45Z

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

dfm · 2024-04-20T09:03:22Z

@editorialbot generate pdf

editorialbot · 2024-04-20T09:04:36Z

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

dfm · 2024-04-20T09:13:29Z

@editorialbot set 10.5281/zenodo.10999612 as archive

editorialbot · 2024-04-20T09:13:31Z

Done! archive is now 10.5281/zenodo.10999612

dfm · 2024-04-20T09:13:55Z

@editorialbot recomment-accept

editorialbot · 2024-04-20T09:13:56Z

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

dfm · 2024-04-20T09:14:04Z

@editorialbot recommend-accept

editorialbot · 2024-04-20T09:14:06Z

Attempting dry run of processing paper acceptance...

editorialbot · 2024-04-20T09:14:23Z

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.48550/arXiv.2306.17219 is OK
- 10.48550/arXiv.2306.17226 is OK
- 10.1051/0004-6361/201322068 is OK
- 10.1109/TPAMI.2023.3299526 is OK
- 10.1093/pasj/psae016 is OK
- 10.1086/306380 is OK
- 10.1109/MCSE.2011.37 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.1051/0004-6361/201321562 is OK
- 10.1051/0004-6361/202244133 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.1186/s40623-023-01856-x is OK
- 10.21105/joss.01298 is OK
- 10.1086/427976 is OK

MISSING DOIs

- No DOI given, and none found for title: PyEphem: Astronomical Ephemeris for Python

INVALID DOIs

- None

editorialbot · 2024-04-20T09:15:43Z

👋 @openjournals/aass-eics, this paper is ready to be accepted and published.

Check final proof 👉📄 Download article

If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5255, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

dfm · 2024-04-20T09:17:07Z

@editorialbot accept

editorialbot · 2024-04-20T09:17:09Z

Doing it live! Attempting automated processing of paper acceptance...

editorialbot · 2024-04-20T09:23:31Z

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

cff-version: "1.2.0"
authors:
- family-names: San
  given-names: Metin
  orcid: "https://orcid.org/0000-0003-4648-8729"
doi: 10.5281/zenodo.10999612
message: If you use this software, please cite our article in the
  Journal of Open Source Software.
preferred-citation:
  authors:
  - family-names: San
    given-names: Metin
    orcid: "https://orcid.org/0000-0003-4648-8729"
  date-published: 2024-04-20
  doi: 10.21105/joss.06648
  issn: 2475-9066
  issue: 96
  journal: Journal of Open Source Software
  publisher:
    name: Open Journals
  start: 6648
  title: "ZodiPy: A Python package for zodiacal light simulations"
  type: article
  url: "https://joss.theoj.org/papers/10.21105/joss.06648"
  volume: 9
title: "ZodiPy: A Python package for zodiacal light simulations"

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot · 2024-04-20T09:23:34Z

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot · 2024-04-20T09:23:35Z

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited 👉 Creating pull request for 10.21105.joss.06648 joss-papers#5256
Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.06648
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

dfm · 2024-04-20T09:36:31Z

@MetinSa – your paper is now accepted and published in JOSS ⚡🚀💥

editorialbot · 2024-04-20T09:36:35Z

🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06648/status.svg)](https://doi.org/10.21105/joss.06648)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06648">
  <img src="https://joss.theoj.org/papers/10.21105/joss.06648/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06648/status.svg
   :target: https://doi.org/10.21105/joss.06648

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

MetinSa · 2024-04-20T10:37:51Z

Thank you for the quick review @dfm! 🎉

editorialbot added pyOpenSci Submissions associated with pyOpenSci Python review TeX Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences labels Apr 20, 2024

editorialbot assigned dfm Apr 20, 2024

editorialbot mentioned this issue Apr 20, 2024

[PRE REVIEW]: ZodiPy: A Python package for zodiacal light simulations #6647

Closed

dfm mentioned this issue Apr 20, 2024

Edits for JOSS review Cosmoglobe/zodipy#24

Merged

editorialbot added the recommend-accept Papers recommended for acceptance in JOSS. label Apr 20, 2024

editorialbot added accepted published Papers published in JOSS labels Apr 20, 2024

dfm closed this as completed Apr 20, 2024

editorialbot mentioned this issue Aug 9, 2024

[PRE REVIEW]: seismolab: A Python package for analyzing space-based observations of variable stars #7095

Closed

editorialbot mentioned this issue Aug 30, 2024

[PRE REVIEW]: AstronomyCalc: A python toolkit for teaching Astronomical Calculations and Data Analysis methods #7160

Closed

editorialbot mentioned this issue Sep 7, 2024

[PRE REVIEW]: Katsu: Integrated polarimetry and polarization simulation #7197

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[REVIEW]: ZodiPy: A Python package for zodiacal light simulations #6648

[REVIEW]: ZodiPy: A Python package for zodiacal light simulations #6648

editorialbot commented Apr 20, 2024 •

edited

Loading

editorialbot commented Apr 20, 2024

dfm commented Apr 20, 2024

editorialbot commented Apr 20, 2024

editorialbot commented Apr 20, 2024

editorialbot commented Apr 20, 2024

editorialbot commented Apr 20, 2024

editorialbot commented Apr 20, 2024

dfm commented Apr 20, 2024

editorialbot commented Apr 20, 2024

dfm commented Apr 20, 2024

editorialbot commented Apr 20, 2024

dfm commented Apr 20, 2024

editorialbot commented Apr 20, 2024

dfm commented Apr 20, 2024

editorialbot commented Apr 20, 2024

editorialbot commented Apr 20, 2024

editorialbot commented Apr 20, 2024

dfm commented Apr 20, 2024

editorialbot commented Apr 20, 2024

editorialbot commented Apr 20, 2024

editorialbot commented Apr 20, 2024

editorialbot commented Apr 20, 2024

dfm commented Apr 20, 2024

editorialbot commented Apr 20, 2024

MetinSa commented Apr 20, 2024

[REVIEW]: ZodiPy: A Python package for zodiacal light simulations #6648

[REVIEW]: ZodiPy: A Python package for zodiacal light simulations #6648

Comments

editorialbot commented Apr 20, 2024 • edited Loading

Status

Reviewer instructions & questions

Checklists

editorialbot commented Apr 20, 2024

dfm commented Apr 20, 2024

editorialbot commented Apr 20, 2024

editorialbot commented Apr 20, 2024

editorialbot commented Apr 20, 2024

editorialbot commented Apr 20, 2024

editorialbot commented Apr 20, 2024

dfm commented Apr 20, 2024

editorialbot commented Apr 20, 2024

dfm commented Apr 20, 2024

editorialbot commented Apr 20, 2024

dfm commented Apr 20, 2024

editorialbot commented Apr 20, 2024

dfm commented Apr 20, 2024

editorialbot commented Apr 20, 2024

editorialbot commented Apr 20, 2024

editorialbot commented Apr 20, 2024

dfm commented Apr 20, 2024

editorialbot commented Apr 20, 2024

editorialbot commented Apr 20, 2024

editorialbot commented Apr 20, 2024

editorialbot commented Apr 20, 2024

dfm commented Apr 20, 2024

editorialbot commented Apr 20, 2024

MetinSa commented Apr 20, 2024

editorialbot commented Apr 20, 2024 •

edited

Loading