[PRE REVIEW]: fortran-src: Fortran static analysis infrastructure

[editorialbot]

Submitting author: @dorchard (Dominic Orchard)
Repository: https://github.com/camfort/fortran-src/
Branch with paper.md (empty if default branch): joss
Version: v0.16.2
Editor: Pending
Reviewers: Pending
Managing EiC: Daniel S. Katz

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/a9a03193454f59722cead5412cac4b33"><img src="https://joss.theoj.org/papers/a9a03193454f59722cead5412cac4b33/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/a9a03193454f59722cead5412cac4b33/status.svg)](https://joss.theoj.org/papers/a9a03193454f59722cead5412cac4b33)

Author instructions

Thanks for submitting your paper to JOSS @dorchard. Currently, there isn't a JOSS editor assigned to your paper.

@dorchard if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands

[editorialbot]

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

[editorialbot]

Software report:

github.com/AlDanial/cloc v 1.90  T=0.08 s (1831.5 files/s, 377060.2 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Haskell                        103           2657           2243          14861
yacc                             5            631              0           4693
Logos                            2            279              2           2258
Markdown                         6            233              0           1141
YAML                             7             71             55            382
TeX                              1             30              0            278
Nix                              3             13             25             95
Fortran 77                      15             12              4             77
Fortran 90                       4              0              0             17
-------------------------------------------------------------------------------
SUM:                           146           3926           2329          23802
-------------------------------------------------------------------------------

Commit count by author:

   380	Matthew Danish
   263	madgen
   260	Ben Orchard
    89	Dominic Orchard
    56	dominic
    47	TravelTissues
    32	Raoul Hidalgo Charman
    29	Mistral Contrastin
    13	Anthony Burzillo
     9	Eric Seidel
     7	mrd
     6	Ben Moon
     6	Bradley Hardy
     6	Jason Xu
     4	Harry Clarke
     3	Vaibhav Yenamandra
     2	Azeem Bande-Ali
     1	Brad Hardy
     1	Konstantin Romanov
     1	Lukasz Kolodziejczyk
     1	Raoul Hidalgo-Charman
     1	dorchard

[editorialbot]

Paper file info:

📄 Wordcount for paper.md is 4487

✅ The paper includes a Statement of need section

[editorialbot]

License info:

🟡 License found: Other (Check here for OSI approval)

[editorialbot]

⚠️ An error happened when generating the pdf. Problem with affiliations for Mistral Contrastin, perhaps the affiliations index need quoting?.

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1145/2541348.2541356 is OK
- 10.1016/j.jocs.2015.04.018 is OK
- 10.1109/MCSE.2016.17 is OK
- 10.1016/j.jocs.2015.04.018 is OK
- 10.1016/j.procs.2014.05.064 is OK
- 10.1145/2717124.2717125 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Proceedings of the 2013 ACM Workshop on Refactorin...
- No DOI given, and none found for title: Guiding user annotations for units-of-measure veri...
- No DOI given, and none found for title: Lightning Talk: Supporting Software Sustainability...
- No DOI given, and none found for title: Proceedings of the International Conference on Com...
- No DOI given, and none found for title: Scrap Your Reprinter: A Datatype Generic Algorithm...
- No DOI given, and none found for title: The Met Office unified model global atmosphere 6.0...
- No DOI given, and none found for title: PlusFORT Manual
- No DOI given, and none found for title: fpt - Tools for Fortran Engineering
- No DOI given, and none found for title: Understand
- No DOI given, and none found for title: Coverity Static Analysis
- No DOI given, and none found for title: Forcheck - Fortran Static Analyzer
- No DOI given, and none found for title: Photran – An Integrated Development Environment an...
- No DOI given, and none found for title: The Glasgow Fortran Source-to-Source Compiler (Ref...
- No DOI given, and none found for title: Incremental units-of-measure verification

❌ MISSING DOIs

- 10.1109/se4science.2019.00013 may be a valid DOI for title: Learning units-of-measure from scientific code
- 10.1145/3133899 may be a valid DOI for title: Verifying spatial properties of array computations
- 10.1145/800025.1198345 may be a valid DOI for title: The history of Fortran I, II, and III
- 10.1007/s11227-021-03839-9 may be a valid DOI for title: Making legacy Fortran code type safe through autom...
- 10.1007/s11227-021-03839-9 may be a valid DOI for title: Making legacy Fortran code type safe through autom...
- 10.1109/se-hpccse.2014.7 may be a valid DOI for title: Climate models: challenges for Fortran development...

❌ INVALID DOIs

- None

[danielskatz]

👋 @dorchard - Thanks for your submission.

1. Note that your paper does not compile. Please follow the example paper and note that you can click on the error above to find out more about it. In addition, you could work on the possibly missing DOIs that editorialbot suggests, but note that some may be incorrect. Please feel free to make changes to your .bib file, then use the command @editorialbot check references to check again, and the command @editorialbot generate pdf after making changes to the .md file or when the references are right to make a new PDF. editorialbot commands need to be the first entry in a new comment.
2. Your paper is about 4.5x longer than the maximum recommended for a JOSS paper (250-1000 words). You will have to substantially cut this before we can start to review it, or perhaps consider if JOSS is the right venue for your work. If you decide to cut it, you can use the command @editorialbot check repository to run a number of checks, including the word count for the paper.

I'm going to mark this as paused for now.

[dorchard]

Thanks @danielskatz - I'll have a look at cutting. Do code snippets count towards the word count?

[danielskatz]

I think they do get counted, which is why the 250-1000 is a rough expectation