Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PodProbeMarker Support http/tcp capacities #1306

Open
zmberg opened this issue Jun 5, 2023 · 1 comment
Open

PodProbeMarker Support http/tcp capacities #1306

zmberg opened this issue Jun 5, 2023 · 1 comment
Assignees

Comments

@zmberg
Copy link
Member

zmberg commented Jun 5, 2023

What would you like to be added:
PodProbeMarker currently only support exec model, so need support tcp/http model, for example:

apiVersion: apps.kruise.io/v1alpha1
kind: PodProbeMarker
metadata:
  name: game-server-probe
  namespace: ns
spec:
  selector:
    matchLabels:
      app: game-server
  probes:
  - name: Idle
    containerName: game-server
    probe:
      tcpSocket:
        port: 80
      httpGet:
        path: /healthz
        port: 80
        scheme: HTTP
      initialDelaySeconds: 30
      periodSeconds: 10
      timeoutSeconds: 5
    markerPolicy:
    ...

Related codes: https://github.com/openkruise/kruise/tree/master/pkg/daemon/podprobe

@furykerry furykerry changed the title [feature request] PodProbeMarker Support http/tcp capacities [GLCC][feature request] PodProbeMarker Support http/tcp capacities Jun 5, 2023
@zmberg zmberg changed the title [GLCC][feature request] PodProbeMarker Support http/tcp capacities [GLCC] PodProbeMarker Support http/tcp capacities Jun 5, 2023
@nitishchauhan0022
Copy link
Contributor

/assign

@zmberg zmberg changed the title [GLCC] PodProbeMarker Support http/tcp capacities PodProbeMarker Support http/tcp capacities Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants