Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenMl connector tightly coupled #3

Open
jaksmid opened this issue Feb 23, 2015 · 0 comments
Open

OpenMl connector tightly coupled #3

jaksmid opened this issue Feb 23, 2015 · 0 comments

Comments

@jaksmid
Copy link
Contributor

jaksmid commented Feb 23, 2015

OpenMlConnector:
relies heavily on the method: HttpConnector.doApiRequest which is static.
This is hard to test and mock.
Imho beter to call some interface, maybe even include some dependency injection.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jaksmid