Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a developer, I would like to be able to read and more easily understand the code for the click/hover popup box on the map #493

Open
2 tasks done
gsehrlich opened this issue Sep 28, 2022 · 0 comments
Labels
component: front-end feature: map status: blocked Progress can't be made until a dependency is resolved status: ready to work on Prioritized and ready for a contributor to move to "In Progress"

Comments

@gsehrlich
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
The click/hover popup box on the map works, but I implemented it hastily and the code is a bit messy. Some refactoring would clear it up. The prototypes at the bottom may also be missing for some variables.

Describe the solution you'd like
Refactor.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Let's make sure we actually want the hover/click interaction before we put too much energy into refactoring it.

Labels

  • Add a status label
    • needs definition
    • needs help
    • ready to work on
    • in progress
    • backlog
  • Add additional labels as needed

For Developers

Affected Components
I think mostly web/src/components/map/menu.js and ./hover.js.

Testing Outline
Currently this functionality is not tested. Some tests would be a good idea...

@gsehrlich gsehrlich added status: ready to work on Prioritized and ready for a contributor to move to "In Progress" status: blocked Progress can't be made until a dependency is resolved component: front-end feature: map labels Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: front-end feature: map status: blocked Progress can't be made until a dependency is resolved status: ready to work on Prioritized and ready for a contributor to move to "In Progress"
Projects
None yet
Development

No branches or pull requests

1 participant