Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two entries for postal code 63263 #3

Closed
rockstaedt opened this issue Dec 15, 2023 · 9 comments
Closed

Two entries for postal code 63263 #3

rockstaedt opened this issue Dec 15, 2023 · 9 comments
Labels
bug Something isn't working

Comments

@rockstaedt
Copy link

rockstaedt commented Dec 15, 2023

Hi there!

Thanks a lot for this cool API. We are using it to prefill city and district names when a postal code is entered.

However, we came across the issue that a request for the postal code 63263 returns two entries:

[
   {
       "postalCode": "63263",
       "name": "Frankfurt am Main",
       "municipality": {
           "key": "06412000",
           "name": "Frankfurt am Main, Stadt",
           "type": "Kreisfreie_Stadt"
       },
       "district": {
           "key": "06412",
           "name": "Frankfurt am Main, Stadt",
           "type": "Kreisfreie_Stadt"
       },
       "federalState": {
           "key": "06",
           "name": "Hessen"
       }
   },
   {
       "postalCode": "63263",
       "name": "Neu-Isenburg",
       "municipality": {
           "key": "06438009",
           "name": "Neu-Isenburg, Stadt",
           "type": "Stadt"
       },
       "district": {
           "key": "06438",
           "name": "Offenbach",
           "type": "Landkreis"
       },
       "federalState": {
           "key": "06",
           "name": "Hessen"
       }
   }
]

When I search for 63263, I only get Neu-Isenburg as the city and not Frankfurt am Main. Since we only use the first result, user were complaining that the wrong city was prefilled. I am the opinion that postal codes in Germany are unique, aren't they?

Is this intended or can it be fixed? I am happy to help if I am directed in the right direction :)

@rockstaedt
Copy link
Author

Ah I also searched the street.csv file for the postal code.

63263 in combination with Neu-Isenburg exists over 200 times whereas 63263 in combination with Frankfurt am Main only three times.

@fstueber
Copy link
Contributor

This seems to be a bug in merging OSM data with GV100AD data.

@rockstaedt
Copy link
Author

Alright :) And where can this be fixed? The repo only contains the data, doesn't it?

@fstueber
Copy link
Contributor

Yes, exactly. The workflow for extracting and merging data is not yet open sourced. I will try to look into this in the coming days.

@rockstaedt
Copy link
Author

Okidoki, thanks a lot!

@rockstaedt
Copy link
Author

Any news here?

@fstueber
Copy link
Contributor

No yet. Sorry. But it is not forgotten :-)

@fstueber fstueber added the bug Something isn't working label Sep 13, 2024
@fstueber
Copy link
Contributor

Fixed. Please check. Please check also new version of OpenPLZ API: https://www.openplzapi.org/en/change-log/

@rockstaedt
Copy link
Author

Perfect! Works! Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants