-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing codestream marker segments #29
Comments
Minimal support for missing marker segments added in 1.7.0. Full support to follow later .. |
Started with COC marker here. Turns out the SPCOC parameter follows the same format as SPCOD in the COD marker. So first refactor code for parsing in COD, then re-use in COC. Similarly the QCC marker reuses things from QCD. |
For additional test images see JP2s in Tika Regression corpus: http://162.242.228.174/share/jp2.tgz Update - this yielded images with qcc, tlm and crg markers! The openjpeg-data repo contains some more images with coc markers. |
UPDATE: current jpylyzer-2-dev branch now includes validation of COC, QCC, POC, RGN and CRG markers segments, which means that all delimiting (section A.4), fixed information (section A.5), functional (section A.6) and informational marker segments (section A.9) are now covered. Not included (yet) are:
Note that jpylyzer-test-files now has at least 1 test image for all of the above marker segments. |
PR for plt segment here: #170, which will further this issue a bit. |
Further update: @boxerab provided some useful pointers (sample files + code) for TLM parsing here:
|
Hi @bitsgalore I did a first version of it, seems to work fine ` def validate_tlm(self):
` It produces those characteristics: If you're fine with the code, would you mind I contribute ? |
Dev Effort
TBC
Description
Currently jpylyzer doesn’t support the full set of marker segments that can occur in a codestream. Missing ones should ideally be included at some point (although some of them are pretty rare).
A good first step would be to create empty validator functions for all missing marker segments, which is quick and easy to implement. This would allow jpylyzer to report at least the presence of these markers in a file (without providing any details about its fields). This is already very useful information by itself, as some decoders appear to choke on some of the more obscure marker segments, so knowing they're there can already be helpful.
The text was updated successfully, but these errors were encountered: