Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI 0.16 crash on APP-1 #211

Closed
maria-messerschmidt opened this issue Oct 31, 2024 · 0 comments · Fixed by #217
Closed

CLI 0.16 crash on APP-1 #211

maria-messerschmidt opened this issue Oct 31, 2024 · 0 comments · Fixed by #217

Comments

@maria-messerschmidt
Copy link

maria-messerschmidt commented Oct 31, 2024

AT012.ods previously crashed on MAN-4 which should be corrected with #194. It may be corrected, but the file now causes a crash earlier in the proces.

The scenarios affected here are all invalid zip packages of various types. One is a PDF and one is a 7z. Previously, we got PKG-1 and POL_2 for these, but as discussed, this may be DOC-1 now.

AT012.ods

C:\odf\odf-validator-0.16.0>odf-validator.bat D:\odsfiler\AT012.ods
APP-1: [INFO] Validating D:\odsfiler\AT012.ods.
java.lang.NullPointerException: Cannot invoke "org.openpreservation.odf.xml.OdfXmlDocument.getParseResult()" because the return value of "org.openpreservation.odf.pkg.OdfPackageDocument.getXmlDocument(String)" is null
at org.openpreservation.odf.pkg.OdfPackageImpl.getEntryXmlParseResult(OdfPackageImpl.java:200)
at org.openpreservation.odf.validation.ValidatingParserImpl.validateXmlEntry(ValidatingParserImpl.java:122)
at org.openpreservation.odf.validation.ValidatingParserImpl.validateOdfXmlEntries(ValidatingParserImpl.java:109)
at org.openpreservation.odf.validation.ValidatingParserImpl.validate(ValidatingParserImpl.java:99)
at org.openpreservation.odf.validation.ValidatingParserImpl.validatePackage(ValidatingParserImpl.java:72)
at org.openpreservation.odf.validation.Validator.validatePackage(Validator.java:109)
at org.openpreservation.odf.validation.Validator.validate(Validator.java:88)
at org.openpreservation.odf.apps.CliValidator.validatePath(CliValidator.java:74)
at org.openpreservation.odf.apps.CliValidator.call(CliValidator.java:54)
at org.openpreservation.odf.apps.CliValidator.call(CliValidator.java:34)
at picocli.CommandLine.executeUserObject(CommandLine.java:2041)
at picocli.CommandLine.access$1500(CommandLine.java:148)
at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2461)
at picocli.CommandLine$RunLast.handle(CommandLine.java:2453)
at picocli.CommandLine$RunLast.handle(CommandLine.java:2415)
at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2273)
at picocli.CommandLine$RunLast.execute(CommandLine.java:2417)
at picocli.CommandLine.execute(CommandLine.java:2170)
at org.openpreservation.odf.apps.CliValidator.main(CliValidator.java:98)

Same issue happens on AT053.ods:
C:\odf\odf-validator-0.16.0>odf-validator.bat -p D:\odsfiler\AT053.ods
APP-1: [INFO] Validating D:\odsfiler\AT053.ods.
APP-4: [INFO] Validation report for D:\odsfiler\AT053.ods.
DOC-1: [ERROR] D:\odsfiler\AT053.ods An OpenDocument document SHALL be a single XML file or a Zip file.
java.lang.NullPointerException: Cannot invoke "org.openpreservation.odf.document.OpenDocument.isPackage()" because "report.document" is null
at org.openpreservation.odf.apps.CliValidator.isEncrypted(CliValidator.java:133)
at org.openpreservation.odf.apps.CliValidator.results(CliValidator.java:128)
at org.openpreservation.odf.apps.CliValidator.call(CliValidator.java:56)
at org.openpreservation.odf.apps.CliValidator.call(CliValidator.java:34)
at picocli.CommandLine.executeUserObject(CommandLine.java:2041)
at picocli.CommandLine.access$1500(CommandLine.java:148)
at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2461)
at picocli.CommandLine$RunLast.handle(CommandLine.java:2453)
at picocli.CommandLine$RunLast.handle(CommandLine.java:2415)
at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2273)
at picocli.CommandLine$RunLast.execute(CommandLine.java:2417)
at picocli.CommandLine.execute(CommandLine.java:2170)
at org.openpreservation.odf.apps.CliValidator.main(CliValidator.java:98)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant