-
Notifications
You must be signed in to change notification settings - Fork 875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VisBuilder] When creating wizard from visualization page, provide additional options to add to new/existing dashboard, or add to library #2534
Comments
@abbyhu2000 thanks for posting this. Let's prioritize number 1 and 3 for now. Add to a new dashboard requires another flow to create a new dash. Will put more thought on this one. |
[Planning] @btzeng do you have insight for a new dashboard? |
As I work on this issue, some questions arise and i want more opinions:
@ashwin-pc @joshuarrrr @kavilla @btzeng @KrooshalUX @kgcreative |
We can use OuiComboBox here to multi-select dashboards and keep the same 1:many relationship.
We can remove `Add to saved objects. By Saving, it automatically adds to saved objects, and there is no case where a saved object is added to a dashboard, but NOT added to saved objects, so this will simplify the flow.
I think it makes sense to add this conditionally (if dashboards exist, then display the add to dashboard link, otherwise don't) -- this will help this be more extensible in the future cc: @btzeng |
Blocking for now: until @abbyhu2000 @btzeng @opensearch-project/opensearch-ux work out the finer details. |
@abbyhu2000 great callouts. @kgcreative @btzeng This makes me think if we can actually make the save and navigation logic a lot simpler and sensible for the user? My proposal:
The Dashboard manager (i.e. the popup that opens when you click the button) should do the following:
Here is a similar UX that does just this: |
@ashwin-pc @kgcreative @btzeng Although I think it is a useful flow to allow user add visualization directly to dashboard, there are currently some implementation blockers. First of all, we do not have existing flow that let user to add any visualization directly to a dashboard outside of the dashboard app. The current flow is that user go to the dashboard and add the visualization from the add panel or they can create new. The visualization will show up on the dashboard, but the relationship is not actually saved. It only gets saved when user clicks the save button on the dashboard. This save action requires a lot of information from the dashboard app like the dashboard container information, dashboardStateManager, and the grid data and layout of the current list of visualization panels on the dashboard (shown below). All the relationship between dashboard and visualization is managed and stored by dashboard saved object, so only dashboard knows how to add and manage this visualization/dashboard relationship. And dashboard plugin does not currently expose any apis to let another plugin to obtain those information or to give them ability to manage that relationship. There are some potential solutions to solve this:
|
I would be aligned with de-scoping "Add to dashboard" from 2.4 and consider it an incremental feature for all visualizations |
This is definitely a pain for users, especially newer users. But i'm aligned with @kgcreative here. The complexity here is not trivial and needs more research. |
If I recall correctly, |
Is your feature request related to a problem? Please describe.
When user creates a wizard:
Edit
andCreate new
[VizBuilder] Create a new wizard directly on a dashboard #2384Add
Describe the solution you'd like
When user takes the second route to create wizard from the visualization page, we can provide an option for user to add the wizard directly to the dashboard. Here is the UI mockup: @btzeng
Requirements
The text was updated successfully, but these errors were encountered: