Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vis Builder] Persist app filter and query without using state container #3089

Closed
abbyhu2000 opened this issue Dec 15, 2022 · 1 comment
Closed
Assignees
Labels
v2.5.0 'Issues and PRs related to version v2.5.0' vis builder

Comments

@abbyhu2000
Copy link
Member

abbyhu2000 commented Dec 15, 2022

Current plugins persist the app filter and query use two source of truths: they create state container to be in sync with the URL(osdUrlStateStorage), and then the state container also needs to be sync with the state managers for filter and query from the data plugin.

For vis builder, research to see if we can just directly hook state mangers for app filter and query from the data plugin with the URL for persistence.

@joshuarrrr
Copy link
Member

closed via #3100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.5.0 'Issues and PRs related to version v2.5.0' vis builder
Projects
None yet
Development

No branches or pull requests

2 participants