You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
After auditing advanced_settings and saved_objects_management plugins - #3963 (comment), it was discovered that the same code is used to control query change callback of the OuiSearchBar in two places.
Describe the solution you'd like
This problem aims to discuss options to standardize this process:
Add functionality to the OuiSearchBar (OUI library) component to automatically display an error inside of the component if an incorrect query is entered.
Implement a hook that control the onChange callback and consequently returns an error if required (in Dashboards).
@SergeyMyssak Let's hold off on any implementation here until we tackle updates in #4329 (and get similar design guidance for Saved Object Management). The underlying problem in both cases is that the OUI component is more tailored for queries (which may be invalid), than for simple search cases. Arguably in both of these usages, there should not be any need for invalid query handling, if we're just filtering a list of objects for users.
Is your feature request related to a problem? Please describe.
After auditing
advanced_settings
andsaved_objects_management
plugins - #3963 (comment), it was discovered that the same code is used to control query change callback of theOuiSearchBar
in two places.Describe the solution you'd like
This problem aims to discuss options to standardize this process:
OuiSearchBar
(OUI library) component to automatically display an error inside of the component if an incorrect query is entered.onChange
callback and consequently returns an error if required (in Dashboards).Additional context
search.tsx (advanced_settings)
OpenSearch-Dashboards/src/plugins/advanced_settings/public/management_app/components/search/search.tsx
Lines 61 to 75 in 20c928f
table.tsx (saved_objects_management)
OpenSearch-Dashboards/src/plugins/saved_objects_management/public/management_section/objects_table/components/table.tsx
Lines 120 to 134 in 20c928f
The text was updated successfully, but these errors were encountered: