Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy bootstrap stylesheets #4305

Open
joshuarrrr opened this issue Jun 16, 2023 · 0 comments
Open

Remove legacy bootstrap stylesheets #4305

joshuarrrr opened this issue Jun 16, 2023 · 0 comments
Assignees
Labels
OUI compliance Issues and PRs to maximize OUI usage and remove style and component hacks technical debt If not paid, jeapardizes long-term success and maintainability of the repository.

Comments

@joshuarrrr
Copy link
Member

As part of our audit of typographic styles we discovered that, when OpenSearch Dashboards starts up, it bundles together 3 stylesheets:

  1. The selected OUI theme CSS
  2. The KUI theme CSS
  3. A "legacy" stylesheet that consists mostly of Bootstrap resets

To avoid a deep and time-consuming investigation into the expectedly rare cases where these legacy styles actually have a visible effect, we'll simply remove them from our feature branch and test endpoint and visually check for inconsistencies.

@joshuarrrr joshuarrrr self-assigned this Jun 16, 2023
@joshuarrrr joshuarrrr added technical debt If not paid, jeapardizes long-term success and maintainability of the repository. OUI compliance Issues and PRs to maximize OUI usage and remove style and component hacks v2.9.0 and removed untriaged labels Jun 16, 2023
@joshuarrrr joshuarrrr removed the v2.9.0 label Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OUI compliance Issues and PRs to maximize OUI usage and remove style and component hacks technical debt If not paid, jeapardizes long-term success and maintainability of the repository.
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

1 participant