Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard De-Angular] Remove angular bootstrap line when Discover is completely de-angularized #4597

Closed
Tracked by #3365
abbyhu2000 opened this issue Jul 20, 2023 · 1 comment
Closed
Tracked by #3365

[Dashboard De-Angular] Remove angular bootstrap line when Discover is completely de-angularized #4597

abbyhu2000 opened this issue Jul 20, 2023 · 1 comment
Labels
dashboards data explorer Issues related to the Data Explorer project de-angular de-angularize work discover for discover reinvent v2.11.0

Comments

@abbyhu2000
Copy link
Member

abbyhu2000 commented Jul 20, 2023 •
edited
Loading

Remove initAngularBootstrap() in the plugin.tsx after Discover is completely de-angularized. This is needed to render the saved search visualization(created from Discover) correctly on the dashboard.

    // TODO: delete this when discover de-angular is completed
    initAngularBootstrap();
@abbyhu2000 abbyhu2000 mentioned this issue Jul 20, 2023
Closed
26 tasks
@abbyhu2000 abbyhu2000 added the de-angular de-angularize work label Jul 20, 2023
@abbyhu2000 abbyhu2000 changed the title Remove angular bootstrap line when Discover is completely de-angularized [Dashboard De-Angular] Remove angular bootstrap line when Discover is completely de-angularized Jul 20, 2023
@abbyhu2000 abbyhu2000 added dashboards discover for discover reinvent data explorer Issues related to the Data Explorer project and removed untriaged labels Jul 20, 2023
@ananzh ananzh added the v2.11.0 label Sep 14, 2023
@ashwin-pc
Copy link
Member

Fixed in #4982

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dashboards data explorer Issues related to the Data Explorer project de-angular de-angularize work discover for discover reinvent v2.11.0
Projects
Dashboards DeAngularization
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ashwin-pc @abbyhu2000 @ananzh