Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Point series unit test failure #5165

Closed
thanhinhchtom opened this issue Oct 1, 2023 · 4 comments · Fixed by #5174
Closed

[BUG] Point series unit test failure #5165

thanhinhchtom opened this issue Oct 1, 2023 · 4 comments · Fixed by #5174
Assignees
@thanhinhchtom
Labels
bug Something isn't working good first issue Good for newcomers OSCI Open Source Contributor Initiative test:unit

Comments

@thanhinhchtom
Copy link
Contributor

Describe the bug

There is a wrong test case happening with time conversion.

To Reproduce
Steps to reproduce the behavior:

  1. Run the command yarn test:jest src/plugins/discover/public/application/components/chart/utils/point_series.test.ts

Expected behavior
It should run through this test

OpenSearch Version
Snapshot 3.0.0

Dashboards Version
3.0.0

Plugins

Please list all plugins currently enabled.

Screenshots
image

Host/Environment (please complete the following information):

  • OS: macOS Ventura 13.4.1 arm64
  • Browser and version: Google Chrome version 117.0.5938.92

Additional context

Add any other context about the problem here.
@thanhinhchtom thanhinhchtom added bug Something isn't working untriaged labels Oct 1, 2023
@ashwin-pc ashwin-pc changed the title [BUG] [BUG] Point series unit test failure Oct 2, 2023
@joshuarrrr
Copy link
Member

It appears that the unit test output may be sensitive to system timezone - the fix would be to make sure the test is consistent regardless of any local timezone settings.

@joshuarrrr joshuarrrr added OSCI Open Source Contributor Initiative test:unit good first issue Good for newcomers labels Oct 2, 2023
@thanhinhchtom
Copy link
Contributor Author

[OSCI] Can I do this? @joshuarrrr

@joshuarrrr
Copy link
Member

Sure! Assigned to @thanhinhchtom

@thanhinhchtom thanhinhchtom mentioned this issue Oct 2, 2023
Merged
2 tasks
@thanhinhchtom
Copy link
Contributor Author

@joshuarrrr I already create a pull request to fix this problem #5174 . Can you review it for me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thanhinhchtom thanhinhchtom

Labels
bug Something isn't working good first issue Good for newcomers OSCI Open Source Contributor Initiative test:unit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[OSCI] [FIX] time conversion unit test bug thanhinhchtom/OpenSearch-Dashboards
2 participants
@joshuarrrr @thanhinhchtom