Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] lang-painless missing compile dependencies #11353

Closed
prudhvigodithi opened this issue Nov 27, 2023 · 3 comments · Fixed by #11369
Closed

[BUG] lang-painless missing compile dependencies #11353

prudhvigodithi opened this issue Nov 27, 2023 · 3 comments · Fixed by #11369
Labels
bug Something isn't working untriaged

Comments

@prudhvigodithi
Copy link
Contributor

prudhvigodithi commented Nov 27, 2023

Describe the bug
Starting 2.10.0 release the lang-painless maven package https://mvnrepository.com/artifact/org.opensearch.plugin/lang-painless/2.10.0, does not generate the compile dependencies (Maven compile dependencies are the dependencies that are required for the compilation of the project under development)

I assume this bug was introduced from #8823, as looking at the code there are some declared dependencies but are not added in compile dependencies section of the POM file.

Expected behavior
The 2.9.0 lang-painless maven package has the Compile Dependencies https://mvnrepository.com/artifact/org.opensearch.plugin/lang-painless/2.9.0

Another example of ingest-geoip 2.10.0 which has the compile dependencies.

@reta
Copy link
Collaborator

reta commented Nov 28, 2023

@prudhvigodithi I will take a look unless you are already looking

@prudhvigodithi
Copy link
Contributor Author

Hey @reta thanks, looks to like with latest gradle version the ordering of generatePomFileForNebulaPublication is missed when added

tasks.validateNebulaPom.dependsOn tasks.generatePomFileForShadowPublication
tasks.validateShadowPom.dependsOn tasks.generatePomFileForNebulaPublication
tasks.withType(AbstractPublishToMaven)*.dependsOn "generatePomFileForShadowPublication", "generatePomFileForNebulaPublication"

Executing the following generates the right POM file with compile dependencies.
../../gradlew :modules:lang-painless:generatePomFileForNebulaPublication --stacktrace

Since I'm close let me take a stab at it, if not we can collaborate on this.

@prudhvigodithi
Copy link
Contributor Author

@reta I have a PR open, please take a look. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working untriaged
Projects
None yet
2 participants