Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Allow index & cluster default refresh interval to be set as -1 (no periodic background refresh) #11410

Closed
ashking94 opened this issue Nov 30, 2023 · 2 comments · Fixed by #11411
Assignees
Labels
bug Something isn't working Storage:Durability Issues and PRs related to the durability framework

Comments

@ashking94
Copy link
Member

Describe the bug
We have added a setting cluster.minimum.index.refresh_interval which is validated against index creation, updation and index template creation (from api, or snapshot restore). Currently there is a bug that disallow setting index setting as -1 if the cluster.minimum.index.refresh_interval setting is not -1. Refresh interval of -1 corresponds to no background periodic refreshes and this should be allowed to be set for both index setting index.refresh_interval as well as the cluster.default.index.refresh_interval cluster setting.

To Reproduce
Update the minimum setting to zero or higher time. After that try creating/updating an index. This will fail with validation failure.

Expected behavior
The index setting index.refresh_interval and cluster setting cluster.default.index.refresh_interval regardless of the cluster.minimum.index.refresh_interval setting's value.

@ashking94 ashking94 added bug Something isn't working Storage:Durability Issues and PRs related to the durability framework labels Nov 30, 2023
@ashking94 ashking94 self-assigned this Nov 30, 2023
@ashking94
Copy link
Member Author

This is no more required as with remote store it is fine to disallow -1 refresh interval.

@ashking94
Copy link
Member Author

We have revived the change since we have de-risked earlier problem of having too many translog readers with #12992.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Storage:Durability Issues and PRs related to the durability framework
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant