Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] org.opensearch.search.nested.SimpleNestedExplainIT.testExplainMultipleDocs is flaky #12318

Closed
reta opened this issue Feb 14, 2024 · 1 comment · Fixed by #12776
Closed
Labels
bug Something isn't working flaky-test Random test failure that succeeds on second run Search Search query, autocomplete ...etc

Comments

@reta
Copy link
Collaborator

reta commented Feb 14, 2024

Describe the bug

The test case org.opensearch.search.nested.SimpleNestedExplainIT.testExplainMultipleDocs is flaky:

org.opensearch.search.nested.SimpleNestedExplainIT.testExplainMultipleDocs


java.lang.AssertionError: expected:<0.36464313 = Score based on 2 child docs in range from 0 to 1, using score mode Total
  0.18232156 = weight(nested1.n_field1:n_value1 in 0) [PerFieldSimilarity], result of:
    0.18232156 = score(freq=1.0), computed as boost * idf * tf from:
      2.2 = boost
      0.18232156 = idf, computed as log(1 + (N - n + 0.5) / (n + 0.5)) from:
        2 = n, number of documents containing term
        2 = N, total number of documents with field
      0.45454544 = tf, computed as freq / (freq + k1 * (1 - b + b * dl / avgdl)) from:
        1.0 = freq, occurrences of term within document
        1.2 = k1, term saturation parameter
        0.75 = b, length normalization parameter
        1.0 = dl, length of field
        1.0 = avgdl, average length of field
> but was:<0.36464313 = Score based on 2 child docs in range from 14 to 15, using score mode Total
  0.18232156 = weight(nested1.n_field1:n_value1 in 14) [PerFieldSimilarity], result of:
    0.18232156 = score(freq=1.0), computed as boost * idf * tf from:
      2.2 = boost
      0.18232156 = idf, computed as log(1 + (N - n + 0.5) / (n + 0.5)) from:
        2 = n, number of documents containing term
        2 = N, total number of documents with field
      0.45454544 = tf, computed as freq / (freq + k1 * (1 - b + b * dl / avgdl)) from:
        1.0 = freq, occurrences of term within document
        1.2 = k1, term saturation parameter
        0.75 = b, length normalization parameter
        1.0 = dl, length of field
        1.0 = avgdl, average length of field
>

Related component

Search

To Reproduce

./gradlew ':server:internalClusterTest' --tests "org.opensearch.search.nested.SimpleNestedExplainIT.testExplainMultipleDocs" -Dtests.seed=52C9CA95BCB30A28 

Expected behavior

The test must always pass

Additional Details

Plugins
Standard

Screenshots
If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • CI

Additional context

@reta reta added bug Something isn't working untriaged flaky-test Random test failure that succeeds on second run labels Feb 14, 2024
@github-actions github-actions bot added the Search Search query, autocomplete ...etc label Feb 14, 2024
@peternied
Copy link
Member

[Triage - attendees 1 2 3 4 5 6]
@reta Thanks for filing, we would be happy to review a pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flaky-test Random test failure that succeeds on second run Search Search query, autocomplete ...etc
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants