Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Improve built-in secure transports support #12903

Closed
reta opened this issue Mar 25, 2024 · 1 comment · Fixed by #12907
Closed

[FEATURE] Improve built-in secure transports support #12903

reta opened this issue Mar 25, 2024 · 1 comment · Fixed by #12907
Assignees
Labels
enhancement Enhancement or improvement to existing feature or request Other security Anything security related v2.14.0 v3.0.0 Issues and PRs related to version 3.0.0

Comments

@reta
Copy link
Collaborator

reta commented Mar 25, 2024

Is your feature request related to a problem? Please describe

In #12256, we have added built-in secure transports support into OpenSearch core, the further integration with transport plugins and security plugin revealed a couple of areas of improvements.

Describe the solution you'd like

  • split SecureTransportSettingsProvider into SecureTransportSettingsProvider (native transport) and SecureHttpTransportSettingsProvider (HTTP transport): some transport plugins only provide one kind of transport, having fine grained control of the security settings only for particular transport would simplify the configuration
  • support TransportAdapterProvider<?> abstraction to alter the transport specific processing pipelines: the use cases here are primarily driven by security plugin which adds header verifier and decompressor, since every transport has pretty much independent implementation, it becomes the responsibility of the SecureTransportSettingsProvider and SecureHttpTransportSettingsProvider providers to supply the right one for a particular transport

Related component

Other

Describe alternatives you've considered

N/A

Additional context

@reta reta added enhancement Enhancement or improvement to existing feature or request v3.0.0 Issues and PRs related to version 3.0.0 v2.14.0 labels Mar 25, 2024
@reta reta self-assigned this Mar 25, 2024
@peternied
Copy link
Member

[Triage - attendees 1 2 3 4 5 6 7]
@reta Thanks for filing this issue, looking forward to seeing these improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Other security Anything security related v2.14.0 v3.0.0 Issues and PRs related to version 3.0.0
Projects
Status: Planned work items
Development

Successfully merging a pull request may close this issue.

2 participants