Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote Store] Prefer remote replicas for primary promotion during migration #13135

Closed
ltaragi opened this issue Apr 9, 2024 · 0 comments · Fixed by #13136
Closed

[Remote Store] Prefer remote replicas for primary promotion during migration #13135

ltaragi opened this issue Apr 9, 2024 · 0 comments · Fixed by #13136
Assignees
Labels
enhancement Enhancement or improvement to existing feature or request Storage:Durability Issues and PRs related to the durability framework Storage:Remote

Comments

@ltaragi
Copy link
Contributor

ltaragi commented Apr 9, 2024

Is your feature request related to a problem? Please describe

  • During remote store migration (MIXED compatibility mode and REMOTE_STORE migration direction), we aim to continuously move forward.
  • To ensure this, in case of a primary shard failover:
    • If the primary and one or more replica copies had already migrated to remote nodes, then the new primary must be chosen randomly from the migrated replicas
    • If no migrated replica is found, fall back upon the existing mechanism

Describe the solution you'd like

Inside unassignPrimaryAndPromoteActiveReplicaIfExists in RoutingNodes.java:

  • metadata can be used to identify migration conditions
  • Using the failedShard's id, we can look for migrated replica copies and implement the above preference

Related component

Storage:Remote

Describe alternatives you've considered

No response

Additional context

No response

@ltaragi ltaragi added enhancement Enhancement or improvement to existing feature or request Storage:Durability Issues and PRs related to the durability framework Storage:Remote labels Apr 9, 2024
@ltaragi ltaragi self-assigned this Apr 9, 2024
@ltaragi ltaragi removed the untriaged label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Storage:Durability Issues and PRs related to the durability framework Storage:Remote
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant