Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make recovery action retry timeout configurable #14022

Merged
merged 4 commits into from
Jun 7, 2024

Conversation

gbbafna
Copy link
Collaborator

@gbbafna gbbafna commented Jun 6, 2024

Description

Add recovery action retry setting . This allows changing it dynamically.

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Jun 6, 2024

❌ Gradle check result for e8c0b87: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@gbbafna gbbafna requested a review from shourya035 June 6, 2024 06:11
Copy link
Member

@shourya035 shourya035 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Strange that the indices.recovery.internal_action_retry_timeout setting was marked as Dynamic and NodeScope but there wasn't a way to change these settings dynamically through Cluster Settings API.

Copy link
Contributor

github-actions bot commented Jun 6, 2024

❌ Gradle check result for c2786b4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jun 6, 2024

✅ Gradle check result for 1af6b1c: SUCCESS

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.60%. Comparing base (b15cb0c) to head (92efc25).
Report is 366 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #14022      +/-   ##
============================================
+ Coverage     71.42%   71.60%   +0.18%     
- Complexity    59978    61376    +1398     
============================================
  Files          4985     5073      +88     
  Lines        282275   288528    +6253     
  Branches      40946    41776     +830     
============================================
+ Hits         201603   206593    +4990     
- Misses        63999    64883     +884     
- Partials      16673    17052     +379     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gbbafna gbbafna added the backport 2.x Backport to 2.x branch label Jun 6, 2024
This reverts commit a4f00d2.

Signed-off-by: Gaurav Bafna <[email protected]>
Copy link
Contributor

github-actions bot commented Jun 6, 2024

❌ Gradle check result for 2f29b43: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jun 6, 2024

❌ Gradle check result for 2f29b43: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jun 6, 2024

❌ Gradle check result for 92efc25: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@gbbafna
Copy link
Collaborator Author

gbbafna commented Jun 6, 2024

[org.opensearch.action.admin.indices.create.RemoteSplitIndexIT.classMethod](https://build.ci.opensearch.org/job/gradle-check/40022/testReport/junit/org.opensearch.action.admin.indices.create/RemoteSplitIndexIT/classMethod/)
    [org.opensearch.indices.IndicesRequestCacheIT.testCacheCleanupWithDefaultSettings {p0={"search.concurrent_segment_search.enabled":"true"}}](https://build.ci.opensearch.org/job/gradle-check/40022/testReport/junit/org.opensearch.indices/IndicesRequestCacheIT/testCacheCleanupWithDefaultSettings__p0___search_concurrent_segment_search_enabled___true___/)
    [org.opensearch.remotemigration.RemoteMigrationIndexMetadataUpdateIT.testRemoteIndexPathFileExistsAfterMigration](https://build.ci.opensearch.org/job/gradle-check/40022/testReport/junit/org.opensearch.remotemigration/RemoteMigrationIndexMetadataUpdateIT/testRemoteIndexPathFileExistsAfterMigration/)
    [org.opensearch.action.admin.cluster.node.tasks.ResourceAwareTasksTests.testTaskResourceTrackingDuringTaskCancellation](https://build.ci.opensearch.org/job/gradle-check/40022/testReport/junit/org.opensearch.action.admin.cluster.node.tasks/ResourceAwareTasksTests/testTaskResourceTrackingDuringTaskCancellation/)

Copy link
Contributor

github-actions bot commented Jun 6, 2024

❌ Gradle check result for 92efc25: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jun 7, 2024

✅ Gradle check result for 92efc25: SUCCESS

@gbbafna gbbafna merged commit 5bad14c into opensearch-project:main Jun 7, 2024
30 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-14022-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5bad14cf06b4fc1c6f0d5ff03a72f06bb38d1026
# Push it to GitHub
git push --set-upstream origin backport/backport-14022-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-14022-to-2.x.

gbbafna added a commit to gbbafna/OpenSearch that referenced this pull request Jun 7, 2024
gbbafna added a commit to gbbafna/OpenSearch that referenced this pull request Jun 8, 2024
sachinpkale pushed a commit that referenced this pull request Jun 9, 2024
parv0201 pushed a commit to parv0201/OpenSearch that referenced this pull request Jun 10, 2024
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants