Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Optimise unassigned shards iteration after allocator timeout #14944

Closed
imRishN opened this issue Jul 24, 2024 · 1 comment · Fixed by #14977
Closed

[BUG] Optimise unassigned shards iteration after allocator timeout #14944

imRishN opened this issue Jul 24, 2024 · 1 comment · Fixed by #14977
Labels
bug Something isn't working Cluster Manager Other

Comments

@imRishN
Copy link
Member

imRishN commented Jul 24, 2024

Describe the bug

Currently, we would iterate over unassigned shards whenever we timeout pending batches after elapsed time. This might become expensive if shards take multiple iterations of reroute to get assigned.

Related PR comment - #14848 (comment)

Related component

Other

To Reproduce

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

Optimise the behaviour by checking non executed shards at once and call the timeout method post that

Additional Details

Plugins
Please list all plugins currently enabled.

Screenshots
If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • OS: [e.g. iOS]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@peternied
Copy link
Member

[Triage - attendees 1 2]
@imRishN Thanks for creating this issue, could you make a pull request to address this or update the description to remove to make it clearer what should be done for another community member?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Cluster Manager Other
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants