Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Star tree] Handle 'count', 'avg' metric and default metrics in star tree mapper #15148

Closed
bharath-techie opened this issue Aug 7, 2024 · 0 comments · Fixed by #15152
Closed
Assignees
Labels
enhancement Enhancement or improvement to existing feature or request Indexing:Performance v2.17.0

Comments

@bharath-techie
Copy link
Contributor

bharath-techie commented Aug 7, 2024

Is your feature request related to a problem? Please describe

  • Since all aggregation results has 'doc_count' as part response, star tree will require 'value_count' for all metric fields specified as part of star tree mapping
  • When user specifies 'avg' metric, we need 'value_count' and 'sum' metric for the metric fields so that we can derive avg
  • Set default metrics to be 'sum', 'value_count' and by extension 'avg' since it can be derived based on sum and count.
  • Rename 'count' to 'value_count' in star tree mapping

Describe the solution you'd like

  • Auto-add 'value_count' for all metric fields specified as part of star tree mapping
  • To handle 'avg' metric, automatically add 'sum' metric to metric field so that we can compute during query time via 'sum/value_count'
  • Set default metrics to be 'sum', 'value_count' and by extension 'avg' since it can be derived based on sum and count. Keeping it minimal since performance and storage size increases per every metric.
  • Rename 'count' to 'value_count' in star tree flows to be inline with search aggregations

Related component

Indexing:Performance

Describe alternatives you've considered

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Indexing:Performance v2.17.0
Projects
None yet
1 participant