Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Placing lucene packages outside of server module #15317

Open
sarthakaggarwal97 opened this issue Aug 20, 2024 · 2 comments
Open
Labels
enhancement Enhancement or improvement to existing feature or request Libraries Lucene Upgrades and Libraries, Any 3rd party library that Core depends on, ex: nebula; team is respo

Comments

@sarthakaggarwal97
Copy link
Contributor

sarthakaggarwal97 commented Aug 20, 2024

Is your feature request related to a problem? Please describe

Currently, we have many lucene package based classes under a different package structure (org.apache.lucene)
This issue is to discuss whether theses classes and components can be moved outside of the server to /lib

Describe the solution you'd like

We should discuss we can move these components to outside of server for v3.0, while making sure we don't break any flows.

Related component

Libraries

Describe alternatives you've considered

No response

Additional context

#15278 (comment)

@sarthakaggarwal97 sarthakaggarwal97 added enhancement Enhancement or improvement to existing feature or request untriaged labels Aug 20, 2024
@github-actions github-actions bot added the Libraries Lucene Upgrades and Libraries, Any 3rd party library that Core depends on, ex: nebula; team is respo label Aug 20, 2024
@andrross
Copy link
Member

@sarthakaggarwal97 I believe the only reason to use org.apache.lucene is to access package-private methods/fields in Lucene. This isn't a great practice as it means we're using something that is not intended to be used directly outside of Lucene. I think we should try to avoid this whenever possible and I would be concerned that moving this code to its own library might encourage more use of this pattern.

@dblock dblock removed the untriaged label Sep 9, 2024
@dblock
Copy link
Member

dblock commented Sep 9, 2024

[Catch All Triage - 1, 2, 3, 4, 5]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Libraries Lucene Upgrades and Libraries, Any 3rd party library that Core depends on, ex: nebula; team is respo
Projects
None yet
Development

No branches or pull requests

3 participants