Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Segment Replication] Remove unnecessary calls to directory.fsync and directory.syncmetadata #2333

Closed
Tracked by #3969
mch2 opened this issue Mar 3, 2022 · 2 comments
Assignees

Comments

@mch2
Copy link
Member

mch2 commented Mar 3, 2022

These calls are not necessary with segment replication enabled and at last 1 replica shard. They can be removed. This change should be gated by our index setting.

@mch2 mch2 added bug Something isn't working untriaged labels Mar 3, 2022
@mch2 mch2 removed bug Something isn't working untriaged labels Mar 7, 2022
@mch2
Copy link
Member Author

mch2 commented Jun 24, 2022

This issue only applies when using a remote store as the source of replication. When copying from primary shards we still require fsyncs when segments related to a new commit point are received.

@mch2
Copy link
Member Author

mch2 commented Sep 12, 2022

Closing, this is disabled with #4402

@mch2 mch2 closed this as completed Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants