Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for how to build an uber/fat jar (of the client) #3702

Open
dblock opened this issue Jun 25, 2022 · 4 comments
Open

Add instructions for how to build an uber/fat jar (of the client) #3702

dblock opened this issue Jun 25, 2022 · 4 comments
Labels
Clients Clients within the Core repository such as High level Rest client and low level client enhancement Enhancement or improvement to existing feature or request

Comments

@dblock
Copy link
Member

dblock commented Jun 25, 2022

Is your feature request related to a problem? Please describe.
In #3665 we'd like to give the client with the changes to someone to try. How does one build an uber/fat jar of it?

Describe the solution you'd like
A gradle task that builds an uber/fat JAR of the client.

@dblock dblock added enhancement Enhancement or improvement to existing feature or request untriaged labels Jun 25, 2022
@pgtgrly
Copy link
Contributor

pgtgrly commented Jun 25, 2022

@jiten1551 and I were able to build uber jars using Gradle Shadow plugin
and running the shadowJar command.
Ref Commit for adding the plugin: kumjiten@d18e0d8

@dblock
Copy link
Member Author

dblock commented Jun 27, 2022

@pgtgrly @jiten1551

I think we probably don't want to add that to Gradle if it's not going to be used in CI/CD, but care to a few lines of instructions with exactly the changes (link to this commit on the fork), the commands being run and the output produced to https://github.com/opensearch-project/OpenSearch/blob/main/DEVELOPER_GUIDE.md for the next person who needs it?

@dblock dblock changed the title Build an uber/fat jar of the client Add instructions for how to build an uber/fat jar (of the client) Jun 27, 2022
@saratvemulapalli saratvemulapalli added Clients Clients within the Core repository such as High level Rest client and low level client and removed untriaged labels Jun 27, 2022
@pgtgrly
Copy link
Contributor

pgtgrly commented Jun 29, 2022

@dblock, Sure Will update the guide and raise PR latest by EoD 5 July 2022

@pgtgrly
Copy link
Contributor

pgtgrly commented Jul 6, 2022

Created a PR: #3785

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clients Clients within the Core repository such as High level Rest client and low level client enhancement Enhancement or improvement to existing feature or request
Projects
None yet
Development

No branches or pull requests

3 participants