Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] [Segment Replication] Flaky test SegmentReplicationTargetServiceTests.testReplicationOnDone #4184

Closed
dreamer-89 opened this issue Aug 10, 2022 · 2 comments
Closed

[BUG] [Segment Replication] Flaky test SegmentReplicationTargetServiceTests.testReplicationOnDone #4184

dreamer-89 opened this issue Aug 10, 2022 · 2 comments
Labels
bug Something isn't working distributed framework enhancement Enhancement or improvement to existing feature or request

Comments

@dreamer-89
Copy link
Member

dreamer-89 commented Aug 10, 2022 •
edited
Loading

Describe the bug
Unit test OngoingSegmentReplicationsTests.testMultipleReplicasUseSameCheckpoint fails intermittenly on gradle check.

REPRODUCE WITH: ./gradlew ':server:test' --tests "org.opensearch.indices.replication.SegmentReplicationTargetServiceTests.testReplicationOnDone" -Dtests.seed=18F9CB5CD66407EA -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=ms -Dtests.timezone=Europe/Sofia -Druntime.java=17

org.opensearch.indices.replication.SegmentReplicationTargetServiceTests > testReplicationOnDone FAILED
    org.mockito.exceptions.verification.TooFewActualInvocations: 
    segmentReplicationTargetService.onNewCheckpoint(
        ReplicationCheckpoint{shardId=[index][0], primaryTerm=94, segmentsGen=3, seqNo=-1, version=9},
        <any>
    );
    Wanted 2 times:
    -> at org.opensearch.indices.replication.SegmentReplicationTargetServiceTests.testReplicationOnDone(SegmentReplicationTargetServiceTests.java:236)
    But was 1 time:
    -> at org.opensearch.indices.replication.SegmentReplicationTargetServiceTests.testReplicationOnDone(SegmentReplicationTargetServiceTests.java:230)
        at __randomizedtesting.SeedInfo.seed([18F9CB5CD66407EA:2371B911C98E848]:0)
        at app//org.opensearch.indices.replication.SegmentReplicationTargetServiceTests.testReplicationOnDone(SegmentReplicationTargetServiceTests.java:236)

To Reproduce
Steps to reproduce the behavior:

  1. Run above test continuously, it may fail with above error.

Expected behavior
Test should not fail
@dreamer-89 dreamer-89 added bug Something isn't working untriaged labels Aug 10, 2022
@dreamer-89 dreamer-89 mentioned this issue Aug 10, 2022
Merged
@dreamer-89
Copy link
Member Author

dreamer-89 commented Aug 10, 2022 •
edited
Loading

Failed in #4041

@dreamer-89 dreamer-89 changed the title [BUG] [Segment Replication] Flaky test OngoingSegmentReplicationsTests.testMultipleReplicasUseSameCheckpoint [BUG] [Segment Replication] Flaky test SegmentReplicationTargetServiceTests.testReplicationOnDone Aug 10, 2022
@Poojita-Raj Poojita-Raj added enhancement Enhancement or improvement to existing feature or request distributed framework and removed untriaged labels Aug 16, 2022
@dreamer-89
Copy link
Member Author

This was first fixed in #4314 but later on removed in #4225. Closing this issue.

@rishabhmaurya rishabhmaurya mentioned this issue Oct 3, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working distributed framework enhancement Enhancement or improvement to existing feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Poojita-Raj @dreamer-89