Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Zone Decommission] Fail weight update when decommission ongoing and fail decommission when attribute not weighed away #4838

Closed
imRishN opened this issue Oct 19, 2022 · 1 comment
Labels
enhancement Enhancement or improvement to existing feature or request

Comments

@imRishN
Copy link
Member

imRishN commented Oct 19, 2022

Is your feature request related to a problem? Please describe.
While triggering weight update for an awareness attribute, we should check if any ongoing decommission action is in process. If yes, we should fail the weight update request as it might lead cluster to an unexpected state where weights would be set to a decommissioned zone or for that matter any such state update. During decommission we are already stopping any traffic in one attribute. Any weight update during this can have cascading effect.

Also, before executing decommission we should check if the to-be-decommissioned attribute is already weighed away. If not, we should fail the decommission action.

@imRishN
Copy link
Member Author

imRishN commented Oct 21, 2022

PR merged

@imRishN imRishN closed this as completed Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request
Projects
None yet
Development

No branches or pull requests

2 participants