Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Extension]Load Extension Dependencies in ExtensionsManager #5936

Closed
ryanbogan opened this issue Jan 19, 2023 · 0 comments
Closed

[Extension]Load Extension Dependencies in ExtensionsManager #5936

ryanbogan opened this issue Jan 19, 2023 · 0 comments
Assignees
Labels
bug Something isn't working extensions

Comments

@ryanbogan
Copy link
Member

Since the change to SnakeYAML for reading in extensions from extensions.yml, extension dependencies are not being loaded in ExtensionsManager. There is also a test in ExtensionsManagerTests that is not properly checking whether the dependencies are working properly (the test is currently passing).

Steps to fix:

  • Add a new constructor in ExtensionsSettings that also takes a list of dependencies and sets the instance variable
  • Load the dependencies along with the other fields in readFromExtensionsYml, which is in ExtensionsManager
  • Change testDiscover to check if dependencies are loaded
@ryanbogan ryanbogan added bug Something isn't working extensions labels Jan 19, 2023
@ryanbogan ryanbogan self-assigned this Jan 20, 2023
@minalsha minalsha changed the title Load Extension Dependencies in ExtensionsManager [Extension]Load Extension Dependencies in ExtensionsManager Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working extensions
Projects
None yet
Development

No branches or pull requests

2 participants