From 2154282a1dd6fc46daa3344a7dac252adc0c6490 Mon Sep 17 00:00:00 2001 From: Rabi Panda Date: Tue, 15 Nov 2022 09:46:32 -0800 Subject: [PATCH 1/2] Call 'toArray()' with an empty array instead of a pre-sized array Calls to `Collection.toArray()` is not consistent and in many places and use a pre-sized array parameter. This change makes a consistent use of the `toArray(new T[0])`. The empty array usage is considered faster, safer and cleaner than the sized based array approach. Signed-off-by: Rabi Panda --- CHANGELOG.md | 1 + .../gradle/DistributionDownloadPlugin.java | 2 +- .../opensearch/client/core/CountResponse.java | 2 +- .../indices/PutIndexTemplateRequest.java | 2 +- .../client/RestHighLevelClientExtTests.java | 2 +- .../plugins/InstallPluginCommand.java | 2 +- .../plugins/RemovePluginCommand.java | 2 +- .../org/opensearch/common/ParseField.java | 4 ++-- .../support/filtering/FilterPath.java | 2 +- .../filtering/FilterPathBasedFilter.java | 2 +- .../join/query/ChildQuerySearchIT.java | 2 +- .../rankeval/TransportRankEvalAction.java | 9 ++----- .../AbstractAsyncBulkByScrollAction.java | 2 +- .../reindex/DeleteByQueryBasicTests.java | 2 +- .../index/reindex/ReindexBasicTests.java | 2 +- .../reindex/UpdateByQueryBasicTests.java | 2 +- .../highlight/AnnotatedPassageFormatter.java | 2 +- .../opensearch/action/IndicesRequestIT.java | 2 +- .../action/admin/indices/get/GetIndexIT.java | 4 ++-- .../org/opensearch/recovery/RelocationIT.java | 2 +- .../aggregations/bucket/GeoDistanceIT.java | 2 +- .../aggregations/bucket/LongTermsIT.java | 2 +- .../aggregations/pipeline/MaxBucketIT.java | 16 ++++++------- .../aggregations/pipeline/MinBucketIT.java | 14 +++++------ .../search/basic/SearchWhileRelocatingIT.java | 2 +- .../search/morelikethis/MoreLikeThisIT.java | 2 +- .../SharedClusterSnapshotRestoreIT.java | 4 ++-- .../uhighlight/CustomFieldHighlighter.java | 2 +- .../restore/RestoreRemoteStoreRequest.java | 2 +- .../create/CreateSnapshotRequest.java | 2 +- .../restore/RestoreSnapshotRequest.java | 4 ++-- .../stats/TransportClusterStatsAction.java | 8 +------ .../alias/TransportIndicesAliasesAction.java | 6 ++--- .../delete/TransportDeleteIndexAction.java | 2 +- .../admin/indices/segments/IndexSegments.java | 5 +--- .../segments/IndicesSegmentResponse.java | 2 +- .../indices/segments/PitSegmentsRequest.java | 2 +- .../TransportIndicesSegmentsAction.java | 2 +- .../segments/TransportPitSegmentsAction.java | 2 +- .../admin/indices/stats/CommonStatsFlags.java | 2 +- .../admin/indices/stats/IndexStats.java | 7 ++---- .../stats/TransportIndicesStatsAction.java | 8 +------ .../template/put/PutIndexTemplateRequest.java | 2 +- .../upgrade/get/IndexUpgradeStatus.java | 2 +- .../get/TransportUpgradeStatusAction.java | 2 +- .../upgrade/get/UpgradeStatusResponse.java | 2 +- .../opensearch/action/bulk/BulkResponse.java | 2 +- .../action/bulk/TransportBulkAction.java | 2 +- .../action/get/MultiGetRequest.java | 6 ++--- .../action/search/ClearScrollRequest.java | 2 +- .../action/search/DeletePitRequest.java | 2 +- .../opensearch/action/search/PitService.java | 2 +- .../search/SearchScrollAsyncAction.java | 2 +- .../action/support/ActionFilters.java | 2 +- .../support/broadcast/BroadcastResponse.java | 2 +- .../replication/ReplicationResponse.java | 2 +- .../metadata/IndexNameExpressionResolver.java | 4 ++-- .../cluster/routing/RoutingNodes.java | 4 ++-- .../routing/allocation/AllocationService.java | 2 +- .../allocator/LocalShardsBalancer.java | 4 ++-- .../java/org/opensearch/common/Strings.java | 2 +- .../opensearch/common/blobstore/BlobPath.java | 2 +- .../common/bytes/BytesReference.java | 2 +- .../common/geo/GeoPolygonDecomposer.java | 2 +- .../geo/builders/LineStringBuilder.java | 4 ++-- .../geo/builders/MultiLineStringBuilder.java | 2 +- .../common/geo/builders/PolygonBuilder.java | 4 ++-- .../lucene/index/FilterableTermsEnum.java | 2 +- .../common/lucene/search/XMoreLikeThis.java | 2 +- .../common/network/NetworkService.java | 4 ++-- .../common/network/NetworkUtils.java | 6 ++--- .../opensearch/common/settings/Settings.java | 2 +- .../common/settings/SettingsFilter.java | 2 +- ...ioritizedOpenSearchThreadPoolExecutor.java | 2 +- .../org/opensearch/env/NodeEnvironment.java | 2 +- .../gateway/LocalAllocateDangledIndices.java | 5 +--- .../index/analysis/AnalyzerComponents.java | 4 ++-- .../analysis/CustomNormalizerProvider.java | 4 ++-- .../org/opensearch/index/engine/Engine.java | 2 +- .../opensearch/index/mapper/ParseContext.java | 2 +- .../index/query/IdsQueryBuilder.java | 2 +- .../index/query/MoreLikeThisQueryBuilder.java | 18 +++++++------- .../query/VectorGeoShapeQueryProcessor.java | 6 +---- .../FunctionScoreQueryBuilder.java | 2 +- .../index/reindex/ReindexRequest.java | 2 +- .../index/shard/LocalShardSnapshot.java | 2 +- .../org/opensearch/monitor/fs/FsProbe.java | 2 +- .../monitor/jvm/DeadlockAnalyzer.java | 2 +- .../org/opensearch/monitor/jvm/JvmInfo.java | 2 +- .../document/RestTermVectorsAction.java | 2 +- .../action/search/RestGetAllPitsAction.java | 2 +- .../aggregations/MultiBucketCollector.java | 2 +- .../SignificantTextAggregationBuilder.java | 2 +- .../pipeline/BucketMetricsParser.java | 2 +- .../DerivativePipelineAggregationBuilder.java | 2 +- .../pipeline/MaxBucketPipelineAggregator.java | 2 +- .../MovAvgPipelineAggregationBuilder.java | 2 +- .../SerialDiffPipelineAggregationBuilder.java | 2 +- .../fetch/subphase/FetchSourceContext.java | 6 ++--- .../subphase/highlight/HighlightField.java | 2 +- .../search/sort/GeoDistanceSortBuilder.java | 6 ++--- .../opensearch/search/sort/SortBuilder.java | 5 +--- .../phrase/DirectCandidateGenerator.java | 2 +- .../phrase/NoisyChannelSpellChecker.java | 2 +- .../suggest/phrase/PhraseSuggester.java | 2 +- .../opensearch/snapshots/SnapshotInfo.java | 6 +---- .../node/tasks/TransportTasksActionTests.java | 2 +- .../ClusterSearchShardsResponseTests.java | 2 +- .../TransportRolloverActionTests.java | 2 +- .../stats/IndicesStatsResponseTests.java | 8 +------ .../action/bulk/BulkRequestModifierTests.java | 2 +- .../nodes/TransportNodesActionTests.java | 2 +- .../AbstractTermVectorsTestCase.java | 2 +- .../cluster/node/DiscoveryNodesTests.java | 4 ++-- .../allocation/FailedNodeRoutingTests.java | 2 +- .../cluster/serialization/DiffableTests.java | 5 +--- .../common/collect/IteratorsTests.java | 2 +- .../common/geo/GeoJsonShapeParserTests.java | 24 +++++++++---------- .../common/geo/GeoWKTShapeParserTests.java | 10 ++++---- .../support/XContentMapValuesTests.java | 4 ++-- .../opensearch/env/NodeEnvironmentTests.java | 2 +- .../query/MoreLikeThisQueryBuilderTests.java | 5 +--- .../index/query/RegexpQueryBuilderTests.java | 2 +- .../query/SimpleQueryStringBuilderTests.java | 2 +- .../index/query/TermsQueryBuilderTests.java | 2 +- .../seqno/LocalCheckpointTrackerTests.java | 2 +- .../index/translog/SnapshotMatchers.java | 2 +- ...ClusterStateServiceRandomUpdatesTests.java | 8 +++---- .../indices/store/IndicesStoreTests.java | 2 +- .../search/CreatePitSingleNodeTests.java | 2 +- .../support/AggregationPathTests.java | 2 +- .../highlight/HighlightBuilderTests.java | 2 +- .../search/sort/FieldSortBuilderTests.java | 2 +- .../sort/GeoDistanceSortBuilderTests.java | 2 +- .../search/sort/SortBuilderTests.java | 2 +- .../hamcrest/OpenSearchGeoAssertions.java | 2 +- .../UpdateThreadPoolSettingsTests.java | 2 +- .../ClusterStateCreationUtils.java | 2 +- ...earchBlobStoreRepositoryIntegTestCase.java | 4 ++-- .../opensearch/test/InternalTestCluster.java | 2 +- .../test/OpenSearchIntegTestCase.java | 4 ++-- .../opensearch/test/XContentTestUtils.java | 2 +- .../test/hamcrest/OpenSearchAssertions.java | 5 +--- .../test/rest/OpenSearchRestTestCase.java | 4 ++-- .../test/transport/MockTransportService.java | 2 +- 145 files changed, 212 insertions(+), 265 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 16af268875578..46070acff547b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -43,6 +43,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), - Relax visibility of the HTTP_CHANNEL_KEY and HTTP_SERVER_CHANNEL_KEY to make it possible for the plugins to access associated Netty4HttpChannel / Netty4HttpServerChannel instance ([#4638](https://github.com/opensearch-project/OpenSearch/pull/4638)) - Use ReplicationFailedException instead of OpensearchException in ReplicationTarget ([#4725](https://github.com/opensearch-project/OpenSearch/pull/4725)) - Migrate client transports to Apache HttpClient / Core 5.x ([#4459](https://github.com/opensearch-project/OpenSearch/pull/4459)) +- Call 'toArray()' with an empty array instead of a pre-sized array ([#5277](https://github.com/opensearch-project/OpenSearch/pull/5277)) ### Deprecated diff --git a/buildSrc/src/main/java/org/opensearch/gradle/DistributionDownloadPlugin.java b/buildSrc/src/main/java/org/opensearch/gradle/DistributionDownloadPlugin.java index ae7b0d938e8ef..eb3cd4d089417 100644 --- a/buildSrc/src/main/java/org/opensearch/gradle/DistributionDownloadPlugin.java +++ b/buildSrc/src/main/java/org/opensearch/gradle/DistributionDownloadPlugin.java @@ -174,7 +174,7 @@ private static void addIvyRepo(Project project, String name, String url, String project.getRepositories().exclusiveContent(exclusiveContentRepository -> { exclusiveContentRepository.filter(config -> config.includeGroup(group)); - exclusiveContentRepository.forRepositories(repos.toArray(new IvyArtifactRepository[repos.size()])); + exclusiveContentRepository.forRepositories(repos.toArray(new IvyArtifactRepository[0])); }); } diff --git a/client/rest-high-level/src/main/java/org/opensearch/client/core/CountResponse.java b/client/rest-high-level/src/main/java/org/opensearch/client/core/CountResponse.java index 1d67a50f68f40..ca4446258446b 100644 --- a/client/rest-high-level/src/main/java/org/opensearch/client/core/CountResponse.java +++ b/client/rest-high-level/src/main/java/org/opensearch/client/core/CountResponse.java @@ -233,7 +233,7 @@ static ShardStats fromXContent(XContentParser parser) throws IOException { parser.skipChildren(); } } - return new ShardStats(successfulShards, totalShards, skippedShards, failures.toArray(new ShardSearchFailure[failures.size()])); + return new ShardStats(successfulShards, totalShards, skippedShards, failures.toArray(new ShardSearchFailure[0])); } @Override diff --git a/client/rest-high-level/src/main/java/org/opensearch/client/indices/PutIndexTemplateRequest.java b/client/rest-high-level/src/main/java/org/opensearch/client/indices/PutIndexTemplateRequest.java index 5f43ec7f1d0fe..cd0eb8881ab0c 100644 --- a/client/rest-high-level/src/main/java/org/opensearch/client/indices/PutIndexTemplateRequest.java +++ b/client/rest-high-level/src/main/java/org/opensearch/client/indices/PutIndexTemplateRequest.java @@ -435,7 +435,7 @@ public PutIndexTemplateRequest alias(Alias alias) { @Override public String[] indices() { - return indexPatterns.toArray(new String[indexPatterns.size()]); + return indexPatterns.toArray(new String[0]); } @Override diff --git a/client/rest-high-level/src/test/java/org/opensearch/client/RestHighLevelClientExtTests.java b/client/rest-high-level/src/test/java/org/opensearch/client/RestHighLevelClientExtTests.java index 5743820ff0175..1499b006da410 100644 --- a/client/rest-high-level/src/test/java/org/opensearch/client/RestHighLevelClientExtTests.java +++ b/client/rest-high-level/src/test/java/org/opensearch/client/RestHighLevelClientExtTests.java @@ -153,7 +153,7 @@ static CustomResponseSection2 fromXContent(XContentParser parser) throws IOExcep values.add(parser.text()); } assertEquals(XContentParser.Token.END_ARRAY, parser.currentToken()); - CustomResponseSection2 responseSection2 = new CustomResponseSection2(values.toArray(new String[values.size()])); + CustomResponseSection2 responseSection2 = new CustomResponseSection2(values.toArray(new String[0])); assertEquals(XContentParser.Token.END_OBJECT, parser.nextToken()); return responseSection2; } diff --git a/distribution/tools/plugin-cli/src/main/java/org/opensearch/plugins/InstallPluginCommand.java b/distribution/tools/plugin-cli/src/main/java/org/opensearch/plugins/InstallPluginCommand.java index c2db39ecea072..5bf0bc7763ddd 100644 --- a/distribution/tools/plugin-cli/src/main/java/org/opensearch/plugins/InstallPluginCommand.java +++ b/distribution/tools/plugin-cli/src/main/java/org/opensearch/plugins/InstallPluginCommand.java @@ -1028,7 +1028,7 @@ private static void setFileAttributes(final Path path, final Set set = new HashSet<>(); Collections.addAll(set, deprecatedNames); - this.deprecatedNames = set.toArray(new String[set.size()]); + this.deprecatedNames = set.toArray(new String[0]); } Set allNames = new HashSet<>(); allNames.add(name); Collections.addAll(allNames, this.deprecatedNames); - this.allNames = allNames.toArray(new String[allNames.size()]); + this.allNames = allNames.toArray(new String[0]); } /** diff --git a/libs/x-content/src/main/java/org/opensearch/common/xcontent/support/filtering/FilterPath.java b/libs/x-content/src/main/java/org/opensearch/common/xcontent/support/filtering/FilterPath.java index be7778097b45b..a11b13ec65946 100644 --- a/libs/x-content/src/main/java/org/opensearch/common/xcontent/support/filtering/FilterPath.java +++ b/libs/x-content/src/main/java/org/opensearch/common/xcontent/support/filtering/FilterPath.java @@ -101,7 +101,7 @@ public static FilterPath[] compile(Set filters) { } } } - return paths.toArray(new FilterPath[paths.size()]); + return paths.toArray(new FilterPath[0]); } private static FilterPath parse(final String filter, final String segment) { diff --git a/libs/x-content/src/main/java/org/opensearch/common/xcontent/support/filtering/FilterPathBasedFilter.java b/libs/x-content/src/main/java/org/opensearch/common/xcontent/support/filtering/FilterPathBasedFilter.java index 0463caaa93118..5e402cbd495ba 100644 --- a/libs/x-content/src/main/java/org/opensearch/common/xcontent/support/filtering/FilterPathBasedFilter.java +++ b/libs/x-content/src/main/java/org/opensearch/common/xcontent/support/filtering/FilterPathBasedFilter.java @@ -95,7 +95,7 @@ private TokenFilter evaluate(String name, FilterPath[] filters) { } if ((nextFilters != null) && (nextFilters.isEmpty() == false)) { - return new FilterPathBasedFilter(nextFilters.toArray(new FilterPath[nextFilters.size()]), inclusive); + return new FilterPathBasedFilter(nextFilters.toArray(new FilterPath[0]), inclusive); } } return NO_MATCHING; diff --git a/modules/parent-join/src/internalClusterTest/java/org/opensearch/join/query/ChildQuerySearchIT.java b/modules/parent-join/src/internalClusterTest/java/org/opensearch/join/query/ChildQuerySearchIT.java index d684f0bfebcfb..cacd7c3a23824 100644 --- a/modules/parent-join/src/internalClusterTest/java/org/opensearch/join/query/ChildQuerySearchIT.java +++ b/modules/parent-join/src/internalClusterTest/java/org/opensearch/join/query/ChildQuerySearchIT.java @@ -310,7 +310,7 @@ public void testHasParentFilter() throws Exception { } assertThat(parentToChildren.get(previousParentId).add(childId), is(true)); } - indexRandom(true, builders.toArray(new IndexRequestBuilder[builders.size()])); + indexRandom(true, builders.toArray(new IndexRequestBuilder[0])); assertThat(parentToChildren.isEmpty(), equalTo(false)); for (Map.Entry> parentToChildrenEntry : parentToChildren.entrySet()) { diff --git a/modules/rank-eval/src/main/java/org/opensearch/index/rankeval/TransportRankEvalAction.java b/modules/rank-eval/src/main/java/org/opensearch/index/rankeval/TransportRankEvalAction.java index 8cfde2d2b412e..4fce04e23119c 100644 --- a/modules/rank-eval/src/main/java/org/opensearch/index/rankeval/TransportRankEvalAction.java +++ b/modules/rank-eval/src/main/java/org/opensearch/index/rankeval/TransportRankEvalAction.java @@ -148,7 +148,7 @@ protected void doExecute(Task task, RankEvalRequest request, ActionListener indexingFailures, List search return; } RefreshRequest refresh = new RefreshRequest(); - refresh.indices(destinationIndices.toArray(new String[destinationIndices.size()])); + refresh.indices(destinationIndices.toArray(new String[0])); logger.debug("[{}]: refreshing", task.getId()); client.admin().indices().refresh(refresh, new ActionListener() { @Override diff --git a/modules/reindex/src/test/java/org/opensearch/index/reindex/DeleteByQueryBasicTests.java b/modules/reindex/src/test/java/org/opensearch/index/reindex/DeleteByQueryBasicTests.java index baf3c83bd0050..6874f96628761 100644 --- a/modules/reindex/src/test/java/org/opensearch/index/reindex/DeleteByQueryBasicTests.java +++ b/modules/reindex/src/test/java/org/opensearch/index/reindex/DeleteByQueryBasicTests.java @@ -362,7 +362,7 @@ public void testMultipleSources() throws Exception { int slices = randomSlices(1, 10); int expectedSlices = expectedSliceStatuses(slices, docs.keySet()); - String[] sourceIndexNames = docs.keySet().toArray(new String[docs.size()]); + String[] sourceIndexNames = docs.keySet().toArray(new String[0]); assertThat( deleteByQuery().source(sourceIndexNames).filter(QueryBuilders.matchAllQuery()).refresh(true).setSlices(slices).get(), diff --git a/modules/reindex/src/test/java/org/opensearch/index/reindex/ReindexBasicTests.java b/modules/reindex/src/test/java/org/opensearch/index/reindex/ReindexBasicTests.java index 0c660e5df9682..24adba16d0bad 100644 --- a/modules/reindex/src/test/java/org/opensearch/index/reindex/ReindexBasicTests.java +++ b/modules/reindex/src/test/java/org/opensearch/index/reindex/ReindexBasicTests.java @@ -161,7 +161,7 @@ public void testMultipleSources() throws Exception { int slices = randomSlices(1, 10); int expectedSlices = expectedSliceStatuses(slices, docs.keySet()); - String[] sourceIndexNames = docs.keySet().toArray(new String[docs.size()]); + String[] sourceIndexNames = docs.keySet().toArray(new String[0]); ReindexRequestBuilder request = reindex().source(sourceIndexNames).destination("dest").refresh(true).setSlices(slices); BulkByScrollResponse response = request.get(); diff --git a/modules/reindex/src/test/java/org/opensearch/index/reindex/UpdateByQueryBasicTests.java b/modules/reindex/src/test/java/org/opensearch/index/reindex/UpdateByQueryBasicTests.java index 4f48b99dccdd4..987fab954a8d0 100644 --- a/modules/reindex/src/test/java/org/opensearch/index/reindex/UpdateByQueryBasicTests.java +++ b/modules/reindex/src/test/java/org/opensearch/index/reindex/UpdateByQueryBasicTests.java @@ -151,7 +151,7 @@ public void testMultipleSources() throws Exception { int slices = randomSlices(1, 10); int expectedSlices = expectedSliceStatuses(slices, docs.keySet()); - String[] sourceIndexNames = docs.keySet().toArray(new String[docs.size()]); + String[] sourceIndexNames = docs.keySet().toArray(new String[0]); BulkByScrollResponse response = updateByQuery().source(sourceIndexNames).refresh(true).setSlices(slices).get(); assertThat(response, matcher().updated(allDocs.size()).slices(hasSize(expectedSlices))); diff --git a/plugins/mapper-annotated-text/src/main/java/org/opensearch/search/fetch/subphase/highlight/AnnotatedPassageFormatter.java b/plugins/mapper-annotated-text/src/main/java/org/opensearch/search/fetch/subphase/highlight/AnnotatedPassageFormatter.java index 8a94fea0ebbd4..48a41dd4afaf3 100644 --- a/plugins/mapper-annotated-text/src/main/java/org/opensearch/search/fetch/subphase/highlight/AnnotatedPassageFormatter.java +++ b/plugins/mapper-annotated-text/src/main/java/org/opensearch/search/fetch/subphase/highlight/AnnotatedPassageFormatter.java @@ -237,7 +237,7 @@ public AnnotationToken[] getIntersectingAnnotations(int start, int end) { // add 1 for the fieldvalue separator character fieldValueOffset += fieldValueAnnotations.textMinusMarkup.length() + 1; } - return intersectingAnnotations.toArray(new AnnotationToken[intersectingAnnotations.size()]); + return intersectingAnnotations.toArray(new AnnotationToken[0]); } private void append(StringBuilder dest, String content, int start, int end) { diff --git a/server/src/internalClusterTest/java/org/opensearch/action/IndicesRequestIT.java b/server/src/internalClusterTest/java/org/opensearch/action/IndicesRequestIT.java index 17366cf0d08fc..c2eb563145d43 100644 --- a/server/src/internalClusterTest/java/org/opensearch/action/IndicesRequestIT.java +++ b/server/src/internalClusterTest/java/org/opensearch/action/IndicesRequestIT.java @@ -708,7 +708,7 @@ private String[] randomUniqueIndices() { while (uniqueIndices.size() < count) { uniqueIndices.add(randomFrom(this.indices)); } - return uniqueIndices.toArray(new String[uniqueIndices.size()]); + return uniqueIndices.toArray(new String[0]); } private static void assertAllRequestsHaveBeenConsumed() { diff --git a/server/src/internalClusterTest/java/org/opensearch/action/admin/indices/get/GetIndexIT.java b/server/src/internalClusterTest/java/org/opensearch/action/admin/indices/get/GetIndexIT.java index ffc738ac98de5..483571f953b5e 100644 --- a/server/src/internalClusterTest/java/org/opensearch/action/admin/indices/get/GetIndexIT.java +++ b/server/src/internalClusterTest/java/org/opensearch/action/admin/indices/get/GetIndexIT.java @@ -163,7 +163,7 @@ public void testSimpleMixedFeatures() { } GetIndexResponse response = runWithRandomFeatureMethod( client().admin().indices().prepareGetIndex().addIndices("idx"), - features.toArray(new Feature[features.size()]) + features.toArray(new Feature[0]) ); String[] indices = response.indices(); assertThat(indices, notNullValue()); @@ -194,7 +194,7 @@ public void testEmptyMixedFeatures() { } GetIndexResponse response = runWithRandomFeatureMethod( client().admin().indices().prepareGetIndex().addIndices("empty_idx"), - features.toArray(new Feature[features.size()]) + features.toArray(new Feature[0]) ); String[] indices = response.indices(); assertThat(indices, notNullValue()); diff --git a/server/src/internalClusterTest/java/org/opensearch/recovery/RelocationIT.java b/server/src/internalClusterTest/java/org/opensearch/recovery/RelocationIT.java index aa99155724661..73bc38be9c83a 100644 --- a/server/src/internalClusterTest/java/org/opensearch/recovery/RelocationIT.java +++ b/server/src/internalClusterTest/java/org/opensearch/recovery/RelocationIT.java @@ -589,7 +589,7 @@ public void testIndexSearchAndRelocateConcurrently() throws Exception { logger.info(" --> checking iteration {}", i); SearchResponse afterRelocation = client().prepareSearch().setSize(ids.size()).get(); assertNoFailures(afterRelocation); - assertSearchHits(afterRelocation, ids.toArray(new String[ids.size()])); + assertSearchHits(afterRelocation, ids.toArray(new String[0])); } stopped.set(true); for (Thread searchThread : searchThreads) { diff --git a/server/src/internalClusterTest/java/org/opensearch/search/aggregations/bucket/GeoDistanceIT.java b/server/src/internalClusterTest/java/org/opensearch/search/aggregations/bucket/GeoDistanceIT.java index 603a141abcaec..25eafc935be6e 100644 --- a/server/src/internalClusterTest/java/org/opensearch/search/aggregations/bucket/GeoDistanceIT.java +++ b/server/src/internalClusterTest/java/org/opensearch/search/aggregations/bucket/GeoDistanceIT.java @@ -147,7 +147,7 @@ public void setupSuiteScopeCluster() throws Exception { .setSource(jsonBuilder().startObject().field("value", i * 2).field("location", "52.0945, 5.116").endObject()) ); } - indexRandom(true, builders.toArray(new IndexRequestBuilder[builders.size()])); + indexRandom(true, builders.toArray(new IndexRequestBuilder[0])); ensureSearchable(); } diff --git a/server/src/internalClusterTest/java/org/opensearch/search/aggregations/bucket/LongTermsIT.java b/server/src/internalClusterTest/java/org/opensearch/search/aggregations/bucket/LongTermsIT.java index 87968bd2117c6..bd0e69ca315ec 100644 --- a/server/src/internalClusterTest/java/org/opensearch/search/aggregations/bucket/LongTermsIT.java +++ b/server/src/internalClusterTest/java/org/opensearch/search/aggregations/bucket/LongTermsIT.java @@ -176,7 +176,7 @@ public void setupSuiteScopeCluster() throws Exception { getMultiSortDocs(builders); - indexRandom(true, builders.toArray(new IndexRequestBuilder[builders.size()])); + indexRandom(true, builders.toArray(new IndexRequestBuilder[0])); ensureSearchable(); } diff --git a/server/src/internalClusterTest/java/org/opensearch/search/aggregations/pipeline/MaxBucketIT.java b/server/src/internalClusterTest/java/org/opensearch/search/aggregations/pipeline/MaxBucketIT.java index 22890620d6b15..0e62cfc6f8100 100644 --- a/server/src/internalClusterTest/java/org/opensearch/search/aggregations/pipeline/MaxBucketIT.java +++ b/server/src/internalClusterTest/java/org/opensearch/search/aggregations/pipeline/MaxBucketIT.java @@ -162,7 +162,7 @@ public void testDocCountTopLevel() throws Exception { assertThat(maxBucketValue, notNullValue()); assertThat(maxBucketValue.getName(), equalTo("max_bucket")); assertThat(maxBucketValue.value(), equalTo(maxValue)); - assertThat(maxBucketValue.keys(), equalTo(maxKeys.toArray(new String[maxKeys.size()]))); + assertThat(maxBucketValue.keys(), equalTo(maxKeys.toArray(new String[0]))); } public void testDocCountAsSubAgg() throws Exception { @@ -214,7 +214,7 @@ public void testDocCountAsSubAgg() throws Exception { assertThat(maxBucketValue, notNullValue()); assertThat(maxBucketValue.getName(), equalTo("max_bucket")); assertThat(maxBucketValue.value(), equalTo(maxValue)); - assertThat(maxBucketValue.keys(), equalTo(maxKeys.toArray(new String[maxKeys.size()]))); + assertThat(maxBucketValue.keys(), equalTo(maxKeys.toArray(new String[0]))); } } @@ -254,7 +254,7 @@ public void testMetricTopLevel() throws Exception { assertThat(maxBucketValue, notNullValue()); assertThat(maxBucketValue.getName(), equalTo("max_bucket")); assertThat(maxBucketValue.value(), equalTo(maxValue)); - assertThat(maxBucketValue.keys(), equalTo(maxKeys.toArray(new String[maxKeys.size()]))); + assertThat(maxBucketValue.keys(), equalTo(maxKeys.toArray(new String[0]))); } public void testMetricAsSubAgg() throws Exception { @@ -313,7 +313,7 @@ public void testMetricAsSubAgg() throws Exception { assertThat(maxBucketValue, notNullValue()); assertThat(maxBucketValue.getName(), equalTo("max_bucket")); assertThat(maxBucketValue.value(), equalTo(maxValue)); - assertThat(maxBucketValue.keys(), equalTo(maxKeys.toArray(new String[maxKeys.size()]))); + assertThat(maxBucketValue.keys(), equalTo(maxKeys.toArray(new String[0]))); } } @@ -362,7 +362,7 @@ public void testMetricAsSubAggOfSingleBucketAgg() throws Exception { assertThat(maxBucketValue, notNullValue()); assertThat(maxBucketValue.getName(), equalTo("max_bucket")); assertThat(maxBucketValue.value(), equalTo(maxValue)); - assertThat(maxBucketValue.keys(), equalTo(maxKeys.toArray(new String[maxKeys.size()]))); + assertThat(maxBucketValue.keys(), equalTo(maxKeys.toArray(new String[0]))); } public void testMetricAsSubAggWithInsertZeros() throws Exception { @@ -419,7 +419,7 @@ public void testMetricAsSubAggWithInsertZeros() throws Exception { assertThat(maxBucketValue, notNullValue()); assertThat(maxBucketValue.getName(), equalTo("max_bucket")); assertThat(maxBucketValue.value(), equalTo(maxValue)); - assertThat(maxBucketValue.keys(), equalTo(maxKeys.toArray(new String[maxKeys.size()]))); + assertThat(maxBucketValue.keys(), equalTo(maxKeys.toArray(new String[0]))); } } @@ -500,7 +500,7 @@ public void testNested() throws Exception { assertThat(maxBucketValue, notNullValue()); assertThat(maxBucketValue.getName(), equalTo("max_histo_bucket")); assertThat(maxBucketValue.value(), equalTo(maxHistoValue)); - assertThat(maxBucketValue.keys(), equalTo(maxHistoKeys.toArray(new String[maxHistoKeys.size()]))); + assertThat(maxBucketValue.keys(), equalTo(maxHistoKeys.toArray(new String[0]))); if (maxHistoValue > maxTermsValue) { maxTermsValue = maxHistoValue; maxTermsKeys = new ArrayList<>(); @@ -514,7 +514,7 @@ public void testNested() throws Exception { assertThat(maxBucketValue, notNullValue()); assertThat(maxBucketValue.getName(), equalTo("max_terms_bucket")); assertThat(maxBucketValue.value(), equalTo(maxTermsValue)); - assertThat(maxBucketValue.keys(), equalTo(maxTermsKeys.toArray(new String[maxTermsKeys.size()]))); + assertThat(maxBucketValue.keys(), equalTo(maxTermsKeys.toArray(new String[0]))); } /** diff --git a/server/src/internalClusterTest/java/org/opensearch/search/aggregations/pipeline/MinBucketIT.java b/server/src/internalClusterTest/java/org/opensearch/search/aggregations/pipeline/MinBucketIT.java index b3929943f0d02..5f7e5e5174254 100644 --- a/server/src/internalClusterTest/java/org/opensearch/search/aggregations/pipeline/MinBucketIT.java +++ b/server/src/internalClusterTest/java/org/opensearch/search/aggregations/pipeline/MinBucketIT.java @@ -148,7 +148,7 @@ public void testDocCountTopLevel() throws Exception { assertThat(minBucketValue, notNullValue()); assertThat(minBucketValue.getName(), equalTo("min_bucket")); assertThat(minBucketValue.value(), equalTo(minValue)); - assertThat(minBucketValue.keys(), equalTo(minKeys.toArray(new String[minKeys.size()]))); + assertThat(minBucketValue.keys(), equalTo(minKeys.toArray(new String[0]))); } public void testDocCountAsSubAgg() throws Exception { @@ -200,7 +200,7 @@ public void testDocCountAsSubAgg() throws Exception { assertThat(minBucketValue, notNullValue()); assertThat(minBucketValue.getName(), equalTo("min_bucket")); assertThat(minBucketValue.value(), equalTo(minValue)); - assertThat(minBucketValue.keys(), equalTo(minKeys.toArray(new String[minKeys.size()]))); + assertThat(minBucketValue.keys(), equalTo(minKeys.toArray(new String[0]))); } } @@ -240,7 +240,7 @@ public void testMetricTopLevel() throws Exception { assertThat(minBucketValue, notNullValue()); assertThat(minBucketValue.getName(), equalTo("min_bucket")); assertThat(minBucketValue.value(), equalTo(minValue)); - assertThat(minBucketValue.keys(), equalTo(minKeys.toArray(new String[minKeys.size()]))); + assertThat(minBucketValue.keys(), equalTo(minKeys.toArray(new String[0]))); } public void testMetricAsSubAgg() throws Exception { @@ -299,7 +299,7 @@ public void testMetricAsSubAgg() throws Exception { assertThat(minBucketValue, notNullValue()); assertThat(minBucketValue.getName(), equalTo("min_bucket")); assertThat(minBucketValue.value(), equalTo(minValue)); - assertThat(minBucketValue.keys(), equalTo(minKeys.toArray(new String[minKeys.size()]))); + assertThat(minBucketValue.keys(), equalTo(minKeys.toArray(new String[0]))); } } @@ -357,7 +357,7 @@ public void testMetricAsSubAggWithInsertZeros() throws Exception { assertThat(minBucketValue, notNullValue()); assertThat(minBucketValue.getName(), equalTo("min_bucket")); assertThat(minBucketValue.value(), equalTo(minValue)); - assertThat(minBucketValue.keys(), equalTo(minKeys.toArray(new String[minKeys.size()]))); + assertThat(minBucketValue.keys(), equalTo(minKeys.toArray(new String[0]))); } } @@ -438,7 +438,7 @@ public void testNested() throws Exception { assertThat(minBucketValue, notNullValue()); assertThat(minBucketValue.getName(), equalTo("min_histo_bucket")); assertThat(minBucketValue.value(), equalTo(minHistoValue)); - assertThat(minBucketValue.keys(), equalTo(minHistoKeys.toArray(new String[minHistoKeys.size()]))); + assertThat(minBucketValue.keys(), equalTo(minHistoKeys.toArray(new String[0]))); if (minHistoValue < minTermsValue) { minTermsValue = minHistoValue; minTermsKeys = new ArrayList<>(); @@ -452,6 +452,6 @@ public void testNested() throws Exception { assertThat(minBucketValue, notNullValue()); assertThat(minBucketValue.getName(), equalTo("min_terms_bucket")); assertThat(minBucketValue.value(), equalTo(minTermsValue)); - assertThat(minBucketValue.keys(), equalTo(minTermsKeys.toArray(new String[minTermsKeys.size()]))); + assertThat(minBucketValue.keys(), equalTo(minTermsKeys.toArray(new String[0]))); } } diff --git a/server/src/internalClusterTest/java/org/opensearch/search/basic/SearchWhileRelocatingIT.java b/server/src/internalClusterTest/java/org/opensearch/search/basic/SearchWhileRelocatingIT.java index c184d876dcb33..1f1384cc5f72d 100644 --- a/server/src/internalClusterTest/java/org/opensearch/search/basic/SearchWhileRelocatingIT.java +++ b/server/src/internalClusterTest/java/org/opensearch/search/basic/SearchWhileRelocatingIT.java @@ -85,7 +85,7 @@ private void testSearchAndRelocateConcurrently(final int numberOfReplicas) throw ) ); } - indexRandom(true, indexBuilders.toArray(new IndexRequestBuilder[indexBuilders.size()])); + indexRandom(true, indexBuilders.toArray(new IndexRequestBuilder[0])); assertHitCount(client().prepareSearch().get(), (numDocs)); final int numIters = scaledRandomIntBetween(5, 20); for (int i = 0; i < numIters; i++) { diff --git a/server/src/internalClusterTest/java/org/opensearch/search/morelikethis/MoreLikeThisIT.java b/server/src/internalClusterTest/java/org/opensearch/search/morelikethis/MoreLikeThisIT.java index b3253b036bda6..b0695eaece781 100644 --- a/server/src/internalClusterTest/java/org/opensearch/search/morelikethis/MoreLikeThisIT.java +++ b/server/src/internalClusterTest/java/org/opensearch/search/morelikethis/MoreLikeThisIT.java @@ -767,7 +767,7 @@ public void testMoreLikeThisUnlike() throws ExecutionException, InterruptedExcep List docs = new ArrayList<>(numFields); for (int i = 0; i < numFields; i++) { docs.add(new Item("test", i + "")); - mltQuery = moreLikeThisQuery(null, new Item[] { new Item("test", doc) }).unlike(docs.toArray(new Item[docs.size()])) + mltQuery = moreLikeThisQuery(null, new Item[] { new Item("test", doc) }).unlike(docs.toArray(new Item[0])) .minTermFreq(0) .minDocFreq(0) .maxQueryTerms(100) diff --git a/server/src/internalClusterTest/java/org/opensearch/snapshots/SharedClusterSnapshotRestoreIT.java b/server/src/internalClusterTest/java/org/opensearch/snapshots/SharedClusterSnapshotRestoreIT.java index ee9e162a34f5c..78cdfa88cea33 100644 --- a/server/src/internalClusterTest/java/org/opensearch/snapshots/SharedClusterSnapshotRestoreIT.java +++ b/server/src/internalClusterTest/java/org/opensearch/snapshots/SharedClusterSnapshotRestoreIT.java @@ -149,7 +149,7 @@ public void testBasicWorkFlow() throws Exception { } } if (!indicesToFlush.isEmpty()) { - String[] indices = indicesToFlush.toArray(new String[indicesToFlush.size()]); + String[] indices = indicesToFlush.toArray(new String[0]); logger.info("--> starting asynchronous flush for indices {}", Arrays.toString(indices)); flushResponseFuture = client().admin().indices().prepareFlush(indices).execute(); } @@ -1804,7 +1804,7 @@ public void testRestoreSnapshotWithCorruptedIndexMetadata() throws Exception { assertThat(snapshotInfos.get(0).state(), equalTo(SnapshotState.SUCCESS)); assertThat(snapshotInfos.get(0).snapshotId().getName(), equalTo("test-snap")); - assertAcked(client().admin().indices().prepareDelete(nbDocsPerIndex.keySet().toArray(new String[nbDocsPerIndex.size()]))); + assertAcked(client().admin().indices().prepareDelete(nbDocsPerIndex.keySet().toArray(new String[0]))); Predicate isRestorableIndex = index -> corruptedIndex.getName().equals(index) == false; diff --git a/server/src/main/java/org/apache/lucene/search/uhighlight/CustomFieldHighlighter.java b/server/src/main/java/org/apache/lucene/search/uhighlight/CustomFieldHighlighter.java index 477f1a7d2f9ba..d1748d7f80995 100644 --- a/server/src/main/java/org/apache/lucene/search/uhighlight/CustomFieldHighlighter.java +++ b/server/src/main/java/org/apache/lucene/search/uhighlight/CustomFieldHighlighter.java @@ -163,7 +163,7 @@ protected Passage[] highlightOffsetsEnums(OffsetsEnum off) throws IOException { } while (off.nextPosition()); maybeAddPassage(passageQueue, passageScorer, passage, contentLength); - Passage[] passages = passageQueue.toArray(new Passage[passageQueue.size()]); + Passage[] passages = passageQueue.toArray(new Passage[0]); // sort in ascending order Arrays.sort(passages, Comparator.comparingInt(Passage::getStartOffset)); return passages; diff --git a/server/src/main/java/org/opensearch/action/admin/cluster/remotestore/restore/RestoreRemoteStoreRequest.java b/server/src/main/java/org/opensearch/action/admin/cluster/remotestore/restore/RestoreRemoteStoreRequest.java index a77477f24aa9f..1735827d259db 100644 --- a/server/src/main/java/org/opensearch/action/admin/cluster/remotestore/restore/RestoreRemoteStoreRequest.java +++ b/server/src/main/java/org/opensearch/action/admin/cluster/remotestore/restore/RestoreRemoteStoreRequest.java @@ -86,7 +86,7 @@ public RestoreRemoteStoreRequest indices(String... indices) { * @return this request */ public RestoreRemoteStoreRequest indices(List indices) { - this.indices = indices.toArray(new String[indices.size()]); + this.indices = indices.toArray(new String[0]); return this; } diff --git a/server/src/main/java/org/opensearch/action/admin/cluster/snapshots/create/CreateSnapshotRequest.java b/server/src/main/java/org/opensearch/action/admin/cluster/snapshots/create/CreateSnapshotRequest.java index cb64718ed5843..42bfa5dd0da83 100644 --- a/server/src/main/java/org/opensearch/action/admin/cluster/snapshots/create/CreateSnapshotRequest.java +++ b/server/src/main/java/org/opensearch/action/admin/cluster/snapshots/create/CreateSnapshotRequest.java @@ -253,7 +253,7 @@ public CreateSnapshotRequest indices(String... indices) { * @return this request */ public CreateSnapshotRequest indices(List indices) { - this.indices = indices.toArray(new String[indices.size()]); + this.indices = indices.toArray(new String[0]); return this; } diff --git a/server/src/main/java/org/opensearch/action/admin/cluster/snapshots/restore/RestoreSnapshotRequest.java b/server/src/main/java/org/opensearch/action/admin/cluster/snapshots/restore/RestoreSnapshotRequest.java index 4f998b3484642..b019bc9eff476 100644 --- a/server/src/main/java/org/opensearch/action/admin/cluster/snapshots/restore/RestoreSnapshotRequest.java +++ b/server/src/main/java/org/opensearch/action/admin/cluster/snapshots/restore/RestoreSnapshotRequest.java @@ -262,7 +262,7 @@ public RestoreSnapshotRequest indices(String... indices) { * @return this request */ public RestoreSnapshotRequest indices(List indices) { - this.indices = indices.toArray(new String[indices.size()]); + this.indices = indices.toArray(new String[0]); return this; } @@ -392,7 +392,7 @@ public RestoreSnapshotRequest ignoreIndexSettings(String... ignoreIndexSettings) * Sets the list of index settings and index settings groups that shouldn't be restored from snapshot */ public RestoreSnapshotRequest ignoreIndexSettings(List ignoreIndexSettings) { - this.ignoreIndexSettings = ignoreIndexSettings.toArray(new String[ignoreIndexSettings.size()]); + this.ignoreIndexSettings = ignoreIndexSettings.toArray(new String[0]); return this; } diff --git a/server/src/main/java/org/opensearch/action/admin/cluster/stats/TransportClusterStatsAction.java b/server/src/main/java/org/opensearch/action/admin/cluster/stats/TransportClusterStatsAction.java index 384eb7a0b86bb..1efd7d8192019 100644 --- a/server/src/main/java/org/opensearch/action/admin/cluster/stats/TransportClusterStatsAction.java +++ b/server/src/main/java/org/opensearch/action/admin/cluster/stats/TransportClusterStatsAction.java @@ -202,13 +202,7 @@ protected ClusterStatsNodeResponse nodeOperation(ClusterStatsNodeRequest nodeReq clusterStatus = new ClusterStateHealth(clusterService.state()).getStatus(); } - return new ClusterStatsNodeResponse( - nodeInfo.getNode(), - clusterStatus, - nodeInfo, - nodeStats, - shardsStats.toArray(new ShardStats[shardsStats.size()]) - ); + return new ClusterStatsNodeResponse(nodeInfo.getNode(), clusterStatus, nodeInfo, nodeStats, shardsStats.toArray(new ShardStats[0])); } diff --git a/server/src/main/java/org/opensearch/action/admin/indices/alias/TransportIndicesAliasesAction.java b/server/src/main/java/org/opensearch/action/admin/indices/alias/TransportIndicesAliasesAction.java index 3e453b42c3d7c..0ab9faa94090a 100644 --- a/server/src/main/java/org/opensearch/action/admin/indices/alias/TransportIndicesAliasesAction.java +++ b/server/src/main/java/org/opensearch/action/admin/indices/alias/TransportIndicesAliasesAction.java @@ -122,7 +122,7 @@ protected ClusterBlockException checkBlock(IndicesAliasesRequest request, Cluste for (IndicesAliasesRequest.AliasActions aliasAction : request.aliasActions()) { Collections.addAll(indices, aliasAction.indices()); } - return state.blocks().indicesBlockedException(ClusterBlockLevel.METADATA_WRITE, indices.toArray(new String[indices.size()])); + return state.blocks().indicesBlockedException(ClusterBlockLevel.METADATA_WRITE, indices.toArray(new String[0])); } @Override @@ -195,7 +195,7 @@ protected void clusterManagerOperation( } } if (finalActions.isEmpty() && false == actions.isEmpty()) { - throw new AliasesNotFoundException(aliases.toArray(new String[aliases.size()])); + throw new AliasesNotFoundException(aliases.toArray(new String[0])); } request.aliasActions().clear(); IndicesAliasesClusterStateUpdateRequest updateRequest = new IndicesAliasesClusterStateUpdateRequest(unmodifiableList(finalActions)) @@ -227,7 +227,7 @@ private static String[] concreteAliases(IndicesAliasesRequest.AliasActions actio finalAliases.add(aliasMeta.alias()); } } - return finalAliases.toArray(new String[finalAliases.size()]); + return finalAliases.toArray(new String[0]); } else { // for ADD and REMOVE_INDEX we just return the current aliases return action.aliases(); diff --git a/server/src/main/java/org/opensearch/action/admin/indices/delete/TransportDeleteIndexAction.java b/server/src/main/java/org/opensearch/action/admin/indices/delete/TransportDeleteIndexAction.java index a3d14846338e7..bcf2f6f534d74 100644 --- a/server/src/main/java/org/opensearch/action/admin/indices/delete/TransportDeleteIndexAction.java +++ b/server/src/main/java/org/opensearch/action/admin/indices/delete/TransportDeleteIndexAction.java @@ -128,7 +128,7 @@ protected void clusterManagerOperation( DeleteIndexClusterStateUpdateRequest deleteRequest = new DeleteIndexClusterStateUpdateRequest().ackTimeout(request.timeout()) .masterNodeTimeout(request.clusterManagerNodeTimeout()) - .indices(concreteIndices.toArray(new Index[concreteIndices.size()])); + .indices(concreteIndices.toArray(new Index[0])); deleteIndexService.deleteIndices(deleteRequest, new ActionListener() { diff --git a/server/src/main/java/org/opensearch/action/admin/indices/segments/IndexSegments.java b/server/src/main/java/org/opensearch/action/admin/indices/segments/IndexSegments.java index 88973ce094d8b..7249bc5e9d3ba 100644 --- a/server/src/main/java/org/opensearch/action/admin/indices/segments/IndexSegments.java +++ b/server/src/main/java/org/opensearch/action/admin/indices/segments/IndexSegments.java @@ -65,10 +65,7 @@ public class IndexSegments implements Iterable { for (Map.Entry> entry : tmpIndexShards.entrySet()) { indexShards.put( entry.getKey(), - new IndexShardSegments( - entry.getValue().get(0).getShardRouting().shardId(), - entry.getValue().toArray(new ShardSegments[entry.getValue().size()]) - ) + new IndexShardSegments(entry.getValue().get(0).getShardRouting().shardId(), entry.getValue().toArray(new ShardSegments[0])) ); } } diff --git a/server/src/main/java/org/opensearch/action/admin/indices/segments/IndicesSegmentResponse.java b/server/src/main/java/org/opensearch/action/admin/indices/segments/IndicesSegmentResponse.java index e21616657502a..f2fef57c64a25 100644 --- a/server/src/main/java/org/opensearch/action/admin/indices/segments/IndicesSegmentResponse.java +++ b/server/src/main/java/org/opensearch/action/admin/indices/segments/IndicesSegmentResponse.java @@ -97,7 +97,7 @@ public Map getIndices() { shards.add(shard); } } - indicesSegments.put(indexName, new IndexSegments(indexName, shards.toArray(new ShardSegments[shards.size()]))); + indicesSegments.put(indexName, new IndexSegments(indexName, shards.toArray(new ShardSegments[0]))); } this.indicesSegments = indicesSegments; return indicesSegments; diff --git a/server/src/main/java/org/opensearch/action/admin/indices/segments/PitSegmentsRequest.java b/server/src/main/java/org/opensearch/action/admin/indices/segments/PitSegmentsRequest.java index de0d390cddc4a..6e943cd9e5e7b 100644 --- a/server/src/main/java/org/opensearch/action/admin/indices/segments/PitSegmentsRequest.java +++ b/server/src/main/java/org/opensearch/action/admin/indices/segments/PitSegmentsRequest.java @@ -64,7 +64,7 @@ public void setVerbose(boolean v) { @Override public void writeTo(StreamOutput out) throws IOException { super.writeTo(out); - out.writeStringArrayNullable((pitIds == null) ? null : pitIds.toArray(new String[pitIds.size()])); + out.writeStringArrayNullable((pitIds == null) ? null : pitIds.toArray(new String[0])); out.writeBoolean(verbose); } diff --git a/server/src/main/java/org/opensearch/action/admin/indices/segments/TransportIndicesSegmentsAction.java b/server/src/main/java/org/opensearch/action/admin/indices/segments/TransportIndicesSegmentsAction.java index eb3d64188a6e7..163bd745cf029 100644 --- a/server/src/main/java/org/opensearch/action/admin/indices/segments/TransportIndicesSegmentsAction.java +++ b/server/src/main/java/org/opensearch/action/admin/indices/segments/TransportIndicesSegmentsAction.java @@ -119,7 +119,7 @@ protected IndicesSegmentResponse newResponse( ClusterState clusterState ) { return new IndicesSegmentResponse( - results.toArray(new ShardSegments[results.size()]), + results.toArray(new ShardSegments[0]), totalShards, successfulShards, failedShards, diff --git a/server/src/main/java/org/opensearch/action/admin/indices/segments/TransportPitSegmentsAction.java b/server/src/main/java/org/opensearch/action/admin/indices/segments/TransportPitSegmentsAction.java index 9d4ece74a7270..09a685a2158f4 100644 --- a/server/src/main/java/org/opensearch/action/admin/indices/segments/TransportPitSegmentsAction.java +++ b/server/src/main/java/org/opensearch/action/admin/indices/segments/TransportPitSegmentsAction.java @@ -167,7 +167,7 @@ protected IndicesSegmentResponse newResponse( ClusterState clusterState ) { return new IndicesSegmentResponse( - results.toArray(new ShardSegments[results.size()]), + results.toArray(new ShardSegments[0]), totalShards, successfulShards, failedShards, diff --git a/server/src/main/java/org/opensearch/action/admin/indices/stats/CommonStatsFlags.java b/server/src/main/java/org/opensearch/action/admin/indices/stats/CommonStatsFlags.java index 62ebbba500a6a..6b819ac34cef9 100644 --- a/server/src/main/java/org/opensearch/action/admin/indices/stats/CommonStatsFlags.java +++ b/server/src/main/java/org/opensearch/action/admin/indices/stats/CommonStatsFlags.java @@ -146,7 +146,7 @@ public boolean anySet() { } public Flag[] getFlags() { - return flags.toArray(new Flag[flags.size()]); + return flags.toArray(new Flag[0]); } /** diff --git a/server/src/main/java/org/opensearch/action/admin/indices/stats/IndexStats.java b/server/src/main/java/org/opensearch/action/admin/indices/stats/IndexStats.java index c98d46a0caed6..1c57ca39576b0 100644 --- a/server/src/main/java/org/opensearch/action/admin/indices/stats/IndexStats.java +++ b/server/src/main/java/org/opensearch/action/admin/indices/stats/IndexStats.java @@ -88,10 +88,7 @@ public Map getIndexShards() { for (Map.Entry> entry : tmpIndexShards.entrySet()) { indexShards.put( entry.getKey(), - new IndexShardStats( - entry.getValue().get(0).getShardRouting().shardId(), - entry.getValue().toArray(new ShardStats[entry.getValue().size()]) - ) + new IndexShardStats(entry.getValue().get(0).getShardRouting().shardId(), entry.getValue().toArray(new ShardStats[0])) ); } return indexShards; @@ -153,7 +150,7 @@ public IndexStatsBuilder add(ShardStats shardStats) { } public IndexStats build() { - return new IndexStats(indexName, uuid, shards.toArray(new ShardStats[shards.size()])); + return new IndexStats(indexName, uuid, shards.toArray(new ShardStats[0])); } } } diff --git a/server/src/main/java/org/opensearch/action/admin/indices/stats/TransportIndicesStatsAction.java b/server/src/main/java/org/opensearch/action/admin/indices/stats/TransportIndicesStatsAction.java index 39e0338aac5f6..429c6630c6c06 100644 --- a/server/src/main/java/org/opensearch/action/admin/indices/stats/TransportIndicesStatsAction.java +++ b/server/src/main/java/org/opensearch/action/admin/indices/stats/TransportIndicesStatsAction.java @@ -120,13 +120,7 @@ protected IndicesStatsResponse newResponse( List shardFailures, ClusterState clusterState ) { - return new IndicesStatsResponse( - responses.toArray(new ShardStats[responses.size()]), - totalShards, - successfulShards, - failedShards, - shardFailures - ); + return new IndicesStatsResponse(responses.toArray(new ShardStats[0]), totalShards, successfulShards, failedShards, shardFailures); } @Override diff --git a/server/src/main/java/org/opensearch/action/admin/indices/template/put/PutIndexTemplateRequest.java b/server/src/main/java/org/opensearch/action/admin/indices/template/put/PutIndexTemplateRequest.java index 3cfb1a3ed0637..d5cdfe41045dd 100644 --- a/server/src/main/java/org/opensearch/action/admin/indices/template/put/PutIndexTemplateRequest.java +++ b/server/src/main/java/org/opensearch/action/admin/indices/template/put/PutIndexTemplateRequest.java @@ -476,7 +476,7 @@ public PutIndexTemplateRequest alias(Alias alias) { @Override public String[] indices() { - return indexPatterns.toArray(new String[indexPatterns.size()]); + return indexPatterns.toArray(new String[0]); } @Override diff --git a/server/src/main/java/org/opensearch/action/admin/indices/upgrade/get/IndexUpgradeStatus.java b/server/src/main/java/org/opensearch/action/admin/indices/upgrade/get/IndexUpgradeStatus.java index 2cff1f04d3fd2..4513a321e2a51 100644 --- a/server/src/main/java/org/opensearch/action/admin/indices/upgrade/get/IndexUpgradeStatus.java +++ b/server/src/main/java/org/opensearch/action/admin/indices/upgrade/get/IndexUpgradeStatus.java @@ -67,7 +67,7 @@ public class IndexUpgradeStatus implements Iterable { entry.getKey(), new IndexShardUpgradeStatus( entry.getValue().get(0).getShardRouting().shardId(), - entry.getValue().toArray(new ShardUpgradeStatus[entry.getValue().size()]) + entry.getValue().toArray(new ShardUpgradeStatus[0]) ) ); } diff --git a/server/src/main/java/org/opensearch/action/admin/indices/upgrade/get/TransportUpgradeStatusAction.java b/server/src/main/java/org/opensearch/action/admin/indices/upgrade/get/TransportUpgradeStatusAction.java index b2f6cd62b1be7..c81d86660ae50 100644 --- a/server/src/main/java/org/opensearch/action/admin/indices/upgrade/get/TransportUpgradeStatusAction.java +++ b/server/src/main/java/org/opensearch/action/admin/indices/upgrade/get/TransportUpgradeStatusAction.java @@ -121,7 +121,7 @@ protected UpgradeStatusResponse newResponse( ClusterState clusterState ) { return new UpgradeStatusResponse( - responses.toArray(new ShardUpgradeStatus[responses.size()]), + responses.toArray(new ShardUpgradeStatus[0]), totalShards, successfulShards, failedShards, diff --git a/server/src/main/java/org/opensearch/action/admin/indices/upgrade/get/UpgradeStatusResponse.java b/server/src/main/java/org/opensearch/action/admin/indices/upgrade/get/UpgradeStatusResponse.java index 311f86b0fe3b9..0891597b3f2b5 100644 --- a/server/src/main/java/org/opensearch/action/admin/indices/upgrade/get/UpgradeStatusResponse.java +++ b/server/src/main/java/org/opensearch/action/admin/indices/upgrade/get/UpgradeStatusResponse.java @@ -94,7 +94,7 @@ public Map getIndices() { shards.add(shard); } } - indicesUpgradeStats.put(indexName, new IndexUpgradeStatus(indexName, shards.toArray(new ShardUpgradeStatus[shards.size()]))); + indicesUpgradeStats.put(indexName, new IndexUpgradeStatus(indexName, shards.toArray(new ShardUpgradeStatus[0]))); } this.indicesUpgradeStatus = indicesUpgradeStats; return indicesUpgradeStats; diff --git a/server/src/main/java/org/opensearch/action/bulk/BulkResponse.java b/server/src/main/java/org/opensearch/action/bulk/BulkResponse.java index 6dec144f2ccf0..3489f8a90d6e4 100644 --- a/server/src/main/java/org/opensearch/action/bulk/BulkResponse.java +++ b/server/src/main/java/org/opensearch/action/bulk/BulkResponse.java @@ -214,6 +214,6 @@ public static BulkResponse fromXContent(XContentParser parser) throws IOExceptio throwUnknownToken(token, parser.getTokenLocation()); } } - return new BulkResponse(items.toArray(new BulkItemResponse[items.size()]), took, ingestTook); + return new BulkResponse(items.toArray(new BulkItemResponse[0]), took, ingestTook); } } diff --git a/server/src/main/java/org/opensearch/action/bulk/TransportBulkAction.java b/server/src/main/java/org/opensearch/action/bulk/TransportBulkAction.java index 9e23213c02ab6..862d63aeedf53 100644 --- a/server/src/main/java/org/opensearch/action/bulk/TransportBulkAction.java +++ b/server/src/main/java/org/opensearch/action/bulk/TransportBulkAction.java @@ -609,7 +609,7 @@ protected void doRun() { BulkShardRequest bulkShardRequest = new BulkShardRequest( shardId, bulkRequest.getRefreshPolicy(), - requests.toArray(new BulkItemRequest[requests.size()]) + requests.toArray(new BulkItemRequest[0]) ); bulkShardRequest.waitForActiveShards(bulkRequest.waitForActiveShards()); bulkShardRequest.timeout(bulkRequest.timeout()); diff --git a/server/src/main/java/org/opensearch/action/get/MultiGetRequest.java b/server/src/main/java/org/opensearch/action/get/MultiGetRequest.java index 91f506dafafe1..87881071d4ec8 100644 --- a/server/src/main/java/org/opensearch/action/get/MultiGetRequest.java +++ b/server/src/main/java/org/opensearch/action/get/MultiGetRequest.java @@ -509,15 +509,15 @@ private static void parseDocuments( fetchSourceContext = new FetchSourceContext( fetchSourceContext.fetchSource(), - includes == null ? Strings.EMPTY_ARRAY : includes.toArray(new String[includes.size()]), - excludes == null ? Strings.EMPTY_ARRAY : excludes.toArray(new String[excludes.size()]) + includes == null ? Strings.EMPTY_ARRAY : includes.toArray(new String[0]), + excludes == null ? Strings.EMPTY_ARRAY : excludes.toArray(new String[0]) ); } } } String[] aFields; if (storedFields != null) { - aFields = storedFields.toArray(new String[storedFields.size()]); + aFields = storedFields.toArray(new String[0]); } else { aFields = defaultFields; } diff --git a/server/src/main/java/org/opensearch/action/search/ClearScrollRequest.java b/server/src/main/java/org/opensearch/action/search/ClearScrollRequest.java index 4105f5ece5221..ebc110302143d 100644 --- a/server/src/main/java/org/opensearch/action/search/ClearScrollRequest.java +++ b/server/src/main/java/org/opensearch/action/search/ClearScrollRequest.java @@ -101,7 +101,7 @@ public void writeTo(StreamOutput out) throws IOException { if (scrollIds == null) { out.writeVInt(0); } else { - out.writeStringArray(scrollIds.toArray(new String[scrollIds.size()])); + out.writeStringArray(scrollIds.toArray(new String[0])); } } diff --git a/server/src/main/java/org/opensearch/action/search/DeletePitRequest.java b/server/src/main/java/org/opensearch/action/search/DeletePitRequest.java index 926e9c19a33f5..da4f2a5f77003 100644 --- a/server/src/main/java/org/opensearch/action/search/DeletePitRequest.java +++ b/server/src/main/java/org/opensearch/action/search/DeletePitRequest.java @@ -74,7 +74,7 @@ public void writeTo(StreamOutput out) throws IOException { if (pitIds == null) { out.writeVInt(0); } else { - out.writeStringArray(pitIds.toArray(new String[pitIds.size()])); + out.writeStringArray(pitIds.toArray(new String[0])); } } diff --git a/server/src/main/java/org/opensearch/action/search/PitService.java b/server/src/main/java/org/opensearch/action/search/PitService.java index f42d84477f9a3..079f91db383d1 100644 --- a/server/src/main/java/org/opensearch/action/search/PitService.java +++ b/server/src/main/java/org/opensearch/action/search/PitService.java @@ -176,7 +176,7 @@ public void getAllPits(ActionListener getAllPitsListener DiscoveryNode node = cursor.value; nodes.add(node); } - DiscoveryNode[] disNodesArr = nodes.toArray(new DiscoveryNode[nodes.size()]); + DiscoveryNode[] disNodesArr = nodes.toArray(new DiscoveryNode[0]); GetAllPitNodesRequest getAllPitNodesRequest = new GetAllPitNodesRequest(disNodesArr); transportService.sendRequest( transportService.getLocalNode(), diff --git a/server/src/main/java/org/opensearch/action/search/SearchScrollAsyncAction.java b/server/src/main/java/org/opensearch/action/search/SearchScrollAsyncAction.java index ffa944ae62763..0b477624b15cc 100644 --- a/server/src/main/java/org/opensearch/action/search/SearchScrollAsyncAction.java +++ b/server/src/main/java/org/opensearch/action/search/SearchScrollAsyncAction.java @@ -243,7 +243,7 @@ synchronized ShardSearchFailure[] buildShardFailures() { // pkg private for test if (shardFailures.isEmpty()) { return ShardSearchFailure.EMPTY_ARRAY; } - return shardFailures.toArray(new ShardSearchFailure[shardFailures.size()]); + return shardFailures.toArray(new ShardSearchFailure[0]); } // we do our best to return the shard failures, but its ok if its not fully concurrently safe diff --git a/server/src/main/java/org/opensearch/action/support/ActionFilters.java b/server/src/main/java/org/opensearch/action/support/ActionFilters.java index 95cafbea4d7c1..cad828e08a25e 100644 --- a/server/src/main/java/org/opensearch/action/support/ActionFilters.java +++ b/server/src/main/java/org/opensearch/action/support/ActionFilters.java @@ -46,7 +46,7 @@ public class ActionFilters { private final ActionFilter[] filters; public ActionFilters(Set actionFilters) { - this.filters = actionFilters.toArray(new ActionFilter[actionFilters.size()]); + this.filters = actionFilters.toArray(new ActionFilter[0]); Arrays.sort(filters, new Comparator() { @Override public int compare(ActionFilter o1, ActionFilter o2) { diff --git a/server/src/main/java/org/opensearch/action/support/broadcast/BroadcastResponse.java b/server/src/main/java/org/opensearch/action/support/broadcast/BroadcastResponse.java index 9d0973a5f7307..2135df4fdf726 100644 --- a/server/src/main/java/org/opensearch/action/support/broadcast/BroadcastResponse.java +++ b/server/src/main/java/org/opensearch/action/support/broadcast/BroadcastResponse.java @@ -114,7 +114,7 @@ public BroadcastResponse( if (shardFailures == null) { this.shardFailures = EMPTY; } else { - this.shardFailures = shardFailures.toArray(new DefaultShardOperationFailedException[shardFailures.size()]); + this.shardFailures = shardFailures.toArray(new DefaultShardOperationFailedException[0]); } } diff --git a/server/src/main/java/org/opensearch/action/support/replication/ReplicationResponse.java b/server/src/main/java/org/opensearch/action/support/replication/ReplicationResponse.java index 1dfa9e53c5fee..2b4504c94f594 100644 --- a/server/src/main/java/org/opensearch/action/support/replication/ReplicationResponse.java +++ b/server/src/main/java/org/opensearch/action/support/replication/ReplicationResponse.java @@ -222,7 +222,7 @@ public static ShardInfo fromXContent(XContentParser parser) throws IOException { } Failure[] failures = EMPTY; if (failuresList != null) { - failures = failuresList.toArray(new Failure[failuresList.size()]); + failures = failuresList.toArray(new Failure[0]); } return new ShardInfo(total, successful, failures); } diff --git a/server/src/main/java/org/opensearch/cluster/metadata/IndexNameExpressionResolver.java b/server/src/main/java/org/opensearch/cluster/metadata/IndexNameExpressionResolver.java index 596e0c42c6456..003b37fbf3777 100644 --- a/server/src/main/java/org/opensearch/cluster/metadata/IndexNameExpressionResolver.java +++ b/server/src/main/java/org/opensearch/cluster/metadata/IndexNameExpressionResolver.java @@ -355,7 +355,7 @@ Index[] concreteIndices(Context context, String... indexExpressions) { throw infe; } checkSystemIndexAccess(context, metadata, concreteIndices, indexExpressions); - return concreteIndices.toArray(new Index[concreteIndices.size()]); + return concreteIndices.toArray(new Index[0]); } private void checkSystemIndexAccess(Context context, Metadata metadata, Set concreteIndices, String[] originalPatterns) { @@ -598,7 +598,7 @@ public String[] indexAliases( if (aliases == null) { return null; } - return aliases.toArray(new String[aliases.size()]); + return aliases.toArray(new String[0]); } /** diff --git a/server/src/main/java/org/opensearch/cluster/routing/RoutingNodes.java b/server/src/main/java/org/opensearch/cluster/routing/RoutingNodes.java index 17267d5474738..118d2998bae67 100644 --- a/server/src/main/java/org/opensearch/cluster/routing/RoutingNodes.java +++ b/server/src/main/java/org/opensearch/cluster/routing/RoutingNodes.java @@ -1139,7 +1139,7 @@ public void shuffle() { */ public ShardRouting[] drain() { nodes.ensureMutable(); - ShardRouting[] mutableShardRoutings = unassigned.toArray(new ShardRouting[unassigned.size()]); + ShardRouting[] mutableShardRoutings = unassigned.toArray(new ShardRouting[0]); unassigned.clear(); primaries = 0; return mutableShardRoutings; @@ -1151,7 +1151,7 @@ public ShardRouting[] drain() { */ public ShardRouting[] drainIgnored() { nodes.ensureMutable(); - ShardRouting[] mutableShardRoutings = ignored.toArray(new ShardRouting[ignored.size()]); + ShardRouting[] mutableShardRoutings = ignored.toArray(new ShardRouting[0]); ignored.clear(); ignoredPrimaries = 0; return mutableShardRoutings; diff --git a/server/src/main/java/org/opensearch/cluster/routing/allocation/AllocationService.java b/server/src/main/java/org/opensearch/cluster/routing/allocation/AllocationService.java index 1c6e4732a2ab7..5169e63aeb9a5 100644 --- a/server/src/main/java/org/opensearch/cluster/routing/allocation/AllocationService.java +++ b/server/src/main/java/org/opensearch/cluster/routing/allocation/AllocationService.java @@ -345,7 +345,7 @@ public ClusterState adaptAutoExpandReplicas(ClusterState clusterState) { final Metadata.Builder metadataBuilder = Metadata.builder(clusterState.metadata()); for (Map.Entry> entry : autoExpandReplicaChanges.entrySet()) { final int numberOfReplicas = entry.getKey(); - final String[] indices = entry.getValue().toArray(new String[entry.getValue().size()]); + final String[] indices = entry.getValue().toArray(new String[0]); // we do *not* update the in sync allocation ids as they will be removed upon the first index // operation which make these copies stale routingTableBuilder.updateNumberOfReplicas(numberOfReplicas, indices); diff --git a/server/src/main/java/org/opensearch/cluster/routing/allocation/allocator/LocalShardsBalancer.java b/server/src/main/java/org/opensearch/cluster/routing/allocation/allocator/LocalShardsBalancer.java index 3c5e4013748af..8570a16fd690c 100644 --- a/server/src/main/java/org/opensearch/cluster/routing/allocation/allocator/LocalShardsBalancer.java +++ b/server/src/main/java/org/opensearch/cluster/routing/allocation/allocator/LocalShardsBalancer.java @@ -90,7 +90,7 @@ public LocalShardsBalancer( * Returns an array view on the nodes in the balancer. Nodes should not be removed from this list. */ private BalancedShardsAllocator.ModelNode[] nodesArray() { - return nodes.values().toArray(new BalancedShardsAllocator.ModelNode[nodes.size()]); + return nodes.values().toArray(new BalancedShardsAllocator.ModelNode[0]); } /** @@ -778,7 +778,7 @@ void allocateUnassigned() { .collect(Collectors.toList()); allUnassignedShards.removeAll(localUnassignedShards); allUnassignedShards.forEach(shard -> routingNodes.unassigned().add(shard)); - unassignedShards = localUnassignedShards.toArray(new ShardRouting[localUnassignedShards.size()]); + unassignedShards = localUnassignedShards.toArray(new ShardRouting[0]); } ShardRouting[] primary = unassignedShards; ShardRouting[] secondary = new ShardRouting[primary.length]; diff --git a/server/src/main/java/org/opensearch/common/Strings.java b/server/src/main/java/org/opensearch/common/Strings.java index cbf12f264ee30..68b22589de76e 100644 --- a/server/src/main/java/org/opensearch/common/Strings.java +++ b/server/src/main/java/org/opensearch/common/Strings.java @@ -423,7 +423,7 @@ public static String[] toStringArray(Collection collection) { if (collection == null) { return null; } - return collection.toArray(new String[collection.size()]); + return collection.toArray(new String[0]); } /** diff --git a/server/src/main/java/org/opensearch/common/blobstore/BlobPath.java b/server/src/main/java/org/opensearch/common/blobstore/BlobPath.java index d5242fd5e7347..c54536e9c46e2 100644 --- a/server/src/main/java/org/opensearch/common/blobstore/BlobPath.java +++ b/server/src/main/java/org/opensearch/common/blobstore/BlobPath.java @@ -68,7 +68,7 @@ public Iterator iterator() { } public String[] toArray() { - return paths.toArray(new String[paths.size()]); + return paths.toArray(new String[0]); } public BlobPath add(String path) { diff --git a/server/src/main/java/org/opensearch/common/bytes/BytesReference.java b/server/src/main/java/org/opensearch/common/bytes/BytesReference.java index 3e0623bf8d128..85dcf949d479e 100644 --- a/server/src/main/java/org/opensearch/common/bytes/BytesReference.java +++ b/server/src/main/java/org/opensearch/common/bytes/BytesReference.java @@ -91,7 +91,7 @@ static ByteBuffer[] toByteBuffers(BytesReference reference) { while ((r = byteRefIterator.next()) != null) { buffers.add(ByteBuffer.wrap(r.bytes, r.offset, r.length)); } - return buffers.toArray(new ByteBuffer[buffers.size()]); + return buffers.toArray(new ByteBuffer[0]); } catch (IOException e) { // this is really an error since we don't do IO in our bytesreferences diff --git a/server/src/main/java/org/opensearch/common/geo/GeoPolygonDecomposer.java b/server/src/main/java/org/opensearch/common/geo/GeoPolygonDecomposer.java index bf2192a28a299..797b252215d76 100644 --- a/server/src/main/java/org/opensearch/common/geo/GeoPolygonDecomposer.java +++ b/server/src/main/java/org/opensearch/common/geo/GeoPolygonDecomposer.java @@ -463,7 +463,7 @@ private static Edge[] edges(Edge[] edges, int numHoles, List> comp } } - return mainEdges.toArray(new Edge[mainEdges.size()]); + return mainEdges.toArray(new Edge[0]); } private static void compose(Edge[] edges, Edge[] holes, int numHoles, List collector) { diff --git a/server/src/main/java/org/opensearch/common/geo/builders/LineStringBuilder.java b/server/src/main/java/org/opensearch/common/geo/builders/LineStringBuilder.java index fc9548a4d9072..0f3d357269392 100644 --- a/server/src/main/java/org/opensearch/common/geo/builders/LineStringBuilder.java +++ b/server/src/main/java/org/opensearch/common/geo/builders/LineStringBuilder.java @@ -121,7 +121,7 @@ public int numDimensions() { @Override public JtsGeometry buildS4J() { - Coordinate[] coordinates = this.coordinates.toArray(new Coordinate[this.coordinates.size()]); + Coordinate[] coordinates = this.coordinates.toArray(new Coordinate[0]); Geometry geometry; if (wrapdateline) { ArrayList strings = decomposeS4J(FACTORY, coordinates, new ArrayList()); @@ -129,7 +129,7 @@ public JtsGeometry buildS4J() { if (strings.size() == 1) { geometry = strings.get(0); } else { - LineString[] linestrings = strings.toArray(new LineString[strings.size()]); + LineString[] linestrings = strings.toArray(new LineString[0]); geometry = FACTORY.createMultiLineString(linestrings); } diff --git a/server/src/main/java/org/opensearch/common/geo/builders/MultiLineStringBuilder.java b/server/src/main/java/org/opensearch/common/geo/builders/MultiLineStringBuilder.java index 64ca4aae326c9..53da2b9d87916 100644 --- a/server/src/main/java/org/opensearch/common/geo/builders/MultiLineStringBuilder.java +++ b/server/src/main/java/org/opensearch/common/geo/builders/MultiLineStringBuilder.java @@ -153,7 +153,7 @@ public JtsGeometry buildS4J() { if (parts.size() == 1) { geometry = parts.get(0); } else { - LineString[] lineStrings = parts.toArray(new LineString[parts.size()]); + LineString[] lineStrings = parts.toArray(new LineString[0]); geometry = FACTORY.createMultiLineString(lineStrings); } } else { diff --git a/server/src/main/java/org/opensearch/common/geo/builders/PolygonBuilder.java b/server/src/main/java/org/opensearch/common/geo/builders/PolygonBuilder.java index 0341d2a1af325..9bfb6cac3132e 100644 --- a/server/src/main/java/org/opensearch/common/geo/builders/PolygonBuilder.java +++ b/server/src/main/java/org/opensearch/common/geo/builders/PolygonBuilder.java @@ -308,7 +308,7 @@ protected static org.opensearch.geometry.LinearRing linearRing(List } protected static LinearRing linearRingS4J(GeometryFactory factory, List coordinates) { - return factory.createLinearRing(coordinates.toArray(new Coordinate[coordinates.size()])); + return factory.createLinearRing(coordinates.toArray(new Coordinate[0])); } @Override @@ -506,7 +506,7 @@ private static Edge[] edges(Edge[] edges, int numHoles, List> } } - return mainEdges.toArray(new Edge[mainEdges.size()]); + return mainEdges.toArray(new Edge[0]); } private static Coordinate[][][] compose(Edge[] edges, Edge[] holes, int numHoles) { diff --git a/server/src/main/java/org/opensearch/common/lucene/index/FilterableTermsEnum.java b/server/src/main/java/org/opensearch/common/lucene/index/FilterableTermsEnum.java index 61c9e9f54cb51..224c5b600c930 100644 --- a/server/src/main/java/org/opensearch/common/lucene/index/FilterableTermsEnum.java +++ b/server/src/main/java/org/opensearch/common/lucene/index/FilterableTermsEnum.java @@ -140,7 +140,7 @@ protected boolean match(int doc) { } enums.add(new Holder(termsEnum, bits)); } - this.enums = enums.toArray(new Holder[enums.size()]); + this.enums = enums.toArray(new Holder[0]); } @Override diff --git a/server/src/main/java/org/opensearch/common/lucene/search/XMoreLikeThis.java b/server/src/main/java/org/opensearch/common/lucene/search/XMoreLikeThis.java index 35aab81e94bc4..d7ffa2df943b7 100644 --- a/server/src/main/java/org/opensearch/common/lucene/search/XMoreLikeThis.java +++ b/server/src/main/java/org/opensearch/common/lucene/search/XMoreLikeThis.java @@ -619,7 +619,7 @@ public Query like(int docNum) throws IOException { if (fieldNames == null) { // gather list of valid fields from lucene Collection fields = FieldInfos.getIndexedFields(ir); - fieldNames = fields.toArray(new String[fields.size()]); + fieldNames = fields.toArray(new String[0]); } return createQuery(retrieveTerms(docNum)); diff --git a/server/src/main/java/org/opensearch/common/network/NetworkService.java b/server/src/main/java/org/opensearch/common/network/NetworkService.java index e50c71af4f483..0fb299ef66e70 100644 --- a/server/src/main/java/org/opensearch/common/network/NetworkService.java +++ b/server/src/main/java/org/opensearch/common/network/NetworkService.java @@ -205,7 +205,7 @@ public InetAddress resolvePublishHostAddresses(String publishHosts[]) throws IOE // 1. single wildcard address, probably set by network.host: expand to all interface addresses. if (addresses.length == 1 && addresses[0].isAnyLocalAddress()) { HashSet all = new HashSet<>(Arrays.asList(NetworkUtils.getAllAddresses())); - addresses = all.toArray(new InetAddress[all.size()]); + addresses = all.toArray(new InetAddress[0]); } // 2. try to deal with some (mis)configuration @@ -248,7 +248,7 @@ private InetAddress[] resolveInetAddresses(String hosts[]) throws IOException { for (String host : hosts) { set.addAll(Arrays.asList(resolveInternal(host))); } - return set.toArray(new InetAddress[set.size()]); + return set.toArray(new InetAddress[0]); } /** resolves a single host specification */ diff --git a/server/src/main/java/org/opensearch/common/network/NetworkUtils.java b/server/src/main/java/org/opensearch/common/network/NetworkUtils.java index 8660b876fa187..8816260c5d26f 100644 --- a/server/src/main/java/org/opensearch/common/network/NetworkUtils.java +++ b/server/src/main/java/org/opensearch/common/network/NetworkUtils.java @@ -239,7 +239,7 @@ static InetAddress[] getAddressesForInterface(String name) throws SocketExceptio if (list.isEmpty()) { throw new IllegalArgumentException("Interface '" + name + "' has no internet addresses"); } - return list.toArray(new InetAddress[list.size()]); + return list.toArray(new InetAddress[0]); } /** Returns only the IPV4 addresses in {@code addresses} */ @@ -253,7 +253,7 @@ static InetAddress[] filterIPV4(InetAddress addresses[]) { if (list.isEmpty()) { throw new IllegalArgumentException("No ipv4 addresses found in " + Arrays.toString(addresses)); } - return list.toArray(new InetAddress[list.size()]); + return list.toArray(new InetAddress[0]); } /** Returns only the IPV6 addresses in {@code addresses} */ @@ -267,6 +267,6 @@ static InetAddress[] filterIPV6(InetAddress addresses[]) { if (list.isEmpty()) { throw new IllegalArgumentException("No ipv6 addresses found in " + Arrays.toString(addresses)); } - return list.toArray(new InetAddress[list.size()]); + return list.toArray(new InetAddress[0]); } } diff --git a/server/src/main/java/org/opensearch/common/settings/Settings.java b/server/src/main/java/org/opensearch/common/settings/Settings.java index 725817ef22c6c..5e15e1693c017 100644 --- a/server/src/main/java/org/opensearch/common/settings/Settings.java +++ b/server/src/main/java/org/opensearch/common/settings/Settings.java @@ -1040,7 +1040,7 @@ public Builder put(Settings settings, boolean copySecureSettings) { } private void processLegacyLists(Map map) { - String[] array = map.keySet().toArray(new String[map.size()]); + String[] array = map.keySet().toArray(new String[0]); for (String key : array) { if (key.endsWith(".0")) { // let's only look at the head of the list and convert in order starting there. int counter = 0; diff --git a/server/src/main/java/org/opensearch/common/settings/SettingsFilter.java b/server/src/main/java/org/opensearch/common/settings/SettingsFilter.java index 9914674068e66..b12360a75c878 100644 --- a/server/src/main/java/org/opensearch/common/settings/SettingsFilter.java +++ b/server/src/main/java/org/opensearch/common/settings/SettingsFilter.java @@ -117,7 +117,7 @@ private static Settings filterSettings(Iterable patterns, Settings setti } } if (!simpleMatchPatternList.isEmpty()) { - String[] simpleMatchPatterns = simpleMatchPatternList.toArray(new String[simpleMatchPatternList.size()]); + String[] simpleMatchPatterns = simpleMatchPatternList.toArray(new String[0]); builder.keys().removeIf(key -> Regex.simpleMatch(simpleMatchPatterns, key)); } return builder.build(); diff --git a/server/src/main/java/org/opensearch/common/util/concurrent/PrioritizedOpenSearchThreadPoolExecutor.java b/server/src/main/java/org/opensearch/common/util/concurrent/PrioritizedOpenSearchThreadPoolExecutor.java index d3d0f6080e7f6..b4673d9534922 100644 --- a/server/src/main/java/org/opensearch/common/util/concurrent/PrioritizedOpenSearchThreadPoolExecutor.java +++ b/server/src/main/java/org/opensearch/common/util/concurrent/PrioritizedOpenSearchThreadPoolExecutor.java @@ -81,7 +81,7 @@ public Pending[] getPending() { List pending = new ArrayList<>(); addPending(new ArrayList<>(current), pending, true); addPending(new ArrayList<>(getQueue()), pending, false); - return pending.toArray(new Pending[pending.size()]); + return pending.toArray(new Pending[0]); } public int getNumberOfPendingTasks() { diff --git a/server/src/main/java/org/opensearch/env/NodeEnvironment.java b/server/src/main/java/org/opensearch/env/NodeEnvironment.java index 1eb64de2126d6..a29e088b2df8d 100644 --- a/server/src/main/java/org/opensearch/env/NodeEnvironment.java +++ b/server/src/main/java/org/opensearch/env/NodeEnvironment.java @@ -1005,7 +1005,7 @@ public Path[] resolveIndexFolder(String indexFolderName) { paths.add(indexFolder); } } - return paths.toArray(new Path[paths.size()]); + return paths.toArray(new Path[0]); } /** diff --git a/server/src/main/java/org/opensearch/gateway/LocalAllocateDangledIndices.java b/server/src/main/java/org/opensearch/gateway/LocalAllocateDangledIndices.java index 735140ca5dc24..e2666491630b7 100644 --- a/server/src/main/java/org/opensearch/gateway/LocalAllocateDangledIndices.java +++ b/server/src/main/java/org/opensearch/gateway/LocalAllocateDangledIndices.java @@ -113,10 +113,7 @@ public void allocateDangled(Collection indices, ActionListener stopWords) { if (stopWords == null) { throw new IllegalArgumentException("requires stopwords to be non-null"); } - this.stopWords = stopWords.toArray(new String[stopWords.size()]); + this.stopWords = stopWords.toArray(new String[0]); return this; } @@ -889,11 +889,11 @@ public static MoreLikeThisQueryBuilder fromXContent(XContentParser parser) throw throw new ParsingException(parser.getTokenLocation(), "more_like_this requires 'fields' to be non-empty"); } - String[] fieldsArray = fields == null ? null : fields.toArray(new String[fields.size()]); - String[] likeTextsArray = likeTexts.isEmpty() ? null : likeTexts.toArray(new String[likeTexts.size()]); - String[] unlikeTextsArray = unlikeTexts.isEmpty() ? null : unlikeTexts.toArray(new String[unlikeTexts.size()]); - Item[] likeItemsArray = likeItems.isEmpty() ? null : likeItems.toArray(new Item[likeItems.size()]); - Item[] unlikeItemsArray = unlikeItems.isEmpty() ? null : unlikeItems.toArray(new Item[unlikeItems.size()]); + String[] fieldsArray = fields == null ? null : fields.toArray(new String[0]); + String[] likeTextsArray = likeTexts.isEmpty() ? null : likeTexts.toArray(new String[0]); + String[] unlikeTextsArray = unlikeTexts.isEmpty() ? null : unlikeTexts.toArray(new String[0]); + Item[] likeItemsArray = likeItems.isEmpty() ? null : likeItems.toArray(new Item[0]); + Item[] unlikeItemsArray = unlikeItems.isEmpty() ? null : unlikeItems.toArray(new Item[0]); MoreLikeThisQueryBuilder moreLikeThisQueryBuilder = new MoreLikeThisQueryBuilder(fieldsArray, likeTextsArray, likeItemsArray) .unlike(unlikeTextsArray) @@ -1017,7 +1017,7 @@ protected Query doToQuery(QueryShardContext context) throws IOException { if (moreLikeFields.isEmpty()) { return null; } - mltQuery.setMoreLikeFields(moreLikeFields.toArray(new String[moreLikeFields.size()])); + mltQuery.setMoreLikeFields(moreLikeFields.toArray(new String[0])); // handle like texts if (likeTexts.length > 0) { @@ -1090,7 +1090,7 @@ private static void setDefaultIndexTypeFields( if (useDefaultField) { item.fields("*"); } else { - item.fields(moreLikeFields.toArray(new String[moreLikeFields.size()])); + item.fields(moreLikeFields.toArray(new String[0])); } } } diff --git a/server/src/main/java/org/opensearch/index/query/VectorGeoShapeQueryProcessor.java b/server/src/main/java/org/opensearch/index/query/VectorGeoShapeQueryProcessor.java index d50585ae0aebf..d3e092cd1cab3 100644 --- a/server/src/main/java/org/opensearch/index/query/VectorGeoShapeQueryProcessor.java +++ b/server/src/main/java/org/opensearch/index/query/VectorGeoShapeQueryProcessor.java @@ -81,11 +81,7 @@ private Query getVectorQueryFromShape(Geometry queryShape, String fieldName, Sha if (geometries.size() == 0) { return new MatchNoDocsQuery(); } - return LatLonShape.newGeometryQuery( - fieldName, - relation.getLuceneRelation(), - geometries.toArray(new LatLonGeometry[geometries.size()]) - ); + return LatLonShape.newGeometryQuery(fieldName, relation.getLuceneRelation(), geometries.toArray(new LatLonGeometry[0])); } /** diff --git a/server/src/main/java/org/opensearch/index/query/functionscore/FunctionScoreQueryBuilder.java b/server/src/main/java/org/opensearch/index/query/functionscore/FunctionScoreQueryBuilder.java index 19edcfc2b0b48..26be6fae56929 100644 --- a/server/src/main/java/org/opensearch/index/query/functionscore/FunctionScoreQueryBuilder.java +++ b/server/src/main/java/org/opensearch/index/query/functionscore/FunctionScoreQueryBuilder.java @@ -602,7 +602,7 @@ public static FunctionScoreQueryBuilder fromXContent(XContentParser parser) thro FunctionScoreQueryBuilder functionScoreQueryBuilder = new FunctionScoreQueryBuilder( query, - filterFunctionBuilders.toArray(new FunctionScoreQueryBuilder.FilterFunctionBuilder[filterFunctionBuilders.size()]) + filterFunctionBuilders.toArray(new FilterFunctionBuilder[0]) ); if (combineFunction != null) { functionScoreQueryBuilder.boostMode(combineFunction); diff --git a/server/src/main/java/org/opensearch/index/reindex/ReindexRequest.java b/server/src/main/java/org/opensearch/index/reindex/ReindexRequest.java index b444757b85951..bd8398eab91c1 100644 --- a/server/src/main/java/org/opensearch/index/reindex/ReindexRequest.java +++ b/server/src/main/java/org/opensearch/index/reindex/ReindexRequest.java @@ -400,7 +400,7 @@ private static String[] extractStringArray(Map source, String na if (value instanceof List) { @SuppressWarnings("unchecked") List list = (List) value; - return list.toArray(new String[list.size()]); + return list.toArray(new String[0]); } else if (value instanceof String) { return Strings.splitStringByCommaToArray((String) value); } else { diff --git a/server/src/main/java/org/opensearch/index/shard/LocalShardSnapshot.java b/server/src/main/java/org/opensearch/index/shard/LocalShardSnapshot.java index dc02cc054118c..82ec4c72e3d0c 100644 --- a/server/src/main/java/org/opensearch/index/shard/LocalShardSnapshot.java +++ b/server/src/main/java/org/opensearch/index/shard/LocalShardSnapshot.java @@ -96,7 +96,7 @@ Directory getSnapshotDirectory() { @Override public String[] listAll() throws IOException { Collection fileNames = wrappedIndexCommit.get().getFileNames(); - final String[] fileNameArray = fileNames.toArray(new String[fileNames.size()]); + final String[] fileNameArray = fileNames.toArray(new String[0]); return fileNameArray; } diff --git a/server/src/main/java/org/opensearch/monitor/fs/FsProbe.java b/server/src/main/java/org/opensearch/monitor/fs/FsProbe.java index 37cfee62bee27..a196a449fa10a 100644 --- a/server/src/main/java/org/opensearch/monitor/fs/FsProbe.java +++ b/server/src/main/java/org/opensearch/monitor/fs/FsProbe.java @@ -128,7 +128,7 @@ final FsInfo.IoStats ioStats(final Set> devicesNumbers, } } - return new FsInfo.IoStats(devicesStats.toArray(new FsInfo.DeviceStats[devicesStats.size()])); + return new FsInfo.IoStats(devicesStats.toArray(new FsInfo.DeviceStats[0])); } catch (Exception e) { // do not fail Elasticsearch if something unexpected // happens here diff --git a/server/src/main/java/org/opensearch/monitor/jvm/DeadlockAnalyzer.java b/server/src/main/java/org/opensearch/monitor/jvm/DeadlockAnalyzer.java index 12d749a2b9102..e48e036c1540b 100644 --- a/server/src/main/java/org/opensearch/monitor/jvm/DeadlockAnalyzer.java +++ b/server/src/main/java/org/opensearch/monitor/jvm/DeadlockAnalyzer.java @@ -81,7 +81,7 @@ private Deadlock[] createDeadlockDescriptions(Set> cyc Deadlock result[] = new Deadlock[cycles.size()]; int count = 0; for (LinkedHashSet cycle : cycles) { - ThreadInfo asArray[] = cycle.toArray(new ThreadInfo[cycle.size()]); + ThreadInfo asArray[] = cycle.toArray(new ThreadInfo[0]); Deadlock d = new Deadlock(asArray); result[count++] = d; } diff --git a/server/src/main/java/org/opensearch/monitor/jvm/JvmInfo.java b/server/src/main/java/org/opensearch/monitor/jvm/JvmInfo.java index 426551ab50f18..c0f7720341557 100644 --- a/server/src/main/java/org/opensearch/monitor/jvm/JvmInfo.java +++ b/server/src/main/java/org/opensearch/monitor/jvm/JvmInfo.java @@ -80,7 +80,7 @@ public class JvmInfo implements ReportingService.Info { } catch (Exception t) { // ignore } - String[] inputArguments = runtimeMXBean.getInputArguments().toArray(new String[runtimeMXBean.getInputArguments().size()]); + String[] inputArguments = runtimeMXBean.getInputArguments().toArray(new String[0]); Mem mem = new Mem(heapInit, heapMax, nonHeapInit, nonHeapMax, directMemoryMax); String bootClassPath; diff --git a/server/src/main/java/org/opensearch/rest/action/document/RestTermVectorsAction.java b/server/src/main/java/org/opensearch/rest/action/document/RestTermVectorsAction.java index e2b14629e75f4..85cfd09ea6695 100644 --- a/server/src/main/java/org/opensearch/rest/action/document/RestTermVectorsAction.java +++ b/server/src/main/java/org/opensearch/rest/action/document/RestTermVectorsAction.java @@ -123,7 +123,7 @@ public static void addFieldStringsFromParameter(TermVectorsRequest termVectorsRe } } if (selectedFields != null) { - termVectorsRequest.selectedFields(selectedFields.toArray(new String[selectedFields.size()])); + termVectorsRequest.selectedFields(selectedFields.toArray(new String[0])); } } diff --git a/server/src/main/java/org/opensearch/rest/action/search/RestGetAllPitsAction.java b/server/src/main/java/org/opensearch/rest/action/search/RestGetAllPitsAction.java index 0e1febe9d2a61..193a50c718492 100644 --- a/server/src/main/java/org/opensearch/rest/action/search/RestGetAllPitsAction.java +++ b/server/src/main/java/org/opensearch/rest/action/search/RestGetAllPitsAction.java @@ -54,7 +54,7 @@ protected RestChannelConsumer prepareRequest(RestRequest request, NodeClient cli for (DiscoveryNode node : nodesInCluster.get()) { nodes.add(node); } - DiscoveryNode[] disNodesArr = nodes.toArray(new DiscoveryNode[nodes.size()]); + DiscoveryNode[] disNodesArr = nodes.toArray(new DiscoveryNode[0]); GetAllPitNodesRequest getAllPitNodesRequest = new GetAllPitNodesRequest(disNodesArr); return channel -> client.getAllPits(getAllPitNodesRequest, new RestBuilderListener(channel) { @Override diff --git a/server/src/main/java/org/opensearch/search/aggregations/MultiBucketCollector.java b/server/src/main/java/org/opensearch/search/aggregations/MultiBucketCollector.java index 8f7222729efdb..cac3a6151bd78 100644 --- a/server/src/main/java/org/opensearch/search/aggregations/MultiBucketCollector.java +++ b/server/src/main/java/org/opensearch/search/aggregations/MultiBucketCollector.java @@ -188,7 +188,7 @@ private static class MultiLeafBucketCollector extends LeafBucketCollector { private int numCollectors; private MultiLeafBucketCollector(List collectors, boolean cacheScores) { - this.collectors = collectors.toArray(new LeafBucketCollector[collectors.size()]); + this.collectors = collectors.toArray(new LeafBucketCollector[0]); this.cacheScores = cacheScores; this.numCollectors = this.collectors.length; } diff --git a/server/src/main/java/org/opensearch/search/aggregations/bucket/terms/SignificantTextAggregationBuilder.java b/server/src/main/java/org/opensearch/search/aggregations/bucket/terms/SignificantTextAggregationBuilder.java index 7be04b13f0d6b..dbb3de5add84b 100644 --- a/server/src/main/java/org/opensearch/search/aggregations/bucket/terms/SignificantTextAggregationBuilder.java +++ b/server/src/main/java/org/opensearch/search/aggregations/bucket/terms/SignificantTextAggregationBuilder.java @@ -216,7 +216,7 @@ public SignificantTextAggregationBuilder fieldName(String fieldName) { * to also be the name of the JSON field holding the value */ public SignificantTextAggregationBuilder sourceFieldNames(List names) { - this.sourceFieldNames = names.toArray(new String[names.size()]); + this.sourceFieldNames = names.toArray(new String[0]); return this; } diff --git a/server/src/main/java/org/opensearch/search/aggregations/pipeline/BucketMetricsParser.java b/server/src/main/java/org/opensearch/search/aggregations/pipeline/BucketMetricsParser.java index d1de39600ad73..312bc88e480aa 100644 --- a/server/src/main/java/org/opensearch/search/aggregations/pipeline/BucketMetricsParser.java +++ b/server/src/main/java/org/opensearch/search/aggregations/pipeline/BucketMetricsParser.java @@ -85,7 +85,7 @@ public final BucketMetricsPipelineAggregationBuilder parse(String pipelineAgg String path = parser.text(); paths.add(path); } - bucketsPaths = paths.toArray(new String[paths.size()]); + bucketsPaths = paths.toArray(new String[0]); } else { parseToken(pipelineAggregatorName, parser, currentFieldName, token, params); } diff --git a/server/src/main/java/org/opensearch/search/aggregations/pipeline/DerivativePipelineAggregationBuilder.java b/server/src/main/java/org/opensearch/search/aggregations/pipeline/DerivativePipelineAggregationBuilder.java index 1455c2d6d8780..96f770647db8b 100644 --- a/server/src/main/java/org/opensearch/search/aggregations/pipeline/DerivativePipelineAggregationBuilder.java +++ b/server/src/main/java/org/opensearch/search/aggregations/pipeline/DerivativePipelineAggregationBuilder.java @@ -223,7 +223,7 @@ public static DerivativePipelineAggregationBuilder parse(String pipelineAggregat String path = parser.text(); paths.add(path); } - bucketsPaths = paths.toArray(new String[paths.size()]); + bucketsPaths = paths.toArray(new String[0]); } else { throw new ParsingException( parser.getTokenLocation(), diff --git a/server/src/main/java/org/opensearch/search/aggregations/pipeline/MaxBucketPipelineAggregator.java b/server/src/main/java/org/opensearch/search/aggregations/pipeline/MaxBucketPipelineAggregator.java index 7e63af31a9c86..1137610026989 100644 --- a/server/src/main/java/org/opensearch/search/aggregations/pipeline/MaxBucketPipelineAggregator.java +++ b/server/src/main/java/org/opensearch/search/aggregations/pipeline/MaxBucketPipelineAggregator.java @@ -78,7 +78,7 @@ protected void collectBucketValue(String bucketKey, Double bucketValue) { @Override protected InternalAggregation buildAggregation(Map metadata) { - String[] keys = maxBucketKeys.toArray(new String[maxBucketKeys.size()]); + String[] keys = maxBucketKeys.toArray(new String[0]); return new InternalBucketMetricValue(name(), keys, maxValue, format, metadata()); } diff --git a/server/src/main/java/org/opensearch/search/aggregations/pipeline/MovAvgPipelineAggregationBuilder.java b/server/src/main/java/org/opensearch/search/aggregations/pipeline/MovAvgPipelineAggregationBuilder.java index 5f94c21da395e..e5d3d418cdbbc 100644 --- a/server/src/main/java/org/opensearch/search/aggregations/pipeline/MovAvgPipelineAggregationBuilder.java +++ b/server/src/main/java/org/opensearch/search/aggregations/pipeline/MovAvgPipelineAggregationBuilder.java @@ -386,7 +386,7 @@ public static MovAvgPipelineAggregationBuilder parse( String path = parser.text(); paths.add(path); } - bucketsPaths = paths.toArray(new String[paths.size()]); + bucketsPaths = paths.toArray(new String[0]); } else { throw new ParsingException( parser.getTokenLocation(), diff --git a/server/src/main/java/org/opensearch/search/aggregations/pipeline/SerialDiffPipelineAggregationBuilder.java b/server/src/main/java/org/opensearch/search/aggregations/pipeline/SerialDiffPipelineAggregationBuilder.java index e3140ed77d3d5..71d205c9c2228 100644 --- a/server/src/main/java/org/opensearch/search/aggregations/pipeline/SerialDiffPipelineAggregationBuilder.java +++ b/server/src/main/java/org/opensearch/search/aggregations/pipeline/SerialDiffPipelineAggregationBuilder.java @@ -220,7 +220,7 @@ public static SerialDiffPipelineAggregationBuilder parse(String reducerName, XCo String path = parser.text(); paths.add(path); } - bucketsPaths = paths.toArray(new String[paths.size()]); + bucketsPaths = paths.toArray(new String[0]); } else { throw new ParsingException( parser.getTokenLocation(), diff --git a/server/src/main/java/org/opensearch/search/fetch/subphase/FetchSourceContext.java b/server/src/main/java/org/opensearch/search/fetch/subphase/FetchSourceContext.java index fe972028508e8..b93232d0c65f7 100644 --- a/server/src/main/java/org/opensearch/search/fetch/subphase/FetchSourceContext.java +++ b/server/src/main/java/org/opensearch/search/fetch/subphase/FetchSourceContext.java @@ -150,7 +150,7 @@ public static FetchSourceContext fromXContent(XContentParser parser) throws IOEx while ((token = parser.nextToken()) != XContentParser.Token.END_ARRAY) { list.add(parser.text()); } - includes = list.toArray(new String[list.size()]); + includes = list.toArray(new String[0]); } else if (token == XContentParser.Token.START_OBJECT) { String currentFieldName = null; while ((token = parser.nextToken()) != XContentParser.Token.END_OBJECT) { @@ -170,7 +170,7 @@ public static FetchSourceContext fromXContent(XContentParser parser) throws IOEx ); } } - includes = includesList.toArray(new String[includesList.size()]); + includes = includesList.toArray(new String[0]); } else if (EXCLUDES_FIELD.match(currentFieldName, parser.getDeprecationHandler())) { List excludesList = new ArrayList<>(); while ((token = parser.nextToken()) != XContentParser.Token.END_ARRAY) { @@ -184,7 +184,7 @@ public static FetchSourceContext fromXContent(XContentParser parser) throws IOEx ); } } - excludes = excludesList.toArray(new String[excludesList.size()]); + excludes = excludesList.toArray(new String[0]); } else { throw new ParsingException( parser.getTokenLocation(), diff --git a/server/src/main/java/org/opensearch/search/fetch/subphase/highlight/HighlightField.java b/server/src/main/java/org/opensearch/search/fetch/subphase/highlight/HighlightField.java index 638e1619a3658..097acc2d73668 100644 --- a/server/src/main/java/org/opensearch/search/fetch/subphase/highlight/HighlightField.java +++ b/server/src/main/java/org/opensearch/search/fetch/subphase/highlight/HighlightField.java @@ -137,7 +137,7 @@ public static HighlightField fromXContent(XContentParser parser) throws IOExcept while (parser.nextToken() != XContentParser.Token.END_ARRAY) { values.add(new Text(parser.text())); } - fragments = values.toArray(new Text[values.size()]); + fragments = values.toArray(new Text[0]); } else if (token == XContentParser.Token.VALUE_NULL) { fragments = null; } else { diff --git a/server/src/main/java/org/opensearch/search/sort/GeoDistanceSortBuilder.java b/server/src/main/java/org/opensearch/search/sort/GeoDistanceSortBuilder.java index a1fe3a02fb113..2068bfc38af56 100644 --- a/server/src/main/java/org/opensearch/search/sort/GeoDistanceSortBuilder.java +++ b/server/src/main/java/org/opensearch/search/sort/GeoDistanceSortBuilder.java @@ -239,7 +239,7 @@ public GeoDistanceSortBuilder points(GeoPoint... points) { * Returns the points to create the range distance facets from. */ public GeoPoint[] points() { - return this.points.toArray(new GeoPoint[this.points.size()]); + return this.points.toArray(new GeoPoint[0]); } /** @@ -574,7 +574,7 @@ public static GeoDistanceSortBuilder fromXContent(XContentParser parser, String } } - GeoDistanceSortBuilder result = new GeoDistanceSortBuilder(fieldName, geoPoints.toArray(new GeoPoint[geoPoints.size()])); + GeoDistanceSortBuilder result = new GeoDistanceSortBuilder(fieldName, geoPoints.toArray(new GeoPoint[0])); result.geoDistance(geoDistance); result.unit(unit); result.order(order); @@ -642,7 +642,7 @@ public BucketedSort buildBucketedSort(QueryShardContext context, int bucketSize, private GeoPoint[] localPoints() { // validation was not available prior to 2.x, so to support bwc percolation queries we only ignore_malformed // on 2.x created indexes - GeoPoint[] localPoints = points.toArray(new GeoPoint[points.size()]); + GeoPoint[] localPoints = points.toArray(new GeoPoint[0]); if (GeoValidationMethod.isIgnoreMalformed(validation) == false) { for (GeoPoint point : localPoints) { if (GeoUtils.isValidLatitude(point.lat()) == false) { diff --git a/server/src/main/java/org/opensearch/search/sort/SortBuilder.java b/server/src/main/java/org/opensearch/search/sort/SortBuilder.java index a8ade60b5b64f..e59d8e9d33efa 100644 --- a/server/src/main/java/org/opensearch/search/sort/SortBuilder.java +++ b/server/src/main/java/org/opensearch/search/sort/SortBuilder.java @@ -182,10 +182,7 @@ public static Optional buildSort(List> sortBuilde } if (sort) { return Optional.of( - new SortAndFormats( - new Sort(sortFields.toArray(new SortField[sortFields.size()])), - sortFormats.toArray(new DocValueFormat[sortFormats.size()]) - ) + new SortAndFormats(new Sort(sortFields.toArray(new SortField[0])), sortFormats.toArray(new DocValueFormat[0])) ); } } diff --git a/server/src/main/java/org/opensearch/search/suggest/phrase/DirectCandidateGenerator.java b/server/src/main/java/org/opensearch/search/suggest/phrase/DirectCandidateGenerator.java index cbf1d332dfa1b..e9131015996d9 100644 --- a/server/src/main/java/org/opensearch/search/suggest/phrase/DirectCandidateGenerator.java +++ b/server/src/main/java/org/opensearch/search/suggest/phrase/DirectCandidateGenerator.java @@ -324,7 +324,7 @@ public void addCandidates(List candidates) { final Set set = new HashSet<>(candidates); Collections.addAll(set, this.candidates); - this.candidates = set.toArray(new Candidate[set.size()]); + this.candidates = set.toArray(new Candidate[0]); // Sort strongest to weakest: Arrays.sort(this.candidates, Collections.reverseOrder()); } diff --git a/server/src/main/java/org/opensearch/search/suggest/phrase/NoisyChannelSpellChecker.java b/server/src/main/java/org/opensearch/search/suggest/phrase/NoisyChannelSpellChecker.java index 49790c996371a..e8ba90f353f02 100644 --- a/server/src/main/java/org/opensearch/search/suggest/phrase/NoisyChannelSpellChecker.java +++ b/server/src/main/java/org/opensearch/search/suggest/phrase/NoisyChannelSpellChecker.java @@ -129,7 +129,7 @@ public void end() { } double cutoffScore = Double.MIN_VALUE; CandidateScorer scorer = new CandidateScorer(wordScorer, numCorrections, gramSize); - CandidateSet[] candidateSets = candidateSetsList.toArray(new CandidateSet[candidateSetsList.size()]); + CandidateSet[] candidateSets = candidateSetsList.toArray(new CandidateSet[0]); if (confidence > 0.0) { Candidate[] candidates = new Candidate[candidateSets.length]; for (int i = 0; i < candidates.length; i++) { diff --git a/server/src/main/java/org/opensearch/search/suggest/phrase/PhraseSuggester.java b/server/src/main/java/org/opensearch/search/suggest/phrase/PhraseSuggester.java index ef0ab4917de2c..fa43479bfd89e 100644 --- a/server/src/main/java/org/opensearch/search/suggest/phrase/PhraseSuggester.java +++ b/server/src/main/java/org/opensearch/search/suggest/phrase/PhraseSuggester.java @@ -133,7 +133,7 @@ public Suggestion> innerExecute( try (TokenStream stream = tokenStream(suggestion.getAnalyzer(), suggestion.getText(), spare, suggestion.getField())) { checkerResult = checker.getCorrections( stream, - new MultiCandidateGeneratorWrapper(suggestion.getShardSize(), gens.toArray(new CandidateGenerator[gens.size()])), + new MultiCandidateGeneratorWrapper(suggestion.getShardSize(), gens.toArray(new CandidateGenerator[0])), suggestion.maxErrors(), suggestion.getShardSize(), wordScorer, diff --git a/server/src/main/java/org/opensearch/snapshots/SnapshotInfo.java b/server/src/main/java/org/opensearch/snapshots/SnapshotInfo.java index 94ab875091caf..cdad4384cf54e 100644 --- a/server/src/main/java/org/opensearch/snapshots/SnapshotInfo.java +++ b/server/src/main/java/org/opensearch/snapshots/SnapshotInfo.java @@ -586,11 +586,7 @@ public RestStatus status() { if (shardFailures.size() == 0) { return RestStatus.OK; } - return RestStatus.status( - successfulShards, - totalShards, - shardFailures.toArray(new ShardOperationFailedException[shardFailures.size()]) - ); + return RestStatus.status(successfulShards, totalShards, shardFailures.toArray(new ShardOperationFailedException[0])); } @Override diff --git a/server/src/test/java/org/opensearch/action/admin/cluster/node/tasks/TransportTasksActionTests.java b/server/src/test/java/org/opensearch/action/admin/cluster/node/tasks/TransportTasksActionTests.java index 97a045872477d..a981c527b6da6 100644 --- a/server/src/test/java/org/opensearch/action/admin/cluster/node/tasks/TransportTasksActionTests.java +++ b/server/src/test/java/org/opensearch/action/admin/cluster/node/tasks/TransportTasksActionTests.java @@ -685,7 +685,7 @@ protected String[] filterNodeIds(DiscoveryNodes nodes, String[] nodesIds) { filteredNodes.add(node); } } - return filteredNodes.toArray(new String[filteredNodes.size()]); + return filteredNodes.toArray(new String[0]); } @Override diff --git a/server/src/test/java/org/opensearch/action/admin/cluster/shards/ClusterSearchShardsResponseTests.java b/server/src/test/java/org/opensearch/action/admin/cluster/shards/ClusterSearchShardsResponseTests.java index 3c2e34ebb9ed5..6c54303802407 100644 --- a/server/src/test/java/org/opensearch/action/admin/cluster/shards/ClusterSearchShardsResponseTests.java +++ b/server/src/test/java/org/opensearch/action/admin/cluster/shards/ClusterSearchShardsResponseTests.java @@ -88,7 +88,7 @@ public void testSerialization() throws Exception { } ClusterSearchShardsResponse clusterSearchShardsResponse = new ClusterSearchShardsResponse( clusterSearchShardsGroups, - nodes.toArray(new DiscoveryNode[nodes.size()]), + nodes.toArray(new DiscoveryNode[0]), indicesAndFilters ); diff --git a/server/src/test/java/org/opensearch/action/admin/indices/rollover/TransportRolloverActionTests.java b/server/src/test/java/org/opensearch/action/admin/indices/rollover/TransportRolloverActionTests.java index b206c2e19a65b..4596ee4ef77af 100644 --- a/server/src/test/java/org/opensearch/action/admin/indices/rollover/TransportRolloverActionTests.java +++ b/server/src/test/java/org/opensearch/action/admin/indices/rollover/TransportRolloverActionTests.java @@ -425,7 +425,7 @@ public static IndicesStatsResponse randomIndicesStatsResponse(final IndexMetadat } } return IndicesStatsTests.newIndicesStatsResponse( - shardStats.toArray(new ShardStats[shardStats.size()]), + shardStats.toArray(new ShardStats[0]), shardStats.size(), shardStats.size(), 0, diff --git a/server/src/test/java/org/opensearch/action/admin/indices/stats/IndicesStatsResponseTests.java b/server/src/test/java/org/opensearch/action/admin/indices/stats/IndicesStatsResponseTests.java index 802257357b7a8..18b6cc37c37c4 100644 --- a/server/src/test/java/org/opensearch/action/admin/indices/stats/IndicesStatsResponseTests.java +++ b/server/src/test/java/org/opensearch/action/admin/indices/stats/IndicesStatsResponseTests.java @@ -100,13 +100,7 @@ public void testGetIndices() { shardsCounter.incrementAndGet(); } } - final IndicesStatsResponse indicesStatsResponse = new IndicesStatsResponse( - shards.toArray(new ShardStats[shards.size()]), - 0, - 0, - 0, - null - ); + final IndicesStatsResponse indicesStatsResponse = new IndicesStatsResponse(shards.toArray(new ShardStats[0]), 0, 0, 0, null); Map indexStats = indicesStatsResponse.getIndices(); assertThat(indexStats.size(), is(noOfIndexes)); diff --git a/server/src/test/java/org/opensearch/action/bulk/BulkRequestModifierTests.java b/server/src/test/java/org/opensearch/action/bulk/BulkRequestModifierTests.java index e7e1166eb57fa..acc612183eac7 100644 --- a/server/src/test/java/org/opensearch/action/bulk/BulkRequestModifierTests.java +++ b/server/src/test/java/org/opensearch/action/bulk/BulkRequestModifierTests.java @@ -130,7 +130,7 @@ public void onFailure(Exception e) {} IndexResponse indexResponse = new IndexResponse(new ShardId("index", "_na_", 0), indexRequest.id(), 1, 17, 1, true); originalResponses.add(new BulkItemResponse(Integer.parseInt(indexRequest.id()), indexRequest.opType(), indexResponse)); } - bulkResponseListener.onResponse(new BulkResponse(originalResponses.toArray(new BulkItemResponse[originalResponses.size()]), 0)); + bulkResponseListener.onResponse(new BulkResponse(originalResponses.toArray(new BulkItemResponse[0]), 0)); assertThat(responses.size(), Matchers.equalTo(32)); for (int i = 0; i < 32; i++) { diff --git a/server/src/test/java/org/opensearch/action/support/nodes/TransportNodesActionTests.java b/server/src/test/java/org/opensearch/action/support/nodes/TransportNodesActionTests.java index 76142efc60b7d..0827e4fc20255 100644 --- a/server/src/test/java/org/opensearch/action/support/nodes/TransportNodesActionTests.java +++ b/server/src/test/java/org/opensearch/action/support/nodes/TransportNodesActionTests.java @@ -105,7 +105,7 @@ public void testNodesSelectors() { String nodeId = randomFrom(nodeIds); nodeSelectors.add(nodeId); } - String[] finalNodesIds = nodeSelectors.toArray(new String[nodeSelectors.size()]); + String[] finalNodesIds = nodeSelectors.toArray(new String[0]); TestNodesRequest request = new TestNodesRequest(finalNodesIds); action.new AsyncAction(null, request, new PlainActionFuture<>()).start(); Map> capturedRequests = transport.getCapturedRequestsByTargetNodeAndClear(); diff --git a/server/src/test/java/org/opensearch/action/termvectors/AbstractTermVectorsTestCase.java b/server/src/test/java/org/opensearch/action/termvectors/AbstractTermVectorsTestCase.java index d9613176c0156..f586a3db1c05c 100644 --- a/server/src/test/java/org/opensearch/action/termvectors/AbstractTermVectorsTestCase.java +++ b/server/src/test/java/org/opensearch/action/termvectors/AbstractTermVectorsTestCase.java @@ -308,7 +308,7 @@ protected TestConfig[] generateTestConfigs(int numberOfTests, TestDoc[] testDocs refresh(); - return configs.toArray(new TestConfig[configs.size()]); + return configs.toArray(new TestConfig[0]); } protected TestFieldSetting[] getFieldSettings() { diff --git a/server/src/test/java/org/opensearch/cluster/node/DiscoveryNodesTests.java b/server/src/test/java/org/opensearch/cluster/node/DiscoveryNodesTests.java index 67c4f6888c882..dba0afc9f3641 100644 --- a/server/src/test/java/org/opensearch/cluster/node/DiscoveryNodesTests.java +++ b/server/src/test/java/org/opensearch/cluster/node/DiscoveryNodesTests.java @@ -168,9 +168,9 @@ public void testResolveNodesIds() { expectedNodeIdsSet.add(discoveryNode.getId()); } - String[] resolvedNodesIds = discoveryNodes.resolveNodes(nodeSelectors.toArray(new String[nodeSelectors.size()])); + String[] resolvedNodesIds = discoveryNodes.resolveNodes(nodeSelectors.toArray(new String[0])); Arrays.sort(resolvedNodesIds); - String[] expectedNodesIds = expectedNodeIdsSet.toArray(new String[expectedNodeIdsSet.size()]); + String[] expectedNodesIds = expectedNodeIdsSet.toArray(new String[0]); Arrays.sort(expectedNodesIds); assertThat(resolvedNodesIds, equalTo(expectedNodesIds)); } diff --git a/server/src/test/java/org/opensearch/cluster/routing/allocation/FailedNodeRoutingTests.java b/server/src/test/java/org/opensearch/cluster/routing/allocation/FailedNodeRoutingTests.java index b3d62ea9c6160..121694e880b10 100644 --- a/server/src/test/java/org/opensearch/cluster/routing/allocation/FailedNodeRoutingTests.java +++ b/server/src/test/java/org/opensearch/cluster/routing/allocation/FailedNodeRoutingTests.java @@ -238,7 +238,7 @@ public ClusterState randomInitialClusterState() { for (int i = 0; i < randomIntBetween(2, 5); i++) { allNodes.add(createNode()); } - ClusterState state = ClusterStateCreationUtils.state(localNode, localNode, allNodes.toArray(new DiscoveryNode[allNodes.size()])); + ClusterState state = ClusterStateCreationUtils.state(localNode, localNode, allNodes.toArray(new DiscoveryNode[0])); return state; } diff --git a/server/src/test/java/org/opensearch/cluster/serialization/DiffableTests.java b/server/src/test/java/org/opensearch/cluster/serialization/DiffableTests.java index 474f5e3ea09dd..9c1e3255bb3d8 100644 --- a/server/src/test/java/org/opensearch/cluster/serialization/DiffableTests.java +++ b/server/src/test/java/org/opensearch/cluster/serialization/DiffableTests.java @@ -216,10 +216,7 @@ public abstract class MapDriver { protected final Set keysToRemove = new HashSet<>(randomSubsetOf(randomInt(keys.size()), keys.toArray(new Integer[0]))); protected final Set keysThatAreNotRemoved = Sets.difference(keys, keysToRemove); protected final Set keysToOverride = new HashSet<>( - randomSubsetOf( - randomInt(keysThatAreNotRemoved.size()), - keysThatAreNotRemoved.toArray(new Integer[keysThatAreNotRemoved.size()]) - ) + randomSubsetOf(randomInt(keysThatAreNotRemoved.size()), keysThatAreNotRemoved.toArray(new Integer[0])) ); // make sure keysToAdd does not contain elements in keys protected final Set keysToAdd = Sets.difference(randomPositiveIntSet(), keys); diff --git a/server/src/test/java/org/opensearch/common/collect/IteratorsTests.java b/server/src/test/java/org/opensearch/common/collect/IteratorsTests.java index 155391aaaf62f..6ad272542dbb1 100644 --- a/server/src/test/java/org/opensearch/common/collect/IteratorsTests.java +++ b/server/src/test/java/org/opensearch/common/collect/IteratorsTests.java @@ -104,7 +104,7 @@ public void testRandomIterators() { } iterators[i] = theseValues.iterator(); } - assertContainsInOrder(Iterators.concat(iterators), values.toArray(new Integer[values.size()])); + assertContainsInOrder(Iterators.concat(iterators), values.toArray(new Integer[0])); } public void testTwoEntries() { diff --git a/server/src/test/java/org/opensearch/common/geo/GeoJsonShapeParserTests.java b/server/src/test/java/org/opensearch/common/geo/GeoJsonShapeParserTests.java index 2ca692a8db374..9f47c5ae96394 100644 --- a/server/src/test/java/org/opensearch/common/geo/GeoJsonShapeParserTests.java +++ b/server/src/test/java/org/opensearch/common/geo/GeoJsonShapeParserTests.java @@ -352,7 +352,7 @@ public void testParsePolygon() throws IOException, ParseException { shellCoordinates.add(new Coordinate(101, 1)); shellCoordinates.add(new Coordinate(100, 1)); shellCoordinates.add(new Coordinate(100, 0)); - Coordinate[] coordinates = shellCoordinates.toArray(new Coordinate[shellCoordinates.size()]); + Coordinate[] coordinates = shellCoordinates.toArray(new Coordinate[0]); LinearRing shell = GEOMETRY_FACTORY.createLinearRing(coordinates); Polygon expected = GEOMETRY_FACTORY.createPolygon(shell, null); assertGeometryEquals(jtsGeom(expected), polygonGeoJson, true); @@ -404,7 +404,7 @@ public void testParse3DPolygon() throws IOException, ParseException { shellCoordinates.add(new Coordinate(101, 1, 10)); shellCoordinates.add(new Coordinate(100, 1, 10)); shellCoordinates.add(new Coordinate(100, 0, 10)); - Coordinate[] coordinates = shellCoordinates.toArray(new Coordinate[shellCoordinates.size()]); + Coordinate[] coordinates = shellCoordinates.toArray(new Coordinate[0]); Version randomVersion = VersionUtils.randomIndexCompatibleVersion(random()); Settings indexSettings = Settings.builder() @@ -414,7 +414,7 @@ public void testParse3DPolygon() throws IOException, ParseException { .put(IndexMetadata.SETTING_INDEX_UUID, UUIDs.randomBase64UUID()) .build(); - LinearRing shell = GEOMETRY_FACTORY.createLinearRing(shellCoordinates.toArray(new Coordinate[shellCoordinates.size()])); + LinearRing shell = GEOMETRY_FACTORY.createLinearRing(shellCoordinates.toArray(new Coordinate[0])); Polygon expected = GEOMETRY_FACTORY.createPolygon(shell, null); Mapper.BuilderContext mockBuilderContext = new Mapper.BuilderContext(indexSettings, new ContentPath()); final LegacyGeoShapeFieldMapper mapperBuilder = (LegacyGeoShapeFieldMapper) (new LegacyGeoShapeFieldMapper.Builder("test") @@ -1389,9 +1389,9 @@ public void testParsePolygonWithHole() throws IOException, ParseException { holeCoordinates.add(new Coordinate(100.2, 0.8)); holeCoordinates.add(new Coordinate(100.2, 0.2)); - LinearRing shell = GEOMETRY_FACTORY.createLinearRing(shellCoordinates.toArray(new Coordinate[shellCoordinates.size()])); + LinearRing shell = GEOMETRY_FACTORY.createLinearRing(shellCoordinates.toArray(new Coordinate[0])); LinearRing[] holes = new LinearRing[1]; - holes[0] = GEOMETRY_FACTORY.createLinearRing(holeCoordinates.toArray(new Coordinate[holeCoordinates.size()])); + holes[0] = GEOMETRY_FACTORY.createLinearRing(holeCoordinates.toArray(new Coordinate[0])); Polygon expected = GEOMETRY_FACTORY.createPolygon(shell, holes); assertGeometryEquals(jtsGeom(expected), polygonGeoJson, true); @@ -1574,9 +1574,9 @@ public void testParseMultiPolygon() throws IOException, ParseException { holeCoordinates.add(new Coordinate(100.2, 0.8)); holeCoordinates.add(new Coordinate(100.2, 0.2)); - LinearRing shell = GEOMETRY_FACTORY.createLinearRing(shellCoordinates.toArray(new Coordinate[shellCoordinates.size()])); + LinearRing shell = GEOMETRY_FACTORY.createLinearRing(shellCoordinates.toArray(new Coordinate[0])); LinearRing[] holes = new LinearRing[1]; - holes[0] = GEOMETRY_FACTORY.createLinearRing(holeCoordinates.toArray(new Coordinate[holeCoordinates.size()])); + holes[0] = GEOMETRY_FACTORY.createLinearRing(holeCoordinates.toArray(new Coordinate[0])); Polygon withHoles = GEOMETRY_FACTORY.createPolygon(shell, holes); shellCoordinates = new ArrayList<>(); @@ -1586,7 +1586,7 @@ public void testParseMultiPolygon() throws IOException, ParseException { shellCoordinates.add(new Coordinate(102, 2)); shellCoordinates.add(new Coordinate(102, 3)); - shell = GEOMETRY_FACTORY.createLinearRing(shellCoordinates.toArray(new Coordinate[shellCoordinates.size()])); + shell = GEOMETRY_FACTORY.createLinearRing(shellCoordinates.toArray(new Coordinate[0])); Polygon withoutHoles = GEOMETRY_FACTORY.createPolygon(shell, null); Shape expected = shapeCollection(withoutHoles, withHoles); @@ -1688,9 +1688,9 @@ public void testParseMultiPolygon() throws IOException, ParseException { holeCoordinates.add(new Coordinate(100.8, 0.8)); holeCoordinates.add(new Coordinate(100.2, 0.8)); - shell = GEOMETRY_FACTORY.createLinearRing(shellCoordinates.toArray(new Coordinate[shellCoordinates.size()])); + shell = GEOMETRY_FACTORY.createLinearRing(shellCoordinates.toArray(new Coordinate[0])); holes = new LinearRing[1]; - holes[0] = GEOMETRY_FACTORY.createLinearRing(holeCoordinates.toArray(new Coordinate[holeCoordinates.size()])); + holes[0] = GEOMETRY_FACTORY.createLinearRing(holeCoordinates.toArray(new Coordinate[0])); withHoles = GEOMETRY_FACTORY.createPolygon(shell, holes); assertGeometryEquals(jtsGeom(withHoles), multiPolygonGeoJson, true); @@ -1789,8 +1789,8 @@ public void testParseGeometryCollection() throws IOException, ParseException { expected[0] = jtsGeom(expectedLineString); Point expectedPoint = GEOMETRY_FACTORY.createPoint(new Coordinate(102.0, 2.0)); expected[1] = new JtsPoint(expectedPoint, SPATIAL_CONTEXT); - LinearRing shell1 = GEOMETRY_FACTORY.createLinearRing(shellCoordinates1.toArray(new Coordinate[shellCoordinates1.size()])); - LinearRing shell2 = GEOMETRY_FACTORY.createLinearRing(shellCoordinates2.toArray(new Coordinate[shellCoordinates2.size()])); + LinearRing shell1 = GEOMETRY_FACTORY.createLinearRing(shellCoordinates1.toArray(new Coordinate[0])); + LinearRing shell2 = GEOMETRY_FACTORY.createLinearRing(shellCoordinates2.toArray(new Coordinate[0])); MultiPolygon expectedMultiPoly = GEOMETRY_FACTORY.createMultiPolygon( new Polygon[] { GEOMETRY_FACTORY.createPolygon(shell1), GEOMETRY_FACTORY.createPolygon(shell2) } ); diff --git a/server/src/test/java/org/opensearch/common/geo/GeoWKTShapeParserTests.java b/server/src/test/java/org/opensearch/common/geo/GeoWKTShapeParserTests.java index cd05331442be2..80164ef8a925c 100644 --- a/server/src/test/java/org/opensearch/common/geo/GeoWKTShapeParserTests.java +++ b/server/src/test/java/org/opensearch/common/geo/GeoWKTShapeParserTests.java @@ -180,7 +180,7 @@ private List randomLineStringCoords() { @Override public void testParseLineString() throws IOException, ParseException { List coordinates = randomLineStringCoords(); - LineString expected = GEOMETRY_FACTORY.createLineString(coordinates.toArray(new Coordinate[coordinates.size()])); + LineString expected = GEOMETRY_FACTORY.createLineString(coordinates.toArray(new Coordinate[0])); assertExpected(jtsGeom(expected), new LineStringBuilder(coordinates), true); double[] lats = new double[coordinates.size()]; @@ -199,7 +199,7 @@ public void testParseMultiLineString() throws IOException, ParseException { MultiLineStringBuilder builder = new MultiLineStringBuilder(); for (int j = 0; j < numLineStrings; ++j) { List lsc = randomLineStringCoords(); - Coordinate[] coords = lsc.toArray(new Coordinate[lsc.size()]); + Coordinate[] coords = lsc.toArray(new Coordinate[0]); lineStrings.add(GEOMETRY_FACTORY.createLineString(coords)); builder.linestring(new LineStringBuilder(lsc)); } @@ -220,7 +220,7 @@ public void testParseMultiLineString() throws IOException, ParseException { assertExpected(expectedGeom, builder, false); assertMalformed(builder); - MultiLineString expected = GEOMETRY_FACTORY.createMultiLineString(lineStrings.toArray(new LineString[lineStrings.size()])); + MultiLineString expected = GEOMETRY_FACTORY.createMultiLineString(lineStrings.toArray(new LineString[0])); assumeTrue("JTS test path cannot handle empty multilinestrings", numLineStrings > 1); assertExpected(jtsGeom(expected), builder, true); } @@ -278,9 +278,9 @@ public void testParsePolygonWithHole() throws IOException, ParseException { PolygonBuilder polygonWithHole = new PolygonBuilder(new CoordinatesBuilder().coordinates(shellCoordinates)); polygonWithHole.hole(new LineStringBuilder(holeCoordinates)); - LinearRing shell = GEOMETRY_FACTORY.createLinearRing(shellCoordinates.toArray(new Coordinate[shellCoordinates.size()])); + LinearRing shell = GEOMETRY_FACTORY.createLinearRing(shellCoordinates.toArray(new Coordinate[0])); LinearRing[] holes = new LinearRing[1]; - holes[0] = GEOMETRY_FACTORY.createLinearRing(holeCoordinates.toArray(new Coordinate[holeCoordinates.size()])); + holes[0] = GEOMETRY_FACTORY.createLinearRing(holeCoordinates.toArray(new Coordinate[0])); Polygon expected = GEOMETRY_FACTORY.createPolygon(shell, holes); assertExpected(jtsGeom(expected), polygonWithHole, true); diff --git a/server/src/test/java/org/opensearch/common/xcontent/support/XContentMapValuesTests.java b/server/src/test/java/org/opensearch/common/xcontent/support/XContentMapValuesTests.java index 8d8ba9872ee61..bbdb255424030 100644 --- a/server/src/test/java/org/opensearch/common/xcontent/support/XContentMapValuesTests.java +++ b/server/src/test/java/org/opensearch/common/xcontent/support/XContentMapValuesTests.java @@ -73,13 +73,13 @@ protected void testFilter(Builder expected, Builder actual, Set includes if (includes == null) { sourceIncludes = randomBoolean() ? Strings.EMPTY_ARRAY : null; } else { - sourceIncludes = includes.toArray(new String[includes.size()]); + sourceIncludes = includes.toArray(new String[0]); } String[] sourceExcludes; if (excludes == null) { sourceExcludes = randomBoolean() ? Strings.EMPTY_ARRAY : null; } else { - sourceExcludes = excludes.toArray(new String[excludes.size()]); + sourceExcludes = excludes.toArray(new String[0]); } assertEquals( diff --git a/server/src/test/java/org/opensearch/env/NodeEnvironmentTests.java b/server/src/test/java/org/opensearch/env/NodeEnvironmentTests.java index d886922d56882..9c2ba140cdc09 100644 --- a/server/src/test/java/org/opensearch/env/NodeEnvironmentTests.java +++ b/server/src/test/java/org/opensearch/env/NodeEnvironmentTests.java @@ -266,7 +266,7 @@ public void testResolveIndexFolders() throws Exception { } for (Map.Entry> actualIndexDataPathEntry : actualIndexDataPaths.entrySet()) { List actual = actualIndexDataPathEntry.getValue(); - Path[] actualPaths = actual.toArray(new Path[actual.size()]); + Path[] actualPaths = actual.toArray(new Path[0]); assertThat(actualPaths, equalTo(env.resolveIndexFolder(actualIndexDataPathEntry.getKey()))); } assertTrue("LockedShards: " + env.lockedShards(), env.lockedShards().isEmpty()); diff --git a/server/src/test/java/org/opensearch/index/query/MoreLikeThisQueryBuilderTests.java b/server/src/test/java/org/opensearch/index/query/MoreLikeThisQueryBuilderTests.java index 2061378c3f54f..9c670d6cc65ca 100644 --- a/server/src/test/java/org/opensearch/index/query/MoreLikeThisQueryBuilderTests.java +++ b/server/src/test/java/org/opensearch/index/query/MoreLikeThisQueryBuilderTests.java @@ -246,10 +246,7 @@ protected MultiTermVectorsResponse executeMultiTermVectors(MultiTermVectorsReque if (request.doc() != null) { generatedFields = generateFields(randomFields, request.doc().utf8ToString()); } else { - generatedFields = generateFields( - request.selectedFields().toArray(new String[request.selectedFields().size()]), - request.id() - ); + generatedFields = generateFields(request.selectedFields().toArray(new String[0]), request.id()); } EnumSet flags = EnumSet.of(TermVectorsRequest.Flag.Positions, TermVectorsRequest.Flag.Offsets); response.setFields(generatedFields, request.selectedFields(), flags, generatedFields); diff --git a/server/src/test/java/org/opensearch/index/query/RegexpQueryBuilderTests.java b/server/src/test/java/org/opensearch/index/query/RegexpQueryBuilderTests.java index 31bb078fa4c1d..6366951329788 100644 --- a/server/src/test/java/org/opensearch/index/query/RegexpQueryBuilderTests.java +++ b/server/src/test/java/org/opensearch/index/query/RegexpQueryBuilderTests.java @@ -57,7 +57,7 @@ protected RegexpQueryBuilder doCreateTestQueryBuilder() { for (int i = 0; i < iter; i++) { flags.add(randomFrom(RegexpFlag.values())); } - query.flags(flags.toArray(new RegexpFlag[flags.size()])); + query.flags(flags.toArray(new RegexpFlag[0])); } if (randomBoolean()) { query.caseInsensitive(true); diff --git a/server/src/test/java/org/opensearch/index/query/SimpleQueryStringBuilderTests.java b/server/src/test/java/org/opensearch/index/query/SimpleQueryStringBuilderTests.java index 1101da8de70fe..fa8646d8628a0 100644 --- a/server/src/test/java/org/opensearch/index/query/SimpleQueryStringBuilderTests.java +++ b/server/src/test/java/org/opensearch/index/query/SimpleQueryStringBuilderTests.java @@ -108,7 +108,7 @@ protected SimpleQueryStringBuilder doCreateTestQueryBuilder() { flagSet.add(randomFrom(SimpleQueryStringFlag.values())); } if (flagSet.size() > 0) { - result.flags(flagSet.toArray(new SimpleQueryStringFlag[flagSet.size()])); + result.flags(flagSet.toArray(new SimpleQueryStringFlag[0])); } } diff --git a/server/src/test/java/org/opensearch/index/query/TermsQueryBuilderTests.java b/server/src/test/java/org/opensearch/index/query/TermsQueryBuilderTests.java index e9a285208f1a6..4c8d48de114fa 100644 --- a/server/src/test/java/org/opensearch/index/query/TermsQueryBuilderTests.java +++ b/server/src/test/java/org/opensearch/index/query/TermsQueryBuilderTests.java @@ -232,7 +232,7 @@ public GetResponse executeGet(GetRequest getRequest) { try { XContentBuilder builder = XContentFactory.jsonBuilder().prettyPrint(); builder.startObject(); - builder.array(termsPath, randomTerms.toArray(new Object[randomTerms.size()])); + builder.array(termsPath, randomTerms.toArray(new Object[0])); builder.endObject(); json = Strings.toString(builder); } catch (IOException ex) { diff --git a/server/src/test/java/org/opensearch/index/seqno/LocalCheckpointTrackerTests.java b/server/src/test/java/org/opensearch/index/seqno/LocalCheckpointTrackerTests.java index 3a450e1f72a8d..7a79c58768575 100644 --- a/server/src/test/java/org/opensearch/index/seqno/LocalCheckpointTrackerTests.java +++ b/server/src/test/java/org/opensearch/index/seqno/LocalCheckpointTrackerTests.java @@ -235,7 +235,7 @@ public void testConcurrentReplica() throws InterruptedException { seqNoPerThread[t] = randomSubsetOf(size, seqNos).toArray(new Integer[size]); seqNos.removeAll(Arrays.asList(seqNoPerThread[t])); } - seqNoPerThread[threads.length - 1] = seqNos.toArray(new Integer[seqNos.size()]); + seqNoPerThread[threads.length - 1] = seqNos.toArray(new Integer[0]); logger.info("--> will run [{}] threads, maxOps [{}], unfinished seq no [{}]", threads.length, maxOps, unFinishedSeq); final CyclicBarrier barrier = new CyclicBarrier(threads.length); for (int t = 0; t < threads.length; t++) { diff --git a/server/src/test/java/org/opensearch/index/translog/SnapshotMatchers.java b/server/src/test/java/org/opensearch/index/translog/SnapshotMatchers.java index 0277e420f74ed..2d15eb3ae8497 100644 --- a/server/src/test/java/org/opensearch/index/translog/SnapshotMatchers.java +++ b/server/src/test/java/org/opensearch/index/translog/SnapshotMatchers.java @@ -68,7 +68,7 @@ public static Matcher equalsTo(Translog.Operation... ops) { * Consumes a snapshot and make sure it's content is as expected */ public static Matcher equalsTo(List ops) { - return new EqualMatcher(ops.toArray(new Translog.Operation[ops.size()])); + return new EqualMatcher(ops.toArray(new Translog.Operation[0])); } public static Matcher containsOperationsInAnyOrder(Collection expectedOperations) { diff --git a/server/src/test/java/org/opensearch/indices/cluster/IndicesClusterStateServiceRandomUpdatesTests.java b/server/src/test/java/org/opensearch/indices/cluster/IndicesClusterStateServiceRandomUpdatesTests.java index 22481b5a7b99f..ce4142363a54e 100644 --- a/server/src/test/java/org/opensearch/indices/cluster/IndicesClusterStateServiceRandomUpdatesTests.java +++ b/server/src/test/java/org/opensearch/indices/cluster/IndicesClusterStateServiceRandomUpdatesTests.java @@ -338,7 +338,7 @@ public ClusterState randomInitialClusterState( for (int i = 0; i < randomIntBetween(2, 5); i++) { allNodes.add(createNode()); } - ClusterState state = ClusterStateCreationUtils.state(localNode, localNode, allNodes.toArray(new DiscoveryNode[allNodes.size()])); + ClusterState state = ClusterStateCreationUtils.state(localNode, localNode, allNodes.toArray(new DiscoveryNode[0])); // add nodes to clusterStateServiceMap updateNodes(state, clusterStateServiceMap, indicesServiceSupplier); return state; @@ -420,7 +420,7 @@ public ClusterState randomlyUpdateClusterState( indicesToDelete.add(state.metadata().index(index).getIndex().getName()); } if (indicesToDelete.isEmpty() == false) { - DeleteIndexRequest deleteRequest = new DeleteIndexRequest(indicesToDelete.toArray(new String[indicesToDelete.size()])); + DeleteIndexRequest deleteRequest = new DeleteIndexRequest(indicesToDelete.toArray(new String[0])); state = cluster.deleteIndices(state, deleteRequest); for (String index : indicesToDelete) { assertFalse(state.metadata().hasIndex(index)); @@ -452,9 +452,7 @@ public ClusterState randomlyUpdateClusterState( } } if (indicesToUpdate.isEmpty() == false) { - UpdateSettingsRequest updateSettingsRequest = new UpdateSettingsRequest( - indicesToUpdate.toArray(new String[indicesToUpdate.size()]) - ); + UpdateSettingsRequest updateSettingsRequest = new UpdateSettingsRequest(indicesToUpdate.toArray(new String[0])); Settings.Builder settings = Settings.builder(); if (containsClosedIndex == false) { settings.put(SETTING_NUMBER_OF_REPLICAS, randomInt(2)); diff --git a/server/src/test/java/org/opensearch/indices/store/IndicesStoreTests.java b/server/src/test/java/org/opensearch/indices/store/IndicesStoreTests.java index a3130400719ad..d50145b08ee3d 100644 --- a/server/src/test/java/org/opensearch/indices/store/IndicesStoreTests.java +++ b/server/src/test/java/org/opensearch/indices/store/IndicesStoreTests.java @@ -56,7 +56,7 @@ public class IndicesStoreTests extends OpenSearchTestCase { Set set = new HashSet<>(); set.addAll(Arrays.asList(ShardRoutingState.values())); set.remove(ShardRoutingState.STARTED); - NOT_STARTED_STATES = set.toArray(new ShardRoutingState[set.size()]); + NOT_STARTED_STATES = set.toArray(new ShardRoutingState[0]); } private DiscoveryNode localNode; diff --git a/server/src/test/java/org/opensearch/search/CreatePitSingleNodeTests.java b/server/src/test/java/org/opensearch/search/CreatePitSingleNodeTests.java index ae7f795f57ee7..3a6743a334566 100644 --- a/server/src/test/java/org/opensearch/search/CreatePitSingleNodeTests.java +++ b/server/src/test/java/org/opensearch/search/CreatePitSingleNodeTests.java @@ -319,7 +319,7 @@ public void testCreatePitMoreThanMaxOpenPitContexts() throws Exception { final int maxPitContexts = SearchService.MAX_OPEN_PIT_CONTEXT.get(Settings.EMPTY); validatePitStats("index", maxPitContexts, 0, 0); // deleteall - DeletePitRequest deletePITRequest = new DeletePitRequest(pitIds.toArray(new String[pitIds.size()])); + DeletePitRequest deletePITRequest = new DeletePitRequest(pitIds.toArray(new String[0])); /** * When we invoke delete again, returns success after clearing the remaining readers. Asserting reader context diff --git a/server/src/test/java/org/opensearch/search/aggregations/support/AggregationPathTests.java b/server/src/test/java/org/opensearch/search/aggregations/support/AggregationPathTests.java index a45f890216bce..4f88e5ca55b4c 100644 --- a/server/src/test/java/org/opensearch/search/aggregations/support/AggregationPathTests.java +++ b/server/src/test/java/org/opensearch/search/aggregations/support/AggregationPathTests.java @@ -99,7 +99,7 @@ Tokens add(String name, String key) { } AggregationPath.PathElement[] toArray() { - return tokens.toArray(new AggregationPath.PathElement[tokens.size()]); + return tokens.toArray(new AggregationPath.PathElement[0]); } } } diff --git a/server/src/test/java/org/opensearch/search/fetch/subphase/highlight/HighlightBuilderTests.java b/server/src/test/java/org/opensearch/search/fetch/subphase/highlight/HighlightBuilderTests.java index 89834f80b59df..13ca6c6f918ea 100644 --- a/server/src/test/java/org/opensearch/search/fetch/subphase/highlight/HighlightBuilderTests.java +++ b/server/src/test/java/org/opensearch/search/fetch/subphase/highlight/HighlightBuilderTests.java @@ -760,7 +760,7 @@ private static String[] randomStringArray(int minSize, int maxSize) { for (int f = 0; f < size; f++) { randomStrings.add(randomAlphaOfLengthBetween(3, 10)); } - return randomStrings.toArray(new String[randomStrings.size()]); + return randomStrings.toArray(new String[0]); } /** diff --git a/server/src/test/java/org/opensearch/search/sort/FieldSortBuilderTests.java b/server/src/test/java/org/opensearch/search/sort/FieldSortBuilderTests.java index bcf458c5028cd..7dff005dc4f0a 100644 --- a/server/src/test/java/org/opensearch/search/sort/FieldSortBuilderTests.java +++ b/server/src/test/java/org/opensearch/search/sort/FieldSortBuilderTests.java @@ -707,7 +707,7 @@ protected void assertWarnings(FieldSortBuilder testItem) { expectedWarnings.add(nestedPathDeprecationWarning); } if (expectedWarnings.isEmpty() == false) { - assertWarnings(expectedWarnings.toArray(new String[expectedWarnings.size()])); + assertWarnings(expectedWarnings.toArray(new String[0])); assertedWarnings.addAll(expectedWarnings); } } diff --git a/server/src/test/java/org/opensearch/search/sort/GeoDistanceSortBuilderTests.java b/server/src/test/java/org/opensearch/search/sort/GeoDistanceSortBuilderTests.java index 87adbd9532665..4650e945f42a9 100644 --- a/server/src/test/java/org/opensearch/search/sort/GeoDistanceSortBuilderTests.java +++ b/server/src/test/java/org/opensearch/search/sort/GeoDistanceSortBuilderTests.java @@ -419,7 +419,7 @@ protected void assertWarnings(GeoDistanceSortBuilder testItem) { expectedWarnings.add(nestedPathDeprecationWarning); } if (expectedWarnings.isEmpty() == false) { - assertWarnings(expectedWarnings.toArray(new String[expectedWarnings.size()])); + assertWarnings(expectedWarnings.toArray(new String[0])); assertedWarnings.addAll(expectedWarnings); } } diff --git a/server/src/test/java/org/opensearch/search/sort/SortBuilderTests.java b/server/src/test/java/org/opensearch/search/sort/SortBuilderTests.java index 36acb1ba2f3e0..84f01c50f706b 100644 --- a/server/src/test/java/org/opensearch/search/sort/SortBuilderTests.java +++ b/server/src/test/java/org/opensearch/search/sort/SortBuilderTests.java @@ -202,7 +202,7 @@ public void testRandomSortBuilders() throws IOException { assertEquals(iterator.next(), parsedBuilder); } if (expectedWarningHeaders.size() > 0) { - assertWarnings(expectedWarningHeaders.toArray(new String[expectedWarningHeaders.size()])); + assertWarnings(expectedWarningHeaders.toArray(new String[0])); assertedWarnings.addAll(expectedWarningHeaders); } } diff --git a/server/src/test/java/org/opensearch/test/hamcrest/OpenSearchGeoAssertions.java b/server/src/test/java/org/opensearch/test/hamcrest/OpenSearchGeoAssertions.java index 96a5acf7e0b3d..511cf7c3e9ce9 100644 --- a/server/src/test/java/org/opensearch/test/hamcrest/OpenSearchGeoAssertions.java +++ b/server/src/test/java/org/opensearch/test/hamcrest/OpenSearchGeoAssertions.java @@ -99,7 +99,7 @@ private static int next(int top, Coordinate... points) { } private static Coordinate[] fixedOrderedRing(List coordinates, boolean direction) { - return fixedOrderedRing(coordinates.toArray(new Coordinate[coordinates.size()]), direction); + return fixedOrderedRing(coordinates.toArray(new Coordinate[0]), direction); } private static Coordinate[] fixedOrderedRing(Coordinate[] points, boolean direction) { diff --git a/server/src/test/java/org/opensearch/threadpool/UpdateThreadPoolSettingsTests.java b/server/src/test/java/org/opensearch/threadpool/UpdateThreadPoolSettingsTests.java index 419b100558f65..44c5937894828 100644 --- a/server/src/test/java/org/opensearch/threadpool/UpdateThreadPoolSettingsTests.java +++ b/server/src/test/java/org/opensearch/threadpool/UpdateThreadPoolSettingsTests.java @@ -248,7 +248,7 @@ public void testCustomThreadPool() throws Exception { private String randomThreadPoolName() { Set threadPoolNames = ThreadPool.THREAD_POOL_TYPES.keySet(); - return randomFrom(threadPoolNames.toArray(new String[threadPoolNames.size()])); + return randomFrom(threadPoolNames.toArray(new String[0])); } } diff --git a/test/framework/src/main/java/org/opensearch/action/support/replication/ClusterStateCreationUtils.java b/test/framework/src/main/java/org/opensearch/action/support/replication/ClusterStateCreationUtils.java index 5089368776ad6..9dcb5a07030cf 100644 --- a/test/framework/src/main/java/org/opensearch/action/support/replication/ClusterStateCreationUtils.java +++ b/test/framework/src/main/java/org/opensearch/action/support/replication/ClusterStateCreationUtils.java @@ -460,7 +460,7 @@ private static DiscoveryNode newNode(int nodeId) { } private static String selectAndRemove(Set strings) { - String selection = randomFrom(strings.toArray(new String[strings.size()])); + String selection = randomFrom(strings.toArray(new String[0])); strings.remove(selection); return selection; } diff --git a/test/framework/src/main/java/org/opensearch/repositories/blobstore/OpenSearchBlobStoreRepositoryIntegTestCase.java b/test/framework/src/main/java/org/opensearch/repositories/blobstore/OpenSearchBlobStoreRepositoryIntegTestCase.java index f2b713852584b..c5f4e171e0cf2 100644 --- a/test/framework/src/main/java/org/opensearch/repositories/blobstore/OpenSearchBlobStoreRepositoryIntegTestCase.java +++ b/test/framework/src/main/java/org/opensearch/repositories/blobstore/OpenSearchBlobStoreRepositoryIntegTestCase.java @@ -309,7 +309,7 @@ public void testSnapshotAndRestore() throws Exception { List deleteIndices = randomSubsetOf(randomIntBetween(0, indexCount), indexNames); if (deleteIndices.size() > 0) { logger.info("--> delete indices {}", deleteIndices); - assertAcked(client().admin().indices().prepareDelete(deleteIndices.toArray(new String[deleteIndices.size()]))); + assertAcked(client().admin().indices().prepareDelete(deleteIndices.toArray(new String[0]))); } Set closeIndices = new HashSet<>(Arrays.asList(indexNames)); @@ -335,7 +335,7 @@ public void testSnapshotAndRestore() throws Exception { // Wait for green so the close does not fail in the edge case of coinciding with a shard recovery that hasn't fully synced yet ensureGreen(); logger.info("--> close indices {}", closeIndices); - assertAcked(client().admin().indices().prepareClose(closeIndices.toArray(new String[closeIndices.size()]))); + assertAcked(client().admin().indices().prepareClose(closeIndices.toArray(new String[0]))); } logger.info("--> restore all indices from the snapshot"); diff --git a/test/framework/src/main/java/org/opensearch/test/InternalTestCluster.java b/test/framework/src/main/java/org/opensearch/test/InternalTestCluster.java index 4863880d38052..685bb45ca2050 100644 --- a/test/framework/src/main/java/org/opensearch/test/InternalTestCluster.java +++ b/test/framework/src/main/java/org/opensearch/test/InternalTestCluster.java @@ -1743,7 +1743,7 @@ public InetSocketAddress[] httpAddresses() { for (HttpServerTransport httpServerTransport : getInstances(HttpServerTransport.class)) { addresses.add(httpServerTransport.boundAddress().publishAddress().address()); } - return addresses.toArray(new InetSocketAddress[addresses.size()]); + return addresses.toArray(new InetSocketAddress[0]); } /** diff --git a/test/framework/src/main/java/org/opensearch/test/OpenSearchIntegTestCase.java b/test/framework/src/main/java/org/opensearch/test/OpenSearchIntegTestCase.java index 94aae206c2eb3..a100aa1c9fe42 100644 --- a/test/framework/src/main/java/org/opensearch/test/OpenSearchIntegTestCase.java +++ b/test/framework/src/main/java/org/opensearch/test/OpenSearchIntegTestCase.java @@ -778,7 +778,7 @@ public final void createIndex(String... names) { success = true; } finally { if (!success && !created.isEmpty()) { - cluster().wipeIndices(created.toArray(new String[created.size()])); + cluster().wipeIndices(created.toArray(new String[0])); } } } @@ -2317,7 +2317,7 @@ protected static RestClient createRestClient( hosts.add(new HttpHost(protocol, NetworkAddress.format(address.getAddress()), address.getPort())); } } - RestClientBuilder builder = RestClient.builder(hosts.toArray(new HttpHost[hosts.size()])); + RestClientBuilder builder = RestClient.builder(hosts.toArray(new HttpHost[0])); if (httpClientConfigCallback != null) { builder.setHttpClientConfigCallback(httpClientConfigCallback); } diff --git a/test/framework/src/main/java/org/opensearch/test/XContentTestUtils.java b/test/framework/src/main/java/org/opensearch/test/XContentTestUtils.java index 5945ac01b4547..c2d36a5426fd0 100644 --- a/test/framework/src/main/java/org/opensearch/test/XContentTestUtils.java +++ b/test/framework/src/main/java/org/opensearch/test/XContentTestUtils.java @@ -293,7 +293,7 @@ static List getInsertPaths(XContentParser parser, Stack currentP currentPath.push(parser.currentName().replaceAll("\\.", "\\\\.")); } if (parser.currentToken() == XContentParser.Token.START_OBJECT) { - validPaths.add(String.join(".", currentPath.toArray(new String[currentPath.size()]))); + validPaths.add(String.join(".", currentPath.toArray(new String[0]))); while (parser.nextToken() != XContentParser.Token.END_OBJECT) { if (parser.currentToken() == XContentParser.Token.START_OBJECT || parser.currentToken() == XContentParser.Token.START_ARRAY) { diff --git a/test/framework/src/main/java/org/opensearch/test/hamcrest/OpenSearchAssertions.java b/test/framework/src/main/java/org/opensearch/test/hamcrest/OpenSearchAssertions.java index 16d44d1f8eeb4..c2032e25b06a5 100644 --- a/test/framework/src/main/java/org/opensearch/test/hamcrest/OpenSearchAssertions.java +++ b/test/framework/src/main/java/org/opensearch/test/hamcrest/OpenSearchAssertions.java @@ -272,10 +272,7 @@ public static void assertSearchHits(SearchResponse searchResponse, String... ids ); } assertThat( - "Some expected ids were not found in search results: " - + Arrays.toString(idsSet.toArray(new String[idsSet.size()])) - + "." - + shardStatus, + "Some expected ids were not found in search results: " + Arrays.toString(idsSet.toArray(new String[0])) + "." + shardStatus, idsSet.size(), equalTo(0) ); diff --git a/test/framework/src/main/java/org/opensearch/test/rest/OpenSearchRestTestCase.java b/test/framework/src/main/java/org/opensearch/test/rest/OpenSearchRestTestCase.java index ec5a617adbde9..a353f53ab1bb3 100644 --- a/test/framework/src/main/java/org/opensearch/test/rest/OpenSearchRestTestCase.java +++ b/test/framework/src/main/java/org/opensearch/test/rest/OpenSearchRestTestCase.java @@ -207,8 +207,8 @@ public void initClient() throws IOException { } clusterHosts = unmodifiableList(hosts); logger.info("initializing REST clients against {}", clusterHosts); - client = buildClient(restClientSettings(), clusterHosts.toArray(new HttpHost[clusterHosts.size()])); - adminClient = buildClient(restAdminSettings(), clusterHosts.toArray(new HttpHost[clusterHosts.size()])); + client = buildClient(restClientSettings(), clusterHosts.toArray(new HttpHost[0])); + adminClient = buildClient(restAdminSettings(), clusterHosts.toArray(new HttpHost[0])); nodeVersions = new TreeSet<>(); Map response = entityAsMap(adminClient.performRequest(new Request("GET", "_nodes/plugins"))); diff --git a/test/framework/src/main/java/org/opensearch/test/transport/MockTransportService.java b/test/framework/src/main/java/org/opensearch/test/transport/MockTransportService.java index c80b120ad0148..0324ef34c4958 100644 --- a/test/framework/src/main/java/org/opensearch/test/transport/MockTransportService.java +++ b/test/framework/src/main/java/org/opensearch/test/transport/MockTransportService.java @@ -257,7 +257,7 @@ private static TransportAddress[] extractTransportAddresses(TransportService tra BoundTransportAddress boundTransportAddress = transportService.boundAddress(); transportAddresses.addAll(Arrays.asList(boundTransportAddress.boundAddresses())); transportAddresses.add(boundTransportAddress.publishAddress()); - return transportAddresses.toArray(new TransportAddress[transportAddresses.size()]); + return transportAddresses.toArray(new TransportAddress[0]); } @Override From db3e36e0fd94ebde98e0e6cea4cf363443a745c3 Mon Sep 17 00:00:00 2001 From: Rabi Panda Date: Wed, 16 Nov 2022 10:17:16 -0800 Subject: [PATCH 2/2] Remove CHANGELOG.md Signed-off-by: Rabi Panda --- CHANGELOG.md | 1 - 1 file changed, 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 46070acff547b..16af268875578 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -43,7 +43,6 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), - Relax visibility of the HTTP_CHANNEL_KEY and HTTP_SERVER_CHANNEL_KEY to make it possible for the plugins to access associated Netty4HttpChannel / Netty4HttpServerChannel instance ([#4638](https://github.com/opensearch-project/OpenSearch/pull/4638)) - Use ReplicationFailedException instead of OpensearchException in ReplicationTarget ([#4725](https://github.com/opensearch-project/OpenSearch/pull/4725)) - Migrate client transports to Apache HttpClient / Core 5.x ([#4459](https://github.com/opensearch-project/OpenSearch/pull/4459)) -- Call 'toArray()' with an empty array instead of a pre-sized array ([#5277](https://github.com/opensearch-project/OpenSearch/pull/5277)) ### Deprecated