Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Decide] how do we name , organize and build visualization plugin/ widgets #130

Open
Tracked by #174
mnkugler opened this issue Nov 30, 2022 · 3 comments
Open
Tracked by #174
Assignees
Labels
enhancement New feature or request

Comments

@mnkugler
Copy link

mnkugler commented Nov 30, 2022

There are a few issues with how this plugin is set up name-wise and folder-wise. If the plan was to eventually include other visualisations, this plan has been superceded by the one-plugin-per-repo decision.

Additionally, as per https://github.com/opensearch-project/opensearch-plugins/blob/main/CONVENTIONS.md#plugin-naming-conventions, the plug-in name does not adhere to the naming convention.

Also, as per opensearch-project/opensearch-build#2188, we should get rid of the gantt-chart folder and move build.gradle, etc. to the root folder of the repo.

There is also the option of renaming this entire plugin, as it seems to just be the gantt chart rather than "visualizations."

Should this be a plugin at all?

Referred to here:
opensearch-project/opensearch-plugins#174

@mnkugler mnkugler added bug Something isn't working untriaged labels Nov 30, 2022
@mnkugler
Copy link
Author

mnkugler commented Apr 6, 2023

Hi @anirudha and @joshuali925. Noticed you are assign to this issue. Can you provide a status update on resolving this?

@anirudha
Copy link
Collaborator

this is a visualization-plugin to visualize in dashboards visualization system. We are add-ing new visualization and widgets here to make them pluggable in to Dashboards.

cc: @peter fitz & @joshuali925 ; we will dedicate some time after 2.7 release to review this.

Question : do we have a naming convention for visualization plugins ? should we extend that ? and also introduce widgets

@anirudha
Copy link
Collaborator

This is not an Dashboards plugin, but a visualization plugin inside dashboards.

@anirudha anirudha changed the title [BUG] Names don't adhere to plugin naming convention [Decide] how do we name , organize and build visualization plugin/ widgets Apr 11, 2023
@anirudha anirudha added enhancement New feature or request and removed bug Something isn't working labels Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants