-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Infrastructure] BWC tests for Chunking Processor #647
Comments
@yuye-aws Can you add the bwc tests for the feature. |
This feature implements a new processor for text chunking, which does not break any existing functionalities. I do not think there is any potential risk of breaking the backward compatibility. You can also verify that with my code. Can we simply close this issue? |
Feel free to raise any concerns regarding the necessity of BWC test. |
@yuye-aws We need BWC tests for future releases. Like when 2.14 will be released then we need to run bwc test for the same functionality. |
Hi @vibrantvarun , can I follow your PR in this issue? Is BWC test a hard requirement for 2.14 release? |
I would say right now as a best practice we should add the BWC test. This will help in future to catch bugs if we are making changes in these processors or if any breaking change comes from Opensearch core. I am coming up with the more detailed developer guide for adding new features in neural search plugin and I will include this as a point there. We can discuss whether BWC should be a hard requirement there and lets other maintainers share their thoughts. |
Sure. I will implement the BWC tests. |
Hi @navneet1v and @vibrantvarun ! This PR implements the BWC test for text chunking processor. Can you help review? |
Reviewed and added the comments. |
BWC tests for chunking processor wrt 607
The text was updated successfully, but these errors were encountered: