Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROPOSAL] Refactor MLCommonsClientAccessor to make it open for extension #790

Open
br3no opened this issue Jun 12, 2024 · 2 comments
Open
Labels
enhancement Enhancements Increases software capabilities beyond original client specifications help wanted Extra attention is needed

Comments

@br3no
Copy link

br3no commented Jun 12, 2024

What/Why

What are you proposing?

Cf. #710 (comment)

What users have asked for this feature?

This is a requirement from @martin-gaievski.

What problems are you trying to solve?

The change in #710 surfaced this problem. If every addition of a new parameter leads to a new method needing to be written, this makes changes very expensive.

What is the developer experience going to be?

Improved.

Are there any security considerations?

None.

Are there any breaking changes to the API

No. This is an internal class.

What is the user experience going to be?

No change.

Are there breaking changes to the User Experience?

No.

Why should it be built? Any reason not to?

What will it take to execute?

Create a POJO class to encapsulate the parameters, making it easier to extend functionality.

Any remaining open questions?

No.

@dblock
Copy link
Member

dblock commented Jul 1, 2024

[Catch All Triage - Attendees 1, 2, 3, 4, 5]

@dblock dblock added Enhancements Increases software capabilities beyond original client specifications enhancement and removed untriaged labels Jul 1, 2024
@navneet1v
Copy link
Collaborator

Thanks @br3no this is an interesting issue. @martin-gaievski whats your thought?

@navneet1v navneet1v added the help wanted Extra attention is needed label Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancements Increases software capabilities beyond original client specifications help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants