Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] SearchTemplateResponse should include aggregations and suggest #456

Closed
eNorby1 opened this issue Apr 17, 2023 · 5 comments · Fixed by #462
Closed

[FEATURE] SearchTemplateResponse should include aggregations and suggest #456

eNorby1 opened this issue Apr 17, 2023 · 5 comments · Fixed by #462
Labels
enhancement New feature or request

Comments

@eNorby1
Copy link
Contributor

eNorby1 commented Apr 17, 2023

The SearchTemplateResponse currently only includes hits, but would be useful if it also had the aggregations and suggest (optional) fields, same as the regular SearchResponse.

@eNorby1 eNorby1 added enhancement New feature or request untriaged labels Apr 17, 2023
@wbeckler
Copy link

Is it available from the server? As in, is this a client parsing and response object issue, or is it a feature request on the opensearch server?

@eNorby1
Copy link
Contributor Author

eNorby1 commented Apr 17, 2023

It is - from what I can tell the server response is pretty much the same as in a regular SearchResponse. Which makes sense, the request template just gets resolved to a regular query (that can include suggestions and aggregations), the response wouldn't be different.

@bohyunjung
Copy link

bohyunjung commented Apr 19, 2023

+1

@wbeckler
It is a client parsing and response object issue.

We're experiencing the same issue using the OpenSearch Java client - When we make a request using SearchTemplate, We cannot access to the aggregations field by SearchTemplateResponse while the server response apparently has it.

@MrEyratnz
Copy link

+1 for aggregations (honestly, +1 for feature-parity with RHLC).

Would prefer using the java client, but the RHLC seems much more feature-complete.

Given the existing deprecation notice for the RHLC for OS 3.0.0, is there currently a timeline for feature-parity between the two clients?

@dblock
Copy link
Member

dblock commented Apr 24, 2023

The code generation project (see #318 and #366) should reach parity and some.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants