Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Remove bwc code related to 1.0 and earlier version #242

Closed
owaiskazi19 opened this issue Nov 11, 2022 · 0 comments
Closed

[BUG] Remove bwc code related to 1.0 and earlier version #242

owaiskazi19 opened this issue Nov 11, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@owaiskazi19
Copy link
Member

owaiskazi19 commented Nov 11, 2022

What is the bug?

OpenSearch core removed opensearch-project/OpenSearch#5021 1x Version constants and because of which build is failing for AD Extension: https://github.com/opensearch-project/anomaly-detection/actions/runs/3415307724/jobs/5739978293

/home/runner/work/anomaly-detection/anomaly-detection/src/main/java/org/opensearch/ad/cluster/ADVersionUtil.java:47: error: cannot find symbol
        return adVersion != null && adVersion.onOrAfter(Version.V_1_1_0);
                                                               ^
  symbol:   variable V_1_1_0

> Task :compileJava
  location: class Version
/home/runner/work/anomaly-detection/anomaly-detection/src/main/java/org/opensearch/ad/util/Bwc.java:[30](https://github.com/opensearch-project/anomaly-detection/actions/runs/3415307724/jobs/5739978293#step:10:31): error: cannot find symbol
        return version.after(Version.V_1_0_0);
                                    ^
                          

What solution would you like?

This is inherited from Elasticsearch and Lucene. So version 1x is not compatible with 3.0. Hence, remove deprecated 1x code.

What alternatives have you considered?

A clear and concise description of any alternative solutions or features you've considered.

Do you have any additional context?

Add any other context or screenshots about the feature request here.

@owaiskazi19 owaiskazi19 added enhancement New feature or request untriaged labels Nov 11, 2022
@owaiskazi19 owaiskazi19 self-assigned this Nov 11, 2022
@owaiskazi19 owaiskazi19 changed the title [FEATURE] Remove bwc code related to 1.0 and earlier version [BUG] Remove bwc code related to 1.0 and earlier version Nov 11, 2022
@owaiskazi19 owaiskazi19 added bug Something isn't working and removed enhancement New feature or request untriaged labels Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant