Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copyright line to license headers #196

Merged
merged 3 commits into from
Oct 19, 2022

Conversation

dbwiddis
Copy link
Member

Description

Adds copyright line to conform license header to format per https://github.com/opensearch-project/.github/blob/main/CONTRIBUTING.md#java

Issues Resolved

Fixes #194

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dbwiddis dbwiddis requested a review from a team October 17, 2022 19:06
@dbwiddis
Copy link
Member Author

I should probably make changes to the workflow_run trickery from #193. While the gradle check is correctly triggered,

  • it does not show up in the checks associated with this PR
  • the pull_request and pull_request_target triggers are redundant and it runs twice.

Screen Shot 2022-10-17 at 12 08 41 PM

@peternied
Copy link
Member

You can use a smaller license header, while you are doing so I'd recommend the tiny one [1] [2]

/*
 * Copyright OpenSearch Contributors
 * SPDX-License-Identifier: Apache-2.0
 */

[1] opensearch-project/OpenSearch#4657
[2] opensearch-project/alerting#136 (comment)

@owaiskazi19
Copy link
Member

We should wait for gradle check to run on this PR before merging it.

@dbwiddis dbwiddis marked this pull request as draft October 17, 2022 19:13
@dbwiddis
Copy link
Member Author

Flipping this to draft to discuss @peternied comment. I went searching everywhere for that official guidance, and it's very confusing.

Why is the contributing document not up to date with the guidance in this comment from @AMoo-Miki?

What is the scope of "like this one" mentioned in that comment?

Where is the official guidance if not at the CONTRIBUTING link cited above?

@dbwiddis
Copy link
Member Author

I believe the guidance linked by @peternied is outdated as of opensearch-project/.github#76 which updated to the version I'm using.

I filed an issue to request final clarification: opensearch-project/.github#98

@dbwiddis
Copy link
Member Author

We should wait for gradle check to run on this PR before merging it.

Gradle check ran, but you can't see it. 😁 See #197 so that stops happening.

I think the header is the correct one and this PR will stand as-is, but will wait for confirmation on the above issue I filed before flipping this back to review. Only need one spammy header update.

@dbwiddis dbwiddis marked this pull request as ready for review October 18, 2022 18:24
@dbwiddis dbwiddis requested review from joshpalis and removed request for ryanbogan October 19, 2022 17:46
Copy link
Member

@joshpalis joshpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Dan for taking care of this!

@joshpalis joshpalis merged commit 92a12c0 into opensearch-project:main Oct 19, 2022
@peternied
Copy link
Member

I think the header is the correct one and this PR will stand as-is, but will wait for confirmation on the above issue I filed before flipping this back to review. Only need one spammy header update.

@joshpalis I don't think Dan wanted this merged yet. Maybe next time we should add a Changes Requested to ensure enthusiastic merging doesn't happen.

@dbwiddis dbwiddis deleted the license branch November 16, 2022 17:03
kokibas pushed a commit to kokibas/opensearch-sdk-java that referenced this pull request Mar 17, 2023
* Delete unnecessary netty licenses missed in opensearch-project#76

Signed-off-by: Daniel Widdis <[email protected]>

* Add copyright line to license header

Signed-off-by: Daniel Widdis <[email protected]>

* Add copyright to headers via spotlessApply

Signed-off-by: Daniel Widdis <[email protected]>

Signed-off-by: Daniel Widdis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

License Header Update
5 participants